Ravi Nori has posted comments on this change.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
......................................................................
Patch Set 2: (1 inline comment)
Please see my message
....................................................
File backend/manager/tools/dbutils/taskcleaner.sh
Line 105: }
Line 106:
Line 107: # Install taskcleaner procedures
Line 108: psql -U ${USERNAME} -h ${SERVERNAME} -p ${PORT} -f
./taskcleaner_sp.sql ${DATABASE} > /dev/null
Line 109: status =`echo $?`
Hi Eli,
I tried status=`$?` and the subsequent if statement fails. Please try the
following two. Only the second one works
====1=====
! true
status=`$?`
if [ $status -ne 0 ]; then
echo $status
exit $status
fi
and
====2=====
! true
status=`echo $?`
if [ $status -ne 0 ]; then
echo $status
exit $status
fi
Line 110: if [$status -ne 0]; then
Line 111: exit $status
Line 112: fi
Line 113:
--
To view, visit http://gerrit.ovirt.org/12103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
