Michael Pasternak has posted comments on this change.
Change subject: restapi : Add /clusters sub-collection under
/datacenters/xxx(#674521)
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResource.java
Line 41: return clustersInDataCenter.get(clusterId);
Line 42: }
Line 43:
Line 44: private void initClustersInDataCenter() {
Line 45: Clusters clusters = list();
by doing this change, it's not any different from the "patch set 6", you still
using list() that maps all clusters to the api entities (please consider impl.
suggestion from the patch set 6),
also i would not use caching of the clusters.
Line 46: clustersInDataCenter = new HashMap<String, Cluster>();
Line 47: for (Cluster cluster : clusters.getClusters()) {
Line 48: clustersInDataCenter.put(cluster.getId(), cluster);
Line 49: }
--
To view, visit http://gerrit.ovirt.org/11618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b27ef501324d890efbe0e8b914d9db47653f146
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
