[Engine-patches] Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session

2013-02-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Non-plugin automatic invocation of console session .. Patch Set 1: (1 inline comment) File backend/m

[Engine-patches] Change in ovirt-engine[master]: frontend: Non-plugin automatic invocation of console session

2013-02-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: frontend: Non-plugin automatic invocation of console session .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add details to general Cluster sub-tab

2013-02-04 Thread omasad
ofri masad has uploaded a new change for review. Change subject: webadmin: Add details to general Cluster sub-tab .. webadmin: Add details to general Cluster sub-tab Added some information about the selected Cluster to sub-tab '

[Engine-patches] Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session

2013-02-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Non-plugin automatic invocation of console session .. Patch Set 1: (6 inline comments) File backend/m

[Engine-patches] Change in ovirt-engine[master]: engine: check if host exists with same name

2013-02-04 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: check if host exists with same name .. Patch Set 10: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10910 To uns

[Engine-patches] Change in ovirt-engine[master]: webadmin: Check fir NPE in AsyncDataProvider:GetInterfaceOpt...

2013-02-04 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: Check fir NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwork .. webadmin: Check fir NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwor

[Engine-patches] Change in ovirt-engine[master]: webadmin: A NPE check in SetupNetworksModel:onEdit

2013-02-04 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: A NPE check in SetupNetworksModel:onEdit .. webadmin: A NPE check in SetupNetworksModel:onEdit There's a possible branch of statement, that if execut

[Engine-patches] Change in ovirt-engine[master]: api: Current:currents needs to be static to avoid deadly emb...

2013-02-04 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: api: Current:currents needs to be static to avoid deadly embrace. .. api: Current:currents needs to be static to avoid deadly embrace. Discovered by findbugs:

[Engine-patches] Change in ovirt-engine[master]: webadmin: Bypassing findbugs issue of incorrect lazy initial...

2013-02-04 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: Bypassing findbugs issue of incorrect lazy initialization. .. webadmin: Bypassing findbugs issue of incorrect lazy initialization. Findbug is refere

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.

2013-02-04 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel. .. webadmin: Fixing infinent loop in NewGuideVmInterfaceModel. Fix for the static invocation of New

[Engine-patches] Change in ovirt-engine[master]: webadmin: A NPE check in ImportVmModel:init method.

2013-02-04 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: A NPE check in ImportVmModel:init method. .. webadmin: A NPE check in ImportVmModel:init method. There's a possible branch of statement, that if exec

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renamed EventListModel.forceRefrest->forceRefreshW...

2013-02-04 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: Renamed EventListModel.forceRefrest->forceRefreshWithoutTimers. .. webadmin: Renamed EventListModel.forceRefrest->forceRefreshWithoutTimers. Renamed

[Engine-patches] Change in ovirt-engine[master]: uicommonweb: timezone reset when os type change in VM popup

2013-02-04 Thread plysab
ly pan has uploaded a new change for review. Change subject: uicommonweb: timezone reset when os type change in VM popup .. uicommonweb: timezone reset when os type change in VM popup It is done by caching the timezone value str

[Engine-patches] Change in ovirt-engine[master]: [WIP] webadmin: UI plugin dialog API improved

2013-02-04 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: [WIP] webadmin: UI plugin dialog API improved .. [WIP] webadmin: UI plugin dialog API improved This patch improves the existing UI plugin API for handling dialo

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: core: improve error message of export template .. core: improve error message of export template Improving the error message displayed in case of export tem

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: improve error message of export template .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11716 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: improve error message of export template .. Patch Set 2: Verified added the fixed message to AppErrors.java as well -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: improve error message of export template .. Patch Set 1: Strange, will have a look at it, basically the webadmin should take it's strings from the AppErrors.j

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: improve error message of export template .. Patch Set 1: Actually, even without fixing AppErrors.java the webadmin shows the correct message - I marked it

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: improve error message of export template .. Patch Set 1: Please fix also AppErrors.java in webadmin module, otherwise the old message will still be shown in t

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: improve error message of export template .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11716 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: improve error message of export template

2013-02-04 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: core: improve error message of export template .. core: improve error message of export template Improving the error message displayed in case of export template

[Engine-patches] Change in ovirt-engine[master]: core: Change vm_pools entity to VmPool

2013-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Change vm_pools entity to VmPool .. Patch Set 1: (1 inline comment) File backend/manager/modules/restapi/

[Engine-patches] Change in ovirt-engine[master]: core: Change vm_pools entity to VmPool

2013-02-04 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: Change vm_pools entity to VmPool .. Patch Set 1: (1 inline comment) File backend/manager/modules/resta

[Engine-patches] Change in ovirt-engine[master]: core: Change VmPool method names to fit the standard

2013-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Change VmPool method names to fit the standard .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11715 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Change vm_pools entity to VmPool

2013-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Change vm_pools entity to VmPool .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11714 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: restapi : Multiple events in the UI about logged in user.

2013-02-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : Multiple events in the UI about logged in user. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11713 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: restapi : Multiple events in the UI about logged in user.

2013-02-04 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: restapi : Multiple events in the UI about logged in user. .. restapi : Multiple events in the UI about logged in user. When the session is validate the backend logs

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Show warning for non-exportable disks

2013-02-04 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: userportal, webadmin: Show warning for non-exportable disks .. userportal, webadmin: Show warning for non-exportable disks Display warning in Create VM te

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Show warning for non-exportable disks

2013-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal, webadmin: Show warning for non-exportable disks .. Patch Set 6: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: Allow plugins to specify if they want their dynamic tabs and...

2013-02-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: Allow plugins to specify if they want their dynamic tabs and sub tabs right or left justified. .. Patch Set 1: please change the commit comment to conform to the

[Engine-patches] Change in ovirt-engine[master]: Allow plugins to specify if they want their dynamic tabs and...

2013-02-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: Allow plugins to specify if they want their dynamic tabs and sub tabs right or left justified. .. Patch Set 1: I'm planning to introduce optional argument objec

[Engine-patches] Change in ovirt-engine[master]: restapi : malformated guid's cause http 500 (#902073)

2013-02-04 Thread rnori
Ravi Nori has abandoned this change. Change subject: restapi : malformated guid's cause http 500 (#902073) .. Patch Set 1: Abandoned Will submit a better patch -- To view, visit http://gerrit.ovirt.org/11581 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: restapi : vm/template Import candidates should have /disks (...

2013-02-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : vm/template Import candidates should have /disks (#829672) .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11126 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: engine: check if host exists with same name

2013-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: check if host exists with same name .. Patch Set 10: Looks good to me, but someone else must approve Giving +1 - I see Laszlo fixed Sahina's comment (co

[Engine-patches] Change in ovirt-engine[master]: packaging: Move dependencies to a JBoss module

2013-02-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Move dependencies to a JBoss module .. Patch Set 1: It looks ok, just I don't understand the jboss module thing... can you please explain what do you

[Engine-patches] Change in ovirt-engine[master]: Send http 400 when mapping error

2013-02-04 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: Send http 400 when mapping error .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11059 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: Create artifact for PostgreSQL module

2013-02-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: Create artifact for PostgreSQL module .. Patch Set 1: (3 inline comments) File backend/manager/dependen

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: suggest path for local storage during AIO setup

2013-02-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: suggest path for local storage during AIO setup .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: packaging: modified validation of fqdn input during setup

2013-02-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: modified validation of fqdn input during setup .. Patch Set 1: > So specify an IP address as fqdn should be denied? As far as I know IP address is not

[Engine-patches] Change in ovirt-engine[master]: restapi : Add /clusters sub-collection under /datacenters/xx...

2013-02-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : Add /clusters sub-collection under /datacenters/xxx(#674521) .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/11618 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed a spelling mistake in AuditLogAgingThreashold ...

2013-02-04 Thread asaf
Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold config var .. engine: Fixed a spelling mistake in AuditLogAgingThreashold config var Fixed

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed a spelling mistake in AuditLogAgingThreashold ...

2013-02-04 Thread asaf
Asaf Shakarchi has posted comments on this change. Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold config var .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: restapi : Add /networks sub-collection under /datacenters/xx...

2013-02-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : Add /networks sub-collection under /datacenters/xxx(#74) .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11707 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: Allow plugins to specify if they want their dynamic tabs and...

2013-02-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: Allow plugins to specify if they want their dynamic tabs and sub tabs right or left justified. .. Patch Set 1: Re-posting my API change proposal since gerrit me

[Engine-patches] Change in ovirt-engine[master]: Allow plugins to specify if they want their dynamic tabs and...

2013-02-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: Allow plugins to specify if they want their dynamic tabs and sub tabs right or left justified. .. Patch Set 1: Nice patch Spenser! I have only one comment: mayb

[Engine-patches] Change in ovirt-engine[master]: restapi : Add /clusters sub-collection under /datacenters/xx...

2013-02-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : Add /clusters sub-collection under /datacenters/xxx(#674521) .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11618 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: restapi : Add /networks sub-collection under /datacenters/xx...

2013-02-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : Add /networks sub-collection under /datacenters/xxx(#74) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11707 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: restapi : Add /networks sub-collection under /datacenters/xx...

2013-02-04 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: restapi : Add /networks sub-collection under /datacenters/xxx(#74) .. restapi : Add /networks sub-collection under /datacenters/xxx(#74) Adds datacenters/n

[Engine-patches] Change in samples-uiplugins[master]: Shell-In-A-Box UI plugin - adding RPM spec file

2013-02-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: Shell-In-A-Box UI plugin - adding RPM spec file .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11198 T

[Engine-patches] Change in samples-uiplugins[master]: Shell-In-A-Box UI plugin - adding RPM spec file

2013-02-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: Shell-In-A-Box UI plugin - adding RPM spec file .. Patch Set 4: (4 inline comments) Just some minor comments, nothing serious :-) ..

[Engine-patches] Change in ovirt-engine[master]: core: Eliminated use of StringHelper.EqOp

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Eliminated use of StringHelper.EqOp .. Patch Set 3: Verified; Looks good to me, approved Regarding last comment, stand corrected, the EqOp Was removed in th

[Engine-patches] Change in ovirt-engine[master]: packaging: modified validation of fqdn input during setup

2013-02-04 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: modified validation of fqdn input during setup .. Patch Set 1: So specify an IP address as fqdn should be denied? -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Eliminated use of StringHelper.EqOp

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Eliminated use of StringHelper.EqOp .. Patch Set 3: (1 inline comment) File backend/manager/modules/co

[Engine-patches] Change in ovirt-engine[master]: core: Eliminated use of StringHelper.EqOp

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Eliminated use of StringHelper.EqOp .. Patch Set 3: I would prefer that you didn't submit this You got more classes which uses eqOp, which needs to be handl

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: updated user prompts for stopping ovirt-engine se...

2013-02-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: updated user prompts for stopping ovirt-engine service during setup .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visi

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: suggest path for local storage during AIO setup

2013-02-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: suggest path for local storage during AIO setup .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Added caching

2013-02-04 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: Added caching .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10449 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: webadmin: UI-Plugins - fix host name mapping

2013-02-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: UI-Plugins - fix host name mapping .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11420 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: webadmin: UI-Plugins - VM IP address mapping

2013-02-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: UI-Plugins - VM IP address mapping .. Patch Set 1: Looks good to me, approved In future, we're planning to use generated classes from "restapi-definiti

[Engine-patches] Change in ovirt-engine[master]: core: Eliminated use of StringHelper.EqOp

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Eliminated use of StringHelper.EqOp .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11670 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: updated user prompts for stopping ovirt-engine se...

2013-02-04 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: updated user prompts for stopping ovirt-engine service during setup .. packaging: updated user prompts for stopping ovirt-engine service during se

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when validating move or copy.

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when validating move or copy. .. core: Use storage validator when validating move or copy. Use storage validator instead regu

[Engine-patches] Change in ovirt-engine[master]: core: Add storage space validator

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add storage space validator .. core: Add storage space validator Use the storage validator to validate if there is enough space in the storage comp

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator for images handler.

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator for images handler. .. core: Use storage validator for images handler. Use storage validator instead regular check when valid

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when validating add disk.

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when validating add disk. .. core: Use storage validator when validating add disk. Use storage validator instead regular chec

[Engine-patches] Change in ovirt-engine[master]: core: Use validate instead of using space checker.

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use validate instead of using space checker. .. core: Use validate instead of using space checker. Use validate instead storage domain space checke

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when adding template.

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when adding template. .. core: Use storage validator when adding template. Use storage validator instead regular check when v

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when adding a new VM.

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator when adding a new VM. .. core: Use storage validator when adding a new VM. Use storage validator instead regular check when a

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator on Live Migrate disk.

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage validator on Live Migrate disk. .. core: Use storage validator on Live Migrate disk. Use storage validator instead regular check when

[Engine-patches] Change in ovirt-engine[master]: core: Remove storage domain space checker

2013-02-04 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove storage domain space checker .. core: Remove storage domain space checker Removing storage domain space checker since the storage domain val

[Engine-patches] Change in ovirt-engine[master]: core: Add storage space validator

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add storage space validator .. Patch Set 8: Verified; Looks good to me, approved Acked by Allon -- To view, visit http://gerrit.ovirt.org/11511 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when adding a new VM.

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Use storage validator when adding a new VM. .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11512 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when validating move or copy.

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Use storage validator when validating move or copy. .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11513 To

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when validating add disk.

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Use storage validator when validating add disk. .. Patch Set 6: Verified; Looks good to me, approved Acked by Allon -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when adding template.

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Use storage validator when adding template. .. Patch Set 6: Verified; Looks good to me, approved Acked by Allon -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator for images handler.

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Use storage validator for images handler. .. Patch Set 6: Verified; Looks good to me, approved Acked by Allon -- To view, visit http://gerrit.ovirt.org/115

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator on Live Migrate disk.

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Use storage validator on Live Migrate disk. .. Patch Set 6: Verified; Looks good to me, approved Acked by Allon -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Use validate instead of using space checker.

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Use validate instead of using space checker. .. Patch Set 6: Verified; Looks good to me, approved Acked by Allon -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Remove storage domain space checker

2013-02-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Remove storage domain space checker .. Patch Set 6: Verified; Looks good to me, approved Acked by Allon -- To view, visit http://gerrit.ovirt.org/11589 To

[Engine-patches] Change in ovirt-engine[master]: core: Remove storage domain space checker

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove storage domain space checker .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11589 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Use validate instead of using space checker.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use validate instead of using space checker. .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11588 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator on Live Migrate disk.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator on Live Migrate disk. .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11587 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator for images handler.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator for images handler. .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11586 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when adding template.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator when adding template. .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11585 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when validating add disk.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator when validating add disk. .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11584 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: tools: In case ldapServers is used, useDnsLookup should be i...

2013-02-04 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: In case ldapServers is used, useDnsLookup should be ignored .. tools: In case ldapServers is used, useDnsLookup should be ignored As a part of

[Engine-patches] Change in ovirt-engine[master]: tools: In case ldapServers is used, useDnsLookup should be i...

2013-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: In case ldapServers is used, useDnsLookup should be ignored .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: suggest path for local storage during AIO setup

2013-02-04 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: suggest path for local storage during AIO setup .. packaging: suggest path for local storage during AIO setup When running AIO setup, the installe

[Engine-patches] Change in ovirt-engine[master]: tools: In case ldapServers is used, useDnsLookup should be i...

2013-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: In case ldapServers is used, useDnsLookup should be ignored .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when validating move or copy.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator when validating move or copy. .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11513 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Use storage validator when adding a new VM.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use storage validator when adding a new VM. .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11512 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Add storage space validator

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Add storage space validator .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11511 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: tools: In case ldapServers is used, useDnsLookup should be i...

2013-02-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools: In case ldapServers is used, useDnsLookup should be ignored .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: tools: In case ldapServers is used, useDnsLookup should be i...

2013-02-04 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: tools: In case ldapServers is used, useDnsLookup should be ignored .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11704 To

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: translations update

2013-02-04 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin, userportal: translations update .. webadmin, userportal: translations update pulled translation from Zanata oVirt project, master version. Chan

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: translations update

2013-02-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin, userportal: translations update .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/11673 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: tools: In case ldapServers is used, useDnsLookup should be i...

2013-02-04 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: tools: In case ldapServers is used, useDnsLookup should be ignored .. tools: In case ldapServers is used, useDnsLookup should be ignored As a part of introduc

[Engine-patches] Change in ovirt-engine[master]: core: Remove storage domain space checker

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove storage domain space checker .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11589 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Use validate instead using of space checker.

2013-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Use validate instead using of space checker. .. Patch Set 4: Looks good to me, approved (1 inline comment) please fix the commit message when you rebase.

  1   2   3   >