Juan Hernandez has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 1: (1 inline comment)
File
backend/m
Juan Hernandez has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
ofri masad has uploaded a new change for review.
Change subject: webadmin: Add details to general Cluster sub-tab
..
webadmin: Add details to general Cluster sub-tab
Added some information about the selected Cluster to sub-tab '
Juan Hernandez has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 1: (6 inline comments)
File backend/m
Sahina Bose has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To uns
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Check fir NPE in
AsyncDataProvider:GetInterfaceOptionsForEditNetwork
..
webadmin: Check fir NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwor
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: A NPE check in SetupNetworksModel:onEdit
..
webadmin: A NPE check in SetupNetworksModel:onEdit
There's a possible branch of statement, that if execut
Asaf Shakarchi has uploaded a new change for review.
Change subject: api: Current:currents needs to be static to avoid deadly
embrace.
..
api: Current:currents needs to be static to avoid deadly embrace.
Discovered by findbugs:
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Bypassing findbugs issue of incorrect lazy
initialization.
..
webadmin: Bypassing findbugs issue of incorrect lazy initialization.
Findbug is refere
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
..
webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
Fix for the static invocation of New
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: A NPE check in ImportVmModel:init method.
..
webadmin: A NPE check in ImportVmModel:init method.
There's a possible branch of statement, that if exec
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Renamed
EventListModel.forceRefrest->forceRefreshWithoutTimers.
..
webadmin: Renamed EventListModel.forceRefrest->forceRefreshWithoutTimers.
Renamed
ly pan has uploaded a new change for review.
Change subject: uicommonweb: timezone reset when os type change in VM popup
..
uicommonweb: timezone reset when os type change in VM popup
It is done by caching the timezone value str
Vojtech Szocs has uploaded a new change for review.
Change subject: [WIP] webadmin: UI plugin dialog API improved
..
[WIP] webadmin: UI plugin dialog API improved
This patch improves the existing UI plugin API for handling dialo
Tal Nisan has submitted this change and it was merged.
Change subject: core: improve error message of export template
..
core: improve error message of export template
Improving the error message displayed in case of export tem
Tal Nisan has posted comments on this change.
Change subject: core: improve error message of export template
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11716
To unsubscribe, visit http:
Alissa Bonas has posted comments on this change.
Change subject: core: improve error message of export template
..
Patch Set 2: Verified
added the fixed message to AppErrors.java as well
--
To view, visit http://gerrit.ovirt.o
Tal Nisan has posted comments on this change.
Change subject: core: improve error message of export template
..
Patch Set 1:
Strange, will have a look at it, basically the webadmin should take it's
strings from the AppErrors.j
Alissa Bonas has posted comments on this change.
Change subject: core: improve error message of export template
..
Patch Set 1:
Actually, even without fixing AppErrors.java the webadmin shows the correct
message - I marked it
Tal Nisan has posted comments on this change.
Change subject: core: improve error message of export template
..
Patch Set 1:
Please fix also AppErrors.java in webadmin module, otherwise the old message
will still be shown in t
Alissa Bonas has posted comments on this change.
Change subject: core: improve error message of export template
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11716
To unsubscribe, visit http://gerrit.ovirt.
Alissa Bonas has uploaded a new change for review.
Change subject: core: improve error message of export template
..
core: improve error message of export template
Improving the error message displayed in case of export template
Tal Nisan has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/restapi/
Alissa Bonas has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/resta
Tal Nisan has posted comments on this change.
Change subject: core: Change VmPool method names to fit the standard
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11715
To unsubscribe, visit http://gerrit.ovi
Tal Nisan has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11714
To unsubscribe, visit http://gerrit.ovirt.org/setting
Ravi Nori has posted comments on this change.
Change subject: restapi : Multiple events in the UI about logged in user.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11713
To unsubscribe, visit http://gerri
Ravi Nori has uploaded a new change for review.
Change subject: restapi : Multiple events in the UI about logged in user.
..
restapi : Multiple events in the UI about logged in user.
When the session is validate the backend logs
Daniel Erez has submitted this change and it was merged.
Change subject: userportal, webadmin: Show warning for non-exportable disks
..
userportal, webadmin: Show warning for non-exportable disks
Display warning in Create VM te
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: Show warning for non-exportable disks
..
Patch Set 6: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org
Einav Cohen has posted comments on this change.
Change subject: Allow plugins to specify if they want their dynamic tabs and
sub tabs right or left justified.
..
Patch Set 1:
please change the commit comment to conform to the
Vojtech Szocs has posted comments on this change.
Change subject: Allow plugins to specify if they want their dynamic tabs and
sub tabs right or left justified.
..
Patch Set 1:
I'm planning to introduce optional argument objec
Ravi Nori has abandoned this change.
Change subject: restapi : malformated guid's cause http 500 (#902073)
..
Patch Set 1: Abandoned
Will submit a better patch
--
To view, visit http://gerrit.ovirt.org/11581
To unsubscribe, vi
Ravi Nori has posted comments on this change.
Change subject: restapi : vm/template Import candidates should have /disks
(#829672)
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/11126
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10: Looks good to me, but someone else must approve
Giving +1 - I see Laszlo fixed Sahina's comment (co
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 1:
It looks ok, just I don't understand the jboss module thing... can you please
explain what do you
Laszlo Hornyak has posted comments on this change.
Change subject: Send http 400 when mapping error
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/11059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: core: Create artifact for PostgreSQL module
..
Patch Set 1: (3 inline comments)
File backend/manager/dependen
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: suggest path for local storage during AIO setup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: modified validation of fqdn input during setup
..
Patch Set 1:
> So specify an IP address as fqdn should be denied?
As far as I know IP address is not
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /clusters sub-collection under
/datacenters/xxx(#674521)
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11618
To unsubscribe, visi
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold
config var
..
engine: Fixed a spelling mistake in AuditLogAgingThreashold config var
Fixed
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold
config var
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovi
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /networks sub-collection under
/datacenters/xxx(#74)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11707
To unsubscribe, visi
Vojtech Szocs has posted comments on this change.
Change subject: Allow plugins to specify if they want their dynamic tabs and
sub tabs right or left justified.
..
Patch Set 1:
Re-posting my API change proposal since gerrit me
Vojtech Szocs has posted comments on this change.
Change subject: Allow plugins to specify if they want their dynamic tabs and
sub tabs right or left justified.
..
Patch Set 1:
Nice patch Spenser! I have only one comment: mayb
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /clusters sub-collection under
/datacenters/xxx(#674521)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11618
To unsubscribe, visi
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /networks sub-collection under
/datacenters/xxx(#74)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11707
To unsubscribe, visi
Ravi Nori has uploaded a new change for review.
Change subject: restapi : Add /networks sub-collection under
/datacenters/xxx(#74)
..
restapi : Add /networks sub-collection under /datacenters/xxx(#74)
Adds datacenters/n
Vojtech Szocs has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11198
T
Vojtech Szocs has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
..
Patch Set 4: (4 inline comments)
Just some minor comments, nothing serious :-)
..
Maor Lipchuk has posted comments on this change.
Change subject: core: Eliminated use of StringHelper.EqOp
..
Patch Set 3: Verified; Looks good to me, approved
Regarding last comment, stand corrected, the EqOp Was removed in th
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: modified validation of fqdn input during setup
..
Patch Set 1:
So specify an IP address as fqdn should be denied?
--
To view, visit http://gerrit.
Maor Lipchuk has posted comments on this change.
Change subject: core: Eliminated use of StringHelper.EqOp
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/co
Maor Lipchuk has posted comments on this change.
Change subject: core: Eliminated use of StringHelper.EqOp
..
Patch Set 3: I would prefer that you didn't submit this
You got more classes which uses eqOp, which needs to be handl
Juan Hernandez has posted comments on this change.
Change subject: packaging: updated user prompts for stopping ovirt-engine
service during setup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visi
Juan Hernandez has posted comments on this change.
Change subject: packaging: suggest path for local storage during AIO setup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Alexander Wels has posted comments on this change.
Change subject: userportal, webadmin: Added caching
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10449
To unsubscr
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI-Plugins - fix host name mapping
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11420
To unsubscribe, visit htt
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI-Plugins - VM IP address mapping
..
Patch Set 1: Looks good to me, approved
In future, we're planning to use generated classes from "restapi-definiti
Maor Lipchuk has posted comments on this change.
Change subject: core: Eliminated use of StringHelper.EqOp
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11670
To unsubscribe, visit http://
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: updated user prompts for stopping ovirt-engine
service during setup
..
packaging: updated user prompts for stopping ovirt-engine service during se
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use storage validator when validating move or copy.
..
core: Use storage validator when validating move or copy.
Use storage validator instead regu
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add storage space validator
..
core: Add storage space validator
Use the storage validator to validate if there is enough space in the
storage comp
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use storage validator for images handler.
..
core: Use storage validator for images handler.
Use storage validator instead regular check when valid
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use storage validator when validating add disk.
..
core: Use storage validator when validating add disk.
Use storage validator instead regular chec
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use validate instead of using space checker.
..
core: Use validate instead of using space checker.
Use validate instead storage domain space checke
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use storage validator when adding template.
..
core: Use storage validator when adding template.
Use storage validator instead regular check when v
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use storage validator when adding a new VM.
..
core: Use storage validator when adding a new VM.
Use storage validator instead regular check when a
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use storage validator on Live Migrate disk.
..
core: Use storage validator on Live Migrate disk.
Use storage validator instead regular check when
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove storage domain space checker
..
core: Remove storage domain space checker
Removing storage domain space checker since the storage domain val
Maor Lipchuk has posted comments on this change.
Change subject: core: Add storage space validator
..
Patch Set 8: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.org/11511
To unsubscr
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage validator when adding a new VM.
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11512
To unsubscr
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage validator when validating move or copy.
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11513
To
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage validator when validating add disk.
..
Patch Set 6: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.o
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage validator when adding template.
..
Patch Set 6: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.org/1
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage validator for images handler.
..
Patch Set 6: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.org/115
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage validator on Live Migrate disk.
..
Patch Set 6: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.org/
Maor Lipchuk has posted comments on this change.
Change subject: core: Use validate instead of using space checker.
..
Patch Set 6: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.org/
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove storage domain space checker
..
Patch Set 6: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.org/11589
To
Allon Mureinik has posted comments on this change.
Change subject: core: Remove storage domain space checker
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11589
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: Use validate instead of using space checker.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11588
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: Use storage validator on Live Migrate disk.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11587
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: Use storage validator for images handler.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11586
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Use storage validator when adding template.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11585
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: Use storage validator when validating add disk.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11584
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: In case ldapServers is used, useDnsLookup should be
ignored
..
tools: In case ldapServers is used, useDnsLookup should be ignored
As a part of
Yair Zaslavsky has posted comments on this change.
Change subject: tools: In case ldapServers is used, useDnsLookup should be
ignored
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: suggest path for local storage during AIO setup
..
packaging: suggest path for local storage during AIO setup
When running AIO setup, the installe
Yair Zaslavsky has posted comments on this change.
Change subject: tools: In case ldapServers is used, useDnsLookup should be
ignored
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Use storage validator when validating move or copy.
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11513
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: Use storage validator when adding a new VM.
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11512
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: Add storage space validator
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11511
To unsubscribe, visit http://gerrit
Ravi Nori has posted comments on this change.
Change subject: tools: In case ldapServers is used, useDnsLookup should be
ignored
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Oved Ourfali has posted comments on this change.
Change subject: tools: In case ldapServers is used, useDnsLookup should be
ignored
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11704
To
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, master version.
Chan
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/11673
To unsubscr
Yair Zaslavsky has uploaded a new change for review.
Change subject: tools: In case ldapServers is used, useDnsLookup should be
ignored
..
tools: In case ldapServers is used, useDnsLookup should be ignored
As a part of introduc
Allon Mureinik has posted comments on this change.
Change subject: core: Remove storage domain space checker
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11589
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: Use validate instead using of space checker.
..
Patch Set 4: Looks good to me, approved
(1 inline comment)
please fix the commit message when you rebase.
1 - 100 of 231 matches
Mail list logo