Juan Hernandez has posted comments on this change.

Change subject: core: Non-plugin automatic invocation of console session
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/IniServlet.java
Line 24: 
Line 25:     @Override
Line 26:     protected void doGet(HttpServletRequest request, 
HttpServletResponse response) throws ServletException, IOException {
Line 27:         try {
Line 28:             writeIniToStream(response.getOutputStream(), 
request.getParameterMap());
I understand better after reading http://gerrit.ovirt.org/11703 .
Line 29:         } catch (IOException e) {
Line 30:             log.error("Error when writing to response stream " + 
e.getMessage());
Line 31:             
response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
Line 32:         }


--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to