Alon Bar-Lev has posted comments on this change.
Change subject: core: Create artifact for PostgreSQL module
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File backend/manager/dependencies/pom.xml
Line 63: <dependencyfilesets/>
Line 64: <mapper
Line 65: id="clean.version"
Line 66:
classname="org.apache.maven.ant.tasks.support.VersionMapper"
Line 67: from="${maven.project.dependencies.versions}"
space
Line 68: to="flatten" />
Line 69:
Line 70: <!-- Copy the .jar file of the JDBC driver to the
modules
Line 71: directory: -->
....................................................
File Makefile
Line 423: @echo "*** Deploying JBoss modules"
Line 424:
Line 425: # Incompress and install the contents of the modules archive to
Line 426: # the directory containing engine modules:
Line 427: X=`find "$(MAVEN_OUTPUT_DIR)" -name
"dependencies-$(APP_VERSION)*.zip"` && unzip "$$X" -d
"$(DESTDIR)$(PKG_JBOSS_MODULES)"
Something like:
find "$(MAVEN_OUTPUT_DIR)" -name 'dependencies-$(APP_VERSION)*.zip' -exec
unzip "{}" -d "$(DESTDIR)$(PKG_JBOSS_MODULES)"
or:
find .... | while read x; do unzip ... "$${x}" ...; done
BTW: I don't like the use of APP_VERSION here... as it is the maven version not
the application version, but will change this in future.
Line 428:
Line 429: install_service:
Line 430: @echo "*** Deploying service"
Line 431:
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 486
Line 487
Line 488
Line 489
Line 490
In the past you told me that this is a workaround for specific jboss version,
it is not required in newer jboss... was I misunderstood?
--
To view, visit http://gerrit.ovirt.org/11685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad7ee2264fde3badf7d242fe3a20874e1d24d6bf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
