Michael Kublin has posted comments on this change.
Change subject: engine: Removing validateStorageServerConnection - storage part
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ov
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Removing validateStorageServerConnection - storage part
..
engine: Removing validateStorageServerConnection - storage part
The following patch
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: suggest path for local storage during AIO setup
..
Patch Set 2: Verified
Renamed DEFAULT_LOCAL_STORAGE_PATH in LOCAL_STORAGE_PATH as suggested
--
Yair Zaslavsky has posted comments on this change.
Change subject: core:DB upgrade from 3.0 to 3.1 fails
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11419
To unsubscribe, visit http://ge
Juan Hernandez has submitted this change and it was merged.
Change subject: core: updated taskcleaner to run from external python code
..
core: updated taskcleaner to run from external python code
Change-Id: Ibb894849bc73264071
Juan Hernandez has posted comments on this change.
Change subject: core: updated taskcleaner to run from external python code
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: creating a version file for fetching product version
..
packaging: creating a version file for fetching product version
Change-Id: I479668e0
Juan Hernandez has posted comments on this change.
Change subject: packaging: creating a version file for fetching product version
..
Patch Set 9: Verified; Looks good to me, approved
Merging based on previous acks and verifica
Juan Hernandez has posted comments on this change.
Change subject: packaging: creating a version file for fetching product version
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11383
To un
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: checking SELINUX status during ports redirection
..
packaging: checking SELINUX status during ports redirection
Change-Id: I2e9f4c1abc8c58a1
Juan Hernandez has posted comments on this change.
Change subject: packaging: checking SELINUX status during ports redirection
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11345
Juan Hernandez has posted comments on this change.
Change subject: packaging: checking SELINUX status during ports redirection
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11345
To unsubs
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
packaging: Updated all utilities to use backup.sh instead of pg_dump
* Previou
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
Patch Set 6: Verified; Looks good to me, approved
Merging based on previous acks and ve
Gilad Chaplik has posted comments on this change.
Change subject: userportal: redesign for resources tab
..
Patch Set 3: (2 inline comments)
File
frontend/webadmin/modules/u
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10548
Gilad Chaplik has posted comments on this change.
Change subject: core: Add 5 new Events to AuditLog
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10865
To unsubscribe
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix empty quota validation in edit disk
..
Patch Set 1: (3 inline comments)
File
backend/manager/modu
Mike Kolesnik has posted comments on this change.
Change subject: webadmin: Added functionality to Add Provider Network popup
..
Patch Set 2:
I think this comment should go on http://gerrit.ovirt.org/#/c/11429
Anyway, currentl
Deepak C Shetty has posted comments on this change.
Change subject: webadmin: Create storage domains using Gluster FS.
..
Patch Set 8:
Looks like we are hitting NPE in the engine (jboss) side during
addstorageserver which IIUC
Allon Mureinik has posted comments on this change.
Change subject: core:DB upgrade from 3.0 to 3.1 fails
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11419
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: engine: Replacing search for vms by query
..
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
minor comments on grammer
..
Dhandapani Gopal has uploaded a new change for review.
Change subject: engine:[WIP] Service Start command
..
engine:[WIP] Service Start command
Bll command to start service on the given list of servers
if server ids are pass
Sahina Bose has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
..
Patch Set 1: (7 inline comments)
Patch Set to follow with feedback changes
...
Sharad Mishra has posted comments on this change.
Change subject: engine: Removing validateStorageServerConnection - storage part
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Itamar Heim has posted comments on this change.
Change subject: engine: Fixed sorting VMs by IP address in search
..
Patch Set 1:
what's the performance impact of using a function in middle of the search?
--
To view, visit htt
Itamar Heim has posted comments on this change.
Change subject: webadmin: Added functionality to Add Provider Network popup
..
Patch Set 2:
just wondering - how is transactivity of this operation behaving?
--
To view, visit ht
Daniel Erez has posted comments on this change.
Change subject: userportal: redesign for resources tab
..
Patch Set 3: (18 inline comments)
File
frontend/webadmin/modules/gw
Tal Nisan has submitted this change and it was merged.
Change subject: core: improve messages of create/delete snapshot
..
core: improve messages of create/delete snapshot
Improve text of event log messages for creation and del
Tal Nisan has posted comments on this change.
Change subject: core: improve messages of create/delete snapshot
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11439
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: prevent spmStop on CannotRemoveLogicalVolume
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/114
Moti Asayag has posted comments on this change.
Change subject: engine: Refactored code into NetworkValidator class
..
Patch Set 6: (1 inline comment)
Except the single comment it's a +1 from me.
..
Daniel Erez has uploaded a new change for review.
Change subject: core: prevent spmStop on CannotRemoveLogicalVolume
..
core: prevent spmStop on CannotRemoveLogicalVolume
Prevent spmStop on CannotRemoveLogicalVolume VDSM error.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: checking SELINUX status during ports redirection
..
Patch Set 5:
I still don't understand why we cannot just configure apache without selinux in
this
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: creating a version file for fetching product version
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Alex Lourie has posted comments on this change.
Change subject: packaging: creating a version file for fetching product version
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/11383
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: creating a version file for fetching product version
..
Patch Set 7: Looks good to me, but someone else must approve
Thanks!
--
To view, visit http://
Arik Hadas has posted comments on this change.
Change subject: webadmin: minor cleanup in SpiceConsoleModel
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11440
To unsubscribe, visit http://gerrit.ovirt.org/
Daniel Erez has posted comments on this change.
Change subject: core: Fix empty quota validation in edit disk
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Alissa Bonas has posted comments on this change.
Change subject: core: improve messages of create/delete snapshot
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11439
To unsubscribe, visit http://gerrit.ovir
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: minor refactoring in SpiceConsoleModel
..
webadmin: minor refactoring in SpiceConsoleModel
Replace statements that check whether spice-driver-version or
Alissa Bonas has uploaded a new change for review.
Change subject: core: improve messages of create/delete snapshot
..
core: improve messages of create/delete snapshot
Improve text of event log messages for creation and deletion
ofri masad has posted comments on this change.
Change subject: core: Add 5 new Events to AuditLog
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10865
To unsubscribe, visit http://gerrit.ovirt.org/settings
ofri masad has posted comments on this change.
Change subject: core: Fix empty quota validation in edit disk
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11434
To unsubscribe, visit http://gerrit.ovirt.org
ofri masad has posted comments on this change.
Change subject: core: Add 5 new Events to AuditLog
..
Patch Set 3: (7 inline comments)
File
backend/manager/modules/common/src
Shahar Havivi has uploaded a new change for review.
Change subject: ruby: first commit
..
ruby: first commit
Change-Id: I3c7b84728e3b6d42dd0e662b903cbc2c737464ee
Signed-off-by: Shahar Havivi
---
A ruby/README
A ruby/ovirt.conf.
Lior Vernia has uploaded a new change for review.
Change subject: webadmin: Added functionality to Add Provider Network popup
..
webadmin: Added functionality to Add Provider Network popup
The window now actually adds the new ne
Allon Mureinik has posted comments on this change.
Change subject: engine: Removing validateStorageServerConnection - storage part
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11416
To un
Omer Frenkel has submitted this change and it was merged.
Change subject: core: InternalMigrateVmCommand cleanup
..
core: InternalMigrateVmCommand cleanup
Replaced convertInternalMigrateParamsToMigrateParams method in
InternalM
Omer Frenkel has submitted this change and it was merged.
Change subject: core: revert change If615a9d9
..
core: revert change If615a9d9
In patch If615a9d9 the execution context of SetNonOperationalVdsCommand
changed to async i
Omer Frenkel has posted comments on this change.
Change subject: core: InternalMigrateVmCommand cleanup
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11368
To unsubscribe, visit http://ger
Omer Frenkel has posted comments on this change.
Change subject: core: revert change If615a9d9
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11369
To unsubscribe, visit http://gerrit.ovirt
Arik Hadas has posted comments on this change.
Change subject: core: fix monitoring of SetNonOperationalVdsCommand
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/11370
To unsubscribe, visit http://gerrit.ovi
Omer Frenkel has posted comments on this change.
Change subject: core: fix monitoring of SetNonOperationalVdsCommand
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1137
Arik Hadas has posted comments on this change.
Change subject: core: revert change If615a9d9
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/11369
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Arik Hadas has posted comments on this change.
Change subject: core: InternalMigrateVmCommand cleanup
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/11368
To unsubscribe, visit http://gerrit.ovirt.org/settin
Daniel Erez has posted comments on this change.
Change subject: core: block MoveDisks on snapshot preview
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll
Mike Kolesnik has posted comments on this change.
Change subject: engine: Replacing search for vms by query
..
Patch Set 1: (2 inline comments)
Looks good, couple small comments
Mike Kolesnik has posted comments on this change.
Change subject: engine: Fixed sorting VMs by IP address in search
..
Patch Set 1: Looks good to me, but someone else must approve
Please try to separate real changes from clean
Mike Kolesnik has posted comments on this change.
Change subject: engine: Created DB function comparable_ip_list
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11432
To
Michael Kublin has posted comments on this change.
Change subject: engine: Replacing search for vms by query
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts
Michael Kublin has posted comments on this change.
Change subject: engine: Removing validateStorageServerConnection - storage part
..
Patch Set 2: Verified
rebased, removed additonal unused methods due to Allon's remark
--
To
Arik Hadas has posted comments on this change.
Change subject: webadmin: improve import conflict (for vm) dialogue
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11435
To unsubscribe, visit http://gerrit.ovi
Alex Lourie has posted comments on this change.
Change subject: packaging: suggest path for local storage during AIO setup
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
One small comment.
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: improve import conflict (for vm) dialogue
..
webadmin: improve import conflict (for vm) dialogue
The dialogue which is shown when trying to import VM or
Eli Mesika has posted comments on this change.
Change subject: core: updated taskcleaner to run from external python code
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11408
To unsubscribe
Eli Mesika has posted comments on this change.
Change subject: engine: Replacing search for vms by query
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts/vms
ofri masad has uploaded a new change for review.
Change subject: core: Fix empty quota validation in edit disk
..
core: Fix empty quota validation in edit disk
When a disk with no quota is edited and the quota is not setted by t
Allon Mureinik has submitted this change and it was merged.
Change subject: core: storage domain validation refactoring
..
core: storage domain validation refactoring
Refactored StorageDoaminValidator to return a ValidationResu
Allon Mureinik has posted comments on this change.
Change subject: core: storage domain validation refactoring
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit http://
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImagesHandler.checkDiskImages with multi-SDs
..
core: ImagesHandler.checkDiskImages with multi-SDs
In the current implementation, checkDiskImages
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler.checkDiskImages with multi-SDs
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal, +1 by Alissa.
--
T
Tal Nisan has posted comments on this change.
Change subject: core: storage domain validation refactoring
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll
Moti Asayag has posted comments on this change.
Change subject: engine: Refactored code into NetworkValidator class
..
Patch Set 5: (1 inline comment)
File
backend/manager/m
Omer Frenkel has posted comments on this change.
Change subject: In InstallFailed status we should skip preparingForMaintenance
..
Patch Set 1:
why do you have to put the host in maintenance to allow re-installation? is it
blo
Lior Vernia has uploaded a new change for review.
Change subject: engine: Fixed sorting VMs by IP address in search
..
engine: Fixed sorting VMs by IP address in search
Fixed the sorting order of IP addresses through the search
Lior Vernia has uploaded a new change for review.
Change subject: engine: Created DB function comparable_ip_list
..
engine: Created DB function comparable_ip_list
The function converts a string of IP addresses, as stored in the
Allon Mureinik has posted comments on this change.
Change subject: engine: Removal of code related to importing SAN storage domains
..
Patch Set 2: I would prefer that you didn't submit this
You missed some of the ERROR_CANNOT_
Allon Mureinik has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 8: I would prefer that you didn't submit this
Giving -1 on problems noted by Sahina just to get this of
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Map VLAN & label to network
..
engine: Map VLAN & label to network
Map the VLAN & lable returned by Quantum to the network entity fields.
Change-Id: I5
Mike Kolesnik has uploaded a new change for review.
Change subject: restapi: Support adding a network on provider
..
restapi: Support adding a network on provider
Added support for POST-ing a network to the provider's networks l
Itamar Heim has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
..
Patch Set 4:
does the service rpm actually cause a service to run when deployed?
propose to split that package t
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Added label to Network class
..
core: Added label to Network class
The label will be used to mark the physical implementation of the
network.
Change-Id:
Mike Kolesnik has uploaded a new change for review.
Change subject: restapi: Added label to network
..
restapi: Added label to network
Added the label field and mapping for it to the network model.
Change-Id: I168b080acb05911c6
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add command to add network on provider
..
engine: Add command to add network on provider
This command allows to add a new network to the external provid
Michael Kublin has posted comments on this change.
Change subject: engine: Removing validateStorageServerConnection - storage part
..
Patch Set 1: (1 inline comment)
File
ba
Eli Mesika has submitted this change and it was merged.
Change subject: engine: AddVdsSpmIdCommand throw exception when...
..
engine: AddVdsSpmIdCommand throw exception when...
AddVdsSpmIdCommand throw exception when trying to
Eli Mesika has posted comments on this change.
Change subject: engine: AddVdsSpmIdCommand throw exception when...
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11271
To unsubscri
Michael Kublin has posted comments on this change.
Change subject: engine: Replacing search for vms by query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11426
To unsubscribe, visit http://gerrit.ovirt.org
Michael Kublin has uploaded a new change for review.
Change subject: engine: Replacing search for vms by query
..
engine: Replacing search for vms by query
The following patch is replace a search for vms which are belongs to som
Daniel Erez has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
..
Patch Set 4:
How can we rely on it?
Don't we want to decouple the plugin rpm from the service rpm?
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: engine: Removing validateStorageServerConnection - storage part
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
You could al
Itamar Heim has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
..
Patch Set 4:
if the shellinabox sources are available via another rpm already, question is
why not rely on it (
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: UI-Plugins - fix host name mapping
..
webadmin: UI-Plugins - fix host name mapping
EntityObject:
* Map 'getvds_name' to 'name' property (Name column).
*
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: UI-Plugins - VM IP address mapping
..
webadmin: UI-Plugins - VM IP address mapping
Add mapping to VM IP address,
EntityObject:
Map 'getVmIp' to 'ipaddr
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix UpdateVm permissions check for Quota
..
Patch Set 1: (1 inline comment)
File
backend/manager/modu
Daniel Erez has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
..
Patch Set 3: (7 inline comments)
The shellinabox-plugin scripts should be archived in a tar file for the RPM.
.
Asaf Shakarchi has posted comments on this change.
Change subject: pom.xml: update findbugs mvn plugin version to latest 2.5.2
..
Patch Set 2:
Doron: Forgot to mention that this plugin is not packed in fedora as it's a
review
Yair Zaslavsky has posted comments on this change.
Change subject: engine: AddVdsSpmIdCommand throw exception when...
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11271
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: storage domain validation refactoring
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
1 - 100 of 209 matches
Mail list logo
