Daniel Erez has posted comments on this change.
Change subject: core: block MoveDisks on snapshot preview
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
Line 99:
Line 100: if (vm != null &&
!validate(snapshotsValidator.vmNotInPreview(vm.getId()))) {
Line 101: return false;
Line 102: }
Line 103: else if (vm == null || isVmDown(vm)) {
The redundant 'else' can be removed.
Line 104: moveParametersList.add(moveDiskParameters);
Line 105: }
Line 106: else if (isVmRunning(vm)) {
Line 107: MultiValueMapUtils.addToMap(vm.getId(),
--
To view, visit http://gerrit.ovirt.org/11340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b93d08eaadb230fe2cc985a9ba57efb5dd3abb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
