Omer Frenkel has submitted this change and it was merged. Change subject: core: InternalMigrateVmCommand cleanup ......................................................................
core: InternalMigrateVmCommand cleanup Replaced convertInternalMigrateParamsToMigrateParams method in InternalMigrateVmCommand with a constructor in MigrateVmParameters that gets as an input InternalMigrateVmParameters instance. InternalMigrateVmParameters class was moved to org.ovirt.engine.core.common.action package so that it will be accessible from MigrateVmParameters class (and that package it should be in anyway as all the parameters class resides there) On the way two minor changes were made in order to support later patches: 1. a constructor that also gets the parent command was added to InternalMigrateVmParameters 2. the correlation-id is also copied from the InternalMigrateVmParameters on the newly added constructor in MigrateVmParameters Change-Id: Idfeb4966b6ae0a570904861a5e6b1768b0c6d47f Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InternalMigrateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java 4 files changed, 22 insertions(+), 21 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/11368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfeb4966b6ae0a570904861a5e6b1768b0c6d47f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
