Sharad Mishra has uploaded a new change for review.
Change subject: core: WIP: Add suppoort for SSL in LDAP.
..
core: WIP: Add suppoort for SSL in LDAP.
This patch adds support for Simple authentication over SSL in LDAP.
Change
Greg Padgett has posted comments on this change.
Change subject: webadmin: disk search overridden by default upon tab reveal
..
Patch Set 1: Verified
Tested on FF17 and Chrome 23, both on Linux.
--
To view, visit http://gerrit
Greg Padgett has uploaded a new change for review.
Change subject: webadmin: disk search overridden by default upon tab reveal
..
webadmin: disk search overridden by default upon tab reveal
If a search was done on disks and reve
Alissa Bonas has posted comments on this change.
Change subject: core: Remove unused import,fix log and comment
..
Patch Set 2: (1 inline comment)
File
backend/manager/tools
Ravi Nori has posted comments on this change.
Change subject: engine : User is UNKNOWN in async task completion events
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10896
To unsubscribe, visit http://gerrit
Ravi Nori has uploaded a new change for review.
Change subject: engine : User is UNKNOWN in async task completion events
..
engine : User is UNKNOWN in async task completion events
In async tasks after the user has been logged o
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3221/
Build Number: 3221
Build Status: Fixed
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
Alexander Wels has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10895
To unsubscribe, visit http://gerrit
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: Application continue polling after logout
..
webadmin: Application continue polling after logout
- Fixed queries to BookMarks not stopping when loggi
Alon Bar-Lev has posted comments on this change.
Change subject: services: rhel: support upstart
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10894
To unsubscribe, visit http://
Alon Bar-Lev has submitted this change and it was merged.
Change subject: services: rhel: support upstart
..
services: rhel: support upstart
vdsm developers moved libvirtd to upstart, it is the only service that is
using upstar
Alon Bar-Lev has uploaded a new change for review.
Change subject: services: rhel: support upstart
..
services: rhel: support upstart
vdsm developers moved libvirtd to upstart, it is the only service that is
using upstart.
The
Eyal Edri has posted comments on this change.
Change subject: Removed unused repositories from root pom file.
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Moti Asayag has posted comments on this change.
Change subject: core: add isTraceEnabled to Log class
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10873
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: core: Fix logging level in several classes
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bl
Moti Asayag has posted comments on this change.
Change subject: core: Remove unused import,fix log and comment
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3121/
Build Number: 3121
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,937
-
Chang
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3220/
Build Number: 3220
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,937
-
Changes Since
Daniel Erez has posted comments on this change.
Change subject: core: Remove unused import,fix log and comment
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10880
To u
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't fail when setting limit fails
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
...
Daniel Erez has posted comments on this change.
Change subject: webadmin: remove invalid css pointer type
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10888
To unsubscribe, visit http://g
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't fail when setting limit fails
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10890
To unsubscribe, visit http://gerrit.ovir
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Don't fail when setting limit fails
..
packaging: Don't fail when setting limit fails
Currently we fail the startup of the engine when setting a res
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't check that root runs the service
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10538
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't check that root runs the service
..
Patch Set 2: Verified
Remove the check for root completely.
--
To view, visit http://gerrit.ovirt.org/1053
Moti Asayag has submitted this change and it was merged.
Change subject: core: add isDebugEnabled to Log class
..
core: add isDebugEnabled to Log class
Add isDebugEnabled to debug methods of Log class for performance
Change-Id
Moti Asayag has posted comments on this change.
Change subject: core: add isDebugEnabled to Log class
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10806
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Move installation of systemd to .spec
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10889
T
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move installation of systemd to .spec
..
Patch Set 1: Verified
Verified building and installing new packages.
--
To view, visit http://gerrit.ovirt.
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3120/
Build Number: 3120
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,936
-
Chang
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Move installation of systemd to .spec
..
packaging: Move installation of systemd to .spec
Currently we install the systemd unit files from the Makef
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: remove invalid css pointer type
..
webadmin: remove invalid css pointer type
- Removed declarations of extra pointer: hand declarations from
styles a
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 2: (3 inline comments)
File
frontend/webadmin/modul
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 1:
> Do you think that we can remove this check?
yes.
--
To view, visit http://gerrit.ovirt.org/10
Alon Bar-Lev has posted comments on this change.
Change subject: webadmin: remove using Config.DefaultConfigurationVersion
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Gilad Chaplik has posted comments on this change.
Change subject: engine: remove Config dependency from frontend
..
Patch Set 1: Looks good to me, approved
it was on my q... sorry
--
To view, visit http://gerrit.ovirt.org/1088
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: remove using Config.DefaultConfigurationVersion
..
webadmin: remove using Config.DefaultConfigurationVersion
use AsyncDataProvider.getDefaultConfigura
Juan Hernandez has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 1:
We use the service user (currently hardcoded as root) to check that noone else
starts the serv
Alon Bar-Lev has uploaded a new change for review.
Change subject: engine: remove Config dependency from frontend
..
engine: remove Config dependency from frontend
Fix leftover from I47e6f47
Change-Id: Ie0df1112cf518823a98f020c
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3119/
Build Number: 3119
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,934,
Started by upstream project "ovirt_engine"
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: remove Config dependency from frontend
..
engine: remove Config dependency from frontend
The only use of class org.ovirt.engine.core.common.conf
Gilad Chaplik has posted comments on this change.
Change subject: engine: remove Config dependency from frontend
..
Patch Set 3: Verified; Looks good to me, approved
rebased and verified
--
To view, visit http://gerrit.ovirt.o
Alissa Bonas has uploaded a new change for review.
Change subject: core: Fix logging level in several classes
..
core: Fix logging level in several classes
Log exceptions in error instead of debug
Log frequent actions in debug i
Maor Lipchuk has posted comments on this change.
Change subject: core: lock active snapshot during undo preview process
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/10845
To unsubscribe, visit http://gerri
liron aravot has posted comments on this change.
Change subject: core: lock active snapshot during undo preview process
..
Patch Set 1: I would prefer that you didn't submit this
The added snapshot would stay locked if there ar
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks appear without scroll
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10881
To unsubscribe, visit http://gerrit.ovirt.org
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: bookmarks appear without scroll
..
webadmin: bookmarks appear without scroll
- Fixed scrollbar on bookmarks not working on initial
load.
Change-Id:
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3118/
Build Number: 3118
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,933
-
Chang
Alissa Bonas has uploaded a new change for review.
Change subject: core: Remove unused import,fix log and comment
..
core: Remove unused import,fix log and comment
Remove unused import, fix log exception from debug to error and
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: fixing buttons text misalignment
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10826
To unsubscribe, visit http:
Maor Lipchuk has posted comments on this change.
Change subject: core: NPE during RestoreAllSnapshotsCommand
..
Patch Set 2:
see minor commit message comments
--
To view, visit http://gerrit.ovirt.org/10871
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Disable INFO for malformed cookies
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10877
To u
Maor Lipchuk has posted comments on this change.
Change subject: core: NPE during RestoreAllSnapshotsCommand
..
Patch Set 2: (2 inline comments)
Commit Message
Line 5: Commit
Juan Hernandez has posted comments on this change.
Change subject: packaging: Disable INFO for malformed cookies
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10877
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: core: NPE during RestoreAllSnapshotsCommand
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10871
To unsubscribe, visit http:
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Disable INFO for malformed cookies
..
packaging: Disable INFO for malformed cookies
Tomcat (and thus JBoss Web) complains when it finds certain unex
Maor Lipchuk has posted comments on this change.
Change subject: core: lock active snapshot during undo preview process
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10845
To unsubscribe,
Eli Mesika has submitted this change and it was merged.
Change subject: core: fixing NPE in CommandBase
..
core: fixing NPE in CommandBase
Change-Id: If3daf13b840c38567755a79b963f159d4789d441
Signed-off-by: Eli Mesika
---
M
b
Eli Mesika has posted comments on this change.
Change subject: core: fixing NPE in CommandBase
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10876
To unsubscribe, visit http://ge
Eli Mesika has posted comments on this change.
Change subject: core: fixing NPE in CommandBase
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10876
To unsubscribe, visit http://ge
Moti Asayag has posted comments on this change.
Change subject: core: fixing NPE in comamndbase
..
Patch Set 1: Looks good to me, approved
Please fix typo in commit message
--
To view, visit http://gerrit.ovirt.org/10876
To un
Eli Mesika has uploaded a new change for review.
Change subject: core: fixing NPE in comamndbase
..
core: fixing NPE in comamndbase
Change-Id: If3daf13b840c38567755a79b963f159d4789d441
Signed-off-by: Eli Mesika
---
M
backend/m
Maor Lipchuk has posted comments on this change.
Change subject: core: lock active snapshot during undo preview process
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Alissa Bonas has posted comments on this change.
Change subject: core: add isTraceEnabled to Log class
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/utils/
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal,webadmin: [WIP] Builders infrastructure
..
userportal,webadmin: [WIP] Builders infrastructure
DO NOT MERGE. An implementation of a flexible, easy to
Moti Asayag has posted comments on this change.
Change subject: core: add isDebugEnabled to Log class
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10806
To unsubscribe, visit http://gerri
Daniel Erez has submitted this change and it was merged.
Change subject: core: remove head leftover from AuditLogMessages
..
core: remove head leftover from AuditLogMessages
Change-Id: I0a3da0dcacee4bf033db17472785cab09dd28500
Daniel Erez has posted comments on this change.
Change subject: core: remove head leftover from AuditLogMessages
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10872
To unsubscrib
Moti Asayag has posted comments on this change.
Change subject: core: add isTraceEnabled to Log class
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/utils/s
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3117/
Build Number: 3117
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,932
-
Chang
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Add support for SSLv3
..
packaging: Add support for SSLv3
With the current configuration when we don't use Apache as a proxy we
only support
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add support for SSLv3
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view, visit http:/
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add support for SSLv3
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10858
To unsubscribe, visit http://gerrit.
Daniel Erez has posted comments on this change.
Change subject: core: remove head leftover from AuditLogMessages
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10872
To unsubscrib
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/3667/
Build Number: 3667
Build Status: Fixed
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Alissa Bonas has uploaded a new change for review.
Change subject: core: add isTraceEnabled to Log class
..
core: add isTraceEnabled to Log class
Add isTraceEnabled to trace methods of Log class for performance
Change-Id: I1e55
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated dropdb command with correct environment
..
packaging: Updated dropdb command with correct environment
Change-Id: I0889e7e2c94256a98a
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated dropdb command with correct environment
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated dropdb command with correct environment
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10856
To unsubsc
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2983/
Build Number: 2983
Build Status: Fixed
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Liron Aravot has uploaded a new change for review.
Change subject: core: remove head leftover from AuditLogMessages
..
core: remove head leftover from AuditLogMessages
Change-Id: I0a3da0dcacee4bf033db17472785cab09dd28500
Signed-
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Rename APACHE_KEYSTORE to WEB_KEYSTORE
..
Patch Set 1:
I do.
--
To view, visit http://gerrit.ovirt.org/10862
To unsubscribe, visit http://gerrit.ovirt
Liron Aravot has uploaded a new change for review.
Change subject: core: NPE during RestoreAllSnapshotsCommand
..
core: NPE during RestoreAllSnapshotsCommand
When running the command for diskless snapshots an NPE might occur as
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix apache.p12 ownership
..
Patch Set 3: Verified
Verified building, installing and running a new set of packages.
--
To view, visit http://gerrit.o
Moti Asayag has posted comments on this change.
Change subject: core: Move status check methods from VM to VMStatus
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3116/
Build Number: 3116
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,928,
Started by upstream project "ovirt_engine"
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 6: (3 inline comments)
Basically the changes address the main issue.
See few comments inside.
.
Juan Hernandez has posted comments on this change.
Change subject: packaging: Rename APACHE_KEYSTORE to WEB_KEYSTORE
..
Patch Set 1:
I don't see the inconsistency in having copies of files with different formats
and permission
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3215/
Build Number: 3215
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,928
-
Changes Since La
Ravi Nori has posted comments on this change.
Change subject: core : User Name modified on user login
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10869
To unsubscribe, visit http://gerrit.ovirt.org/settin
Ravi Nori has uploaded a new change for review.
Change subject: core : User Name modified on user login
..
core : User Name modified on user login
When a user logs into the User Portal or Admin Portal the
user name is modified a
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2982/
Build Number: 2982
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,932
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/3666/
Build Number: 3666
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,932
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3115/
Build Number: 3115
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,927
-
Changes Sin
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Rename APACHE_KEYSTORE to WEB_KEYSTORE
..
Patch Set 1:
Had these two components used p12 as they should, you had a permission issue
and conflict. It i
Juan Hernandez has posted comments on this change.
Change subject: packaging: Rename APACHE_KEYSTORE to WEB_KEYSTORE
..
Patch Set 1:
Switching is already easy, a matter of changing the configuration in
/etc/sysconfig/ovirt-eng
Daniel Erez has submitted this change and it was merged.
Change subject: core: deadlock and unneeded db/vdsm calls when creating
diskless snapshots.
..
core: deadlock and unneeded db/vdsm calls when creating diskless snapshot
Daniel Erez has posted comments on this change.
Change subject: core: deadlock and unneeded db/vdsm calls when creating
diskless snapshots.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.
Daniel Erez has posted comments on this change.
Change subject: core: deadlock and unneeded db/vdsm calls when creating
diskless snapshots.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Liron Aravot has posted comments on this change.
Change subject: core: deadlock and unneeded db/vdsm calls when creating
diskless snapshots.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10857
To unsubscr
1 - 100 of 276 matches
Mail list logo
