Kanagaraj M has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java
Line 93:
Line 94: @Provides
Line 95: @Singleton
Line 96: public DetailModelProvider<ClusterListModel, ClusterGeneralModel>
getClusterGeneralProvider(ClientGinjector ginjector,
Line 97: final Provider<ClusterPopupPresenterWidget>
policyPopupProvider,
You can remove the provider itself as the Edit Command which opens the popup is
executed in the ClusterListModel context.
Line 98: final Provider<MultipleHostsPopupPresenterWidget>
multipleHostsProvider,
Line 99: final Provider<DetachGlusterHostsPopupPresenterWidget>
detachHostsProvider) {
Line 100: return new DetailTabModelProvider<ClusterListModel,
ClusterGeneralModel>(ginjector,
Line 101: ClusterListModel.class,
Line 103: @Override
Line 104: public AbstractModelBoundPopupPresenterWidget<? extends
Model, ?> getModelPopup(ClusterGeneralModel source,
Line 105: UICommand lastExecutedCommand, Model windowModel)
{
Line 106: if (lastExecutedCommand ==
getModel().getEditPolicyCommand()) {
Line 107: return policyPopupProvider.get();
same as above.
Line 108: } else if (lastExecutedCommand ==
getModel().getImportNewGlusterHostsCommand()) {
Line 109: return multipleHostsProvider.get();
Line 110: } else if (lastExecutedCommand ==
getModel().getDetachNewGlusterHostsCommand()) {
Line 111: return detachHostsProvider.get();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
Line 425: if (ApplicationModeHelper.getUiMode() ==
ApplicationMode.GlusterOnly)
Line 426: {
Line 427: optimizationTab.setVisible(false);
Line 428: resiliencePolicyTab.setVisible(false);
Line 429: clusterPolicyTab.setVisible(true);
please make the policy tab hidden in Gluster mode.
Line 430:
dataCenterPanel.addStyleName(style.generalTabTopDecoratorEmpty());
Line 431: }
Line 432: }
Line 433:
--
To view, visit http://gerrit.ovirt.org/10573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I195d9ec1c7901a31e6e656221964d82bc90c9695
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
