Alissa Bonas has posted comments on this change. Change subject: core: Remove unused import,fix log and comment ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java Line 2 Line 3 Line 4 Line 5 Line 6 I was thinking about exact same thing! when I saw this :) I have 2 assumptions about it -just purely in theory 1. either checkstyle doesn't run on this specific maven module 2. or checkstyle is configured to detect NEW violations (for example you can do something like this with findbugs to alert only on new things) -- To view, visit http://gerrit.ovirt.org/10880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3929a032e830b26d6defa2ee842da4bb6cfc1b2c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
