Vered Volansky has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
..
Patch Set 28: (5 inline comments)
Sorry, some minor comments
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Added VM NIC validator
..
engine: Added VM NIC validator
Validator will be used to check if the NIC is valid for unlinking or for
setting no net
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Added variable replacements to ValidationResult
..
engine: Added variable replacements to ValidationResult
Added a possibility to include variab
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: HotPlugEnabled shouldn't be reloadable.
..
core: HotPlugEnabled shouldn't be reloadable.
We shouldn't allow modifying this property.
Change-Id: I
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add NetworkLinking to AddVmInterfaceCommand
..
core: add NetworkLinking to AddVmInterfaceCommand
- canDoAction-
If "UnlinkingSupported" is false f
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add NetworkLinking support to UpdateVmCommand
..
core: Add NetworkLinking support to UpdateVmCommand
- Avoid NPE in case there is a vnic with null
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: adding AbstractVmInterfaceCommand
..
core: adding AbstractVmInterfaceCommand
This command will contain common logic of VmIntrefaceCommands.
For n
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Rename HotPlugUnplgNicVDSParameters
..
engine: Rename HotPlugUnplgNicVDSParameters
Renamed the parameters to VmNicDeviceVDSParameters so that th
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: adding VdsmError for failure on VmUpdateDevice on Vnic.
..
core: adding VdsmError for failure on VmUpdateDevice on Vnic.
If the vdsm fails to upda
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add NetworkLinking to AddVmTemplateInterfaceCommand
..
core: add NetworkLinking to AddVmTemplateInterfaceCommand
- canDoAction-
If "UnlinkingSuppo
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: allow editing VmInterface while the VM is running.
..
core: allow editing VmInterface while the VM is running.
NetworkLinking feature allows editi
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand
..
core: add NetworkLinking to UpdateVmInterfaceCommand
- messages- add bll errors related to "link
Mike Kolesnik has submitted this change and it was merged.
Change subject: core,ui: add/update linking bll-error messages.
..
core,ui: add/update linking bll-error messages.
UNLINKING_IS_NOT_SUPPORTED
NULL_NETWORK_IS_NOT_SUPPOR
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: adding "NetworkLinkingSupported" to vdc_options.
..
core: adding "NetworkLinkingSupported" to vdc_options.
Changing LinkState is supported only fo
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add hashCode, equals & toString to ValidationResult
..
core: Add hashCode, equals & toString to ValidationResult
Added these methods to allow test
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: 'No Network' on a Vnic should be marked as null and not
empty String.
..
core: 'No Network' on a Vnic should be marked as null and not empty Strin
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add NetworkLinking to UpdateVmTemplateInterfaceCommand
..
core: add NetworkLinking to UpdateVmTemplateInterfaceCommand
- canDoAction-
If "Unlinkin
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking
..
engine: DetachNetworkToVdsGroup for NetworkLinking
This patch makes sure NPEs are avoided due to t
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: HotPlugNicVDSCommand should send "linkActive" to the vdsm.
..
core: HotPlugNicVDSCommand should send "linkActive" to the vdsm.
- If "linked" prope
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add NetworkLinking support to RunVm command.
..
core: add NetworkLinking support to RunVm command.
- If "linked" property on VmNetworkInterface is
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add NetworkLinking to AddVmTemplateCommand
..
core: add NetworkLinking to AddVmTemplateCommand
Linked property on VmNetworkInterface should also b
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: add NetworkLinking to ChangeVMClusterCommand
..
core: add NetworkLinking to ChangeVMClusterCommand
When changing the VM Cluster-
if the new Cluste
Mike Kolesnik has submitted this change and it was merged.
Change subject: core : add NetwookLinking support to VmInterfaceManager
..
core : add NetwookLinking support to VmInterfaceManager
- Support the case when vm has vnic/s
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: create UpdateVmInterfaceVDSCommand
..
core: create UpdateVmInterfaceVDSCommand
The command will be called from UpdateVmInterfaceCommand.
It will b
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add NetworkLinking support to OvfVm.
..
core: Add NetworkLinking support to OvfVm.
- Support null networkName of a vnic.
- New "Linked" property o
Mike Kolesnik has submitted this change and it was merged.
Change subject: webadmin: copy "linked" property on VmNetworkInterface cloner.
..
webadmin: copy "linked" property on VmNetworkInterface cloner.
"linked" boolean is a n
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add NetworkLinking support to OvfTemplate.
..
core: Add NetworkLinking support to OvfTemplate.
- Support null networkName of a vnic.
- New "Linked
Mike Kolesnik has posted comments on this change.
Change subject: core: adding "NetworkLinkingSupported" to vdc_options.
..
Patch Set 10: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit htt
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Add NetworkLinking support to ImportVmTemplateCommand.
..
engine: Add NetworkLinking support to ImportVmTemplateCommand.
- Add linking to the co
Mike Kolesnik has posted comments on this change.
Change subject: core: HotPlugEnabled shouldn't be reloadable.
..
Patch Set 15: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://gerri
Mike Kolesnik has posted comments on this change.
Change subject: core: Add hashCode, equals & toString to ValidationResult
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit h
Mike Kolesnik has posted comments on this change.
Change subject: core,ui: add/update linking bll-error messages.
..
Patch Set 25: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://ger
Mike Kolesnik has posted comments on this change.
Change subject: engine: Added VM NIC validator
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://gerrit.ovirt.org/1026
Mike Kolesnik has posted comments on this change.
Change subject: engine: Added variable replacements to ValidationResult
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit htt
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmInterfaceCommand
..
Patch Set 9: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://ge
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking support to RunVm command.
..
Patch Set 22: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://
Mike Kolesnik has posted comments on this change.
Change subject: core: 'No Network' on a Vnic should be marked as null and not
empty String.
..
Patch Set 20: Verified; Looks good to me, approved
Rebased, no changes since ack
Mike Kolesnik has posted comments on this change.
Change subject: core: HotPlugNicVDSCommand should send "linkActive" to the vdsm.
..
Patch Set 22: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view,
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to ChangeVMClusterCommand
..
Patch Set 20: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://
Mike Kolesnik has posted comments on this change.
Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking
..
Patch Set 10: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to UpdateVmTemplateInterfaceCommand
..
Patch Set 7: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visi
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmTemplateInterfaceCommand
..
Patch Set 24: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmTemplateCommand
..
Patch Set 20: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://ge
Mike Kolesnik has posted comments on this change.
Change subject: core: adding AbstractVmInterfaceCommand
..
Patch Set 17: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://gerrit.ovir
Mike Kolesnik has posted comments on this change.
Change subject: core: allow editing VmInterface while the VM is running.
..
Patch Set 19: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit h
Mike Kolesnik has posted comments on this change.
Change subject: engine: Rename HotPlugUnplgNicVDSParameters
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://gerrit.o
Mike Kolesnik has posted comments on this change.
Change subject: core: adding VdsmError for failure on VmUpdateDevice on Vnic.
..
Patch Set 17: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, vi
Mike Kolesnik has posted comments on this change.
Change subject: core: create UpdateVmInterfaceVDSCommand
..
Patch Set 18: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://gerrit.ovi
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand
..
Patch Set 21: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http:
Mike Kolesnik has posted comments on this change.
Change subject: core : add NetwookLinking support to VmInterfaceManager
..
Patch Set 15: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit ht
Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to UpdateVmCommand
..
Patch Set 12: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http:/
Mike Kolesnik has posted comments on this change.
Change subject: engine: Add NetworkLinking support to ImportVmTemplateCommand.
..
Patch Set 12: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, v
Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfVm.
..
Patch Set 12: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://gerrit.o
Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfTemplate.
..
Patch Set 12: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http://ge
Mike Kolesnik has posted comments on this change.
Change subject: webadmin: copy "linked" property on VmNetworkInterface cloner.
..
Patch Set 12: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, v
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: adding "linked" property to VmNetworkInterface
..
core: adding "linked" property to VmNetworkInterface
adding linked property to-
- VmNetworkInter
Mike Kolesnik has posted comments on this change.
Change subject: core: adding "linked" property to VmNetworkInterface
..
Patch Set 19: Verified; Looks good to me, approved
Rebased, no changes since ack
--
To view, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 2:
Michael Pasternak - are you asking or saying it will serve also API?
Regarding API queries, we sh
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 2:
Please add unit-test for the query as well.
--
To view, visit http://gerrit.ovirt.org/10321
To u
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Filter Non-Operational DCs when adding new domain
..
Patch Set 1: (1 inline comment)
File
fronte
Daniel Erez has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 6: (1 inline comment)
File
frontend/webadmin/module
Daniel Erez has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 6: (1 inline comment)
File
frontend/webadmin/module
Moran Goldboim has posted comments on this change.
Change subject: packaging: add configurable prefix to rpm list
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10307
T
Daniel Erez has posted comments on this change.
Change subject: core: support multiple concurrent disks migration
..
Patch Set 3: (1 inline comment)
File
frontend/webadmin/m
Daniel Erez has submitted this change and it was merged.
Change subject: core: remove obsolete StorageDomainTemplateQuery
..
core: remove obsolete StorageDomainTemplateQuery
Cleanup - removing obsolete query: StorageDomainTempl
Daniel Erez has posted comments on this change.
Change subject: core: remove obsolete StorageDomainTemplateQuery
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10320
To u
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/10115
To unsubscribe, visit http://gerrit.ovirt.
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding host bios fields to vdsStatic table
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10114
To unsubscribe, visit http://gerrit.ovirt.or
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/set
Gilad Chaplik has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 6: (2 inline comments)
minor comments
File
front
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: remove Config dependency from frontend
..
Patch Set 1:
But if you don't complete this patch and fetch from server, it will be harder
to inject the cons
Gilad Chaplik has posted comments on this change.
Change subject: frontend: remove Config dependency from frontend
..
Patch Set 1:
I agree and disagree; I agree that this is only the first half of the solution,
still need to f
Daniel Erez has submitted this change and it was merged.
Change subject: core: log message on evaluateCorrelationId failure
..
core: log message on evaluateCorrelationId failure
Added a log message warning for evaluateCorrelati
Daniel Erez has posted comments on this change.
Change subject: core: log message on evaluateCorrelationId failure
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10318
To
Daniel Erez has posted comments on this change.
Change subject: core: log message on evaluateCorrelationId failure
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10318
To unsubscribe, visit http://gerrit.ovi
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: local storage - missing correlation ID
..
webadmin: local storage - missing correlation ID
Configure local storage:
added correlation ID for Add
Daniel Erez has posted comments on this change.
Change subject: webadmin: local storage - missing correlation ID
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10317
To u
Daniel Erez has posted comments on this change.
Change subject: webadmin: local storage - missing correlation ID
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10317
To unsubscribe, visit http://gerrit.ovirt
Alissa Bonas has posted comments on this change.
Change subject: core: cleanup in VdsDeploy
..
Patch Set 3: Verified
Yair - please do merge :)
--
To view, visit http://gerrit.ovirt.org/10290
To unsubscribe, visit http://gerrit
Daniel Erez has posted comments on this change.
Change subject: webadmin: VmInterfaceListModelTable style modifications
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10324
To unsubscribe, visit http://gerri
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: VmInterfaceListModelTable style modifications
..
webadmin: VmInterfaceListModelTable style modifications
Modified inner panels' margins in VmInt
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: VmSnapshotListModelTable style modifications
..
webadmin: VmSnapshotListModelTable style modifications
Modified inner panels' margins in VmSnaps
Daniel Erez has posted comments on this change.
Change subject: webadmin: VmSnapshotListModelTable style modifications
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10323
To unsu
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: remove Config dependency from frontend
..
Patch Set 1:
Oh... I thought we fetch it from server.
There is no advantage of this over the previous state,
Gilad Chaplik has posted comments on this change.
Change subject: frontend: remove Config dependency from frontend
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10330
To unsubscribe, visit http://gerrit.ovi
Gilad Chaplik has uploaded a new change for review.
Change subject: frontend: remove Config dependency from frontend
..
frontend: remove Config dependency from frontend
The only use of class org.ovirt.engine.core.common.config.C
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Network tab, minor sub tab fixes
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10329
To unsubscribe, visit http:
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Network tab, minor sub tab fixes
..
webadmin: Network tab, minor sub tab fixes
network->host.
- default should be attached.
- s/Nic/Network Device (on
Yair Zaslavsky has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 2:
Alissa,
Please follow Vered's comments, and I'll merge.
--
To view, visit http://gerrit.ovirt.org/10290
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: sync miniyum implementation with recent otopi
..
Patch Set 1:
Alex, I really want to push this series *BEFORE* the rebase.
--
To view, visit http://ge
Alon Bar-Lev has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 2:
Just a question... how so many people reache to this patch?
--
To view, visit http://gerrit.ovirt.org/10290
To uns
Liron Aravot has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10290
To unsubscribe, vis
ofri masad has uploaded a new change for review.
Change subject: userportal: Change VerticalPanel to FlowPanel
..
userportal: Change VerticalPanel to FlowPanel
Replace VerticalPanel with FlowPanel in few places in the
SideTabExt
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: bridge: remove unused true always enabled
..
vdsm: bridge: remove unused true always enabled
Change-Id: I0784d0fdcc89f4774fdc883512d7ee2dafe0b49c
S
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: bridge: remove unused true always enabled
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10327
To unsubscrib
Doron Fediuck has posted comments on this change.
Change subject: webamin: hide cpuPin section according to config values
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9664
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: core: adding "linked" property to VmNetworkInterface
..
Patch Set 18: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9440
To unsubscribe, vis
Alissa Bonas has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Alissa Bonas has posted comments on this change.
Change subject: core: remove unused permissions classes
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10284
To unsubscribe, visit http://gerrit.ovirt.org/set
Maor Lipchuk has posted comments on this change.
Change subject: core: ClassCastException when attempting to get storage domain
of disk
..
Patch Set 1: (1 inline comment)
Fi
1 - 100 of 211 matches
Mail list logo
