Maor Lipchuk has posted comments on this change.
Change subject: core: ClassCastException when attempting to get storage domain
of disk
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 259: }
Line 260: }
Line 261:
Line 262: @Override
Line 263: public NGuid getStorageDomainId() {
This method should only be called by disk images.
You can rename the method to something like 'getImageStorageDomainId' and by
that solve that issue.
Line 264: Guid storageDomainId = getParameters().getStorageDomainId();
Line 265: if (Guid.Empty.equals(storageDomainId) &&
Line 266: getVm() != null &&
Line 267: getVm().getDiskMap() != null &&
--
To view, visit http://gerrit.ovirt.org/10289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
