Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to UpdateVmCommand
..
Patch Set 10: (1 inline comment)
File
backend/manage
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand
..
Patch Set 19: (2 inline comments)
File
backend/mana
Mike Kolesnik has posted comments on this change.
Change subject: core: adding AbstractVmInterfaceCommand
..
Patch Set 15: (4 inline comments)
File
backend/manager/modules/b
Michael Pasternak has posted comments on this change.
Change subject: restapi: Add fields for CPU Thread Handling (4/4)
..
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
also afaiu ht_treads are up
Moti Asayag has posted comments on this change.
Change subject: engine: Add index to vm_guest_agent_interfaces
..
Patch Set 2:
this patch series uses 0110 as well
--
To view, visit http://gerrit.ovirt.org/10287
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: core: ClassCastException when attempting to get storage domain
of disk
..
Patch Set 1: (1 inline comment)
Fi
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to ChangeVMClusterCommand
..
Patch Set 18: (2 inline comments)
File
backend/manage
Mike Kolesnik has posted comments on this change.
Change subject: core: HotPlugNicVDSCommand should send "linkState" to the vdsm.
..
Patch Set 20: (2 inline comments)
Commit
Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking support to RunVm command.
..
Patch Set 20: (5 inline comments)
File
backend/manage
Doron Fediuck has posted comments on this change.
Change subject: pom.xml: update findbugs mvn plugin version to latest 2.5.2
..
Patch Set 1:
I assume this was verified to work in Fedora?
--
To view, visit http://gerrit.ovirt.
Moti Asayag has posted comments on this change.
Change subject: engine: Save VM Guest Agent network devices
..
Patch Set 5: (3 inline comments)
File
backend/manager/modules/
Moti Asayag has posted comments on this change.
Change subject: engine: Process netIfaces element reported by VDSM
..
Patch Set 4: (1 inline comment)
File
backend/manager/mo
Mike Kolesnik has posted comments on this change.
Change subject: engine: Save VM Guest Agent network devices
..
Patch Set 5: (3 inline comments)
File
backend/manager/module
Mike Kolesnik has posted comments on this change.
Change subject: engine: Process netIfaces element reported by VDSM
..
Patch Set 4: (1 inline comment)
File
backend/manager/
Mike Kolesnik has posted comments on this change.
Change subject: engine: Change property name to follow naming convention
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10230
To unsubscrib
Mike Kolesnik has posted comments on this change.
Change subject: core: Implement VmGuestAgentInterface.toString()
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10228
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Update VmGuestAgentInterfaces
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10123
To unsubscribe, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP]core : GWT changes for Multi-Tier fencing
..
Patch Set 3:
I agree with Gilad.
--
To view, visit http://gerrit.ovirt.org/10261
To unsubscribe, visit http:/
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP]core : BLL changes for Multi-Tier fencing
..
Patch Set 3: (2 inline comments)
File
backend/manager/mo
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP]core : BLL changes for Multi-Tier fencing
..
Patch Set 3: (3 inline comments)
File
backend/manager/mo
Eli Mesika has submitted this change and it was merged.
Change subject: core: code cleanup - remove commmented code.
..
core: code cleanup - remove commmented code.
Change-Id: I650fd99b86eaa24f3af356218592a3374358bb06
Signed-of
Eli Mesika has posted comments on this change.
Change subject: core: code cleanup - remove commmented code.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5360
To unsubscribe, vis
Eli Mesika has posted comments on this change.
Change subject: engine: Add index to vm_guest_agent_interfaces
..
Patch Set 2:
Currently , the script prefix should be 03_02_0110
--
To view, visit http://gerrit.ovirt.org/10287
T
Eli Mesika has posted comments on this change.
Change subject: core : DB FK validation
..
Patch Set 5: (4 inline comments)
File backend/manager/dbscripts/common_sp.sql
Line 5
Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 13: (1 inline comment)
File
backend/manager/modules/vds
Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 13: No score
Cancelling -1 , per my latest comment.
--
To view, visit http://gerrit.ovirt.org/9337
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 13: (2 inline comments)
1. Regarding hashCode and equals - Yaniv is right, for some reason I did not
see the
Allon Mureinik has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 13: (3 inline comments)
some minor issues.
Also, please address Yair and Omer's comments
..
Allon Mureinik has posted comments on this change.
Change subject: core: ReconstructMasterDomain -connect/disconnect hosts
simultaneously
..
Patch Set 3:
@Liron - Will this patch still be relevant after mkublin's event_queue i
Allon Mureinik has posted comments on this change.
Change subject: engine: if connect storage pool fails on version mismatch, do
reconstruct master
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, vi
Daniel Erez has posted comments on this change.
Change subject: core: support multiple concurrent disks migration
..
Patch Set 2: (11 inline comments)
File
backend/manager/m
Allon Mureinik has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 5: Looks good to me, but someone else must approve
(4 inline comments)
minor inline comments
Allon Mureinik has posted comments on this change.
Change subject: [WIP] engine: User queries improvements
..
Patch Set 9: Looks good to me, but someone else must approve
(5 inline comments)
some minor inline issues, and a maj
Allon Mureinik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfVm.
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9802
To un
Allon Mureinik has posted comments on this change.
Change subject: perform connectStorageServer to hosts after during
reconstruct/recovery(#880180)
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, vi
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Filter Non-Operational DCs when adding new domain
..
Patch Set 1: Looks good to me, but someone else must approve
functionally, seems great, but pleas
Allon Mureinik has posted comments on this change.
Change subject: core : DB FK validation
..
Patch Set 5: Looks good to me, but someone else must approve
(4 inline comments)
generally looks OK, but I have a few implementation
Allon Mureinik has posted comments on this change.
Change subject: webadmin: correlate models to move multiple disks API
..
Patch Set 2:
If the previous patch is merged without this one, will it break the UI?
(to me, it looks l
Allon Mureinik has posted comments on this change.
Change subject: core: support multiple concurrent disks migration
..
Patch Set 2: I would prefer that you didn't submit this
(15 inline comments)
.
Alon Bar-Lev has posted comments on this change.
Change subject: core: cleanup and renaming in VdsDeploy
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup and renaming in VdsDeploy
..
Patch Set 1: Looks good to me, but someone else must approve
Looks good to me.
Alon, as the subject matter expert - p
Moti Asayag has posted comments on this change.
Change subject: restapi: Adding Network Linking
..
Patch Set 5: (3 inline comments)
File
backend/manager/modules/restapi/inte
Moti Asayag has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfTemplate.
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9803
To unsubscribe, visit h
Moti Asayag has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfVm.
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9802
To unsubscribe, visit http://
44 matches
Mail list logo
