Yair Zaslavsky has posted comments on this change.
Change subject: [WIP]core : BLL changes for Multi-Tier fencing
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
Line 23: VDS tempVar = new VDS();
Line 24: tempVar.setId((Guid) ((id != null) ? id : Guid.Empty));
Line 25: tempVar.setStoragePoolId(getParameters().getStoragePoolId());
Line 26: if (getParameters().getOrder() == FenceAgentOrder.Primary) {
Line 27: tempVar.setManagmentIp(getParameters().getManagementIp());
indentation issue - please fix.
Line 28: tempVar.setPmOptionsMap(getParameters().getFencingOptions());
Line 29: tempVar.setpm_type(getParameters().getPmType());
Line 30: tempVar.setpm_user(getParameters().getUser());
Line 31: tempVar.setpm_password(getParameters().getPassword());
Line 29: tempVar.setpm_type(getParameters().getPmType());
Line 30: tempVar.setpm_user(getParameters().getUser());
Line 31: tempVar.setpm_password(getParameters().getPassword());
Line 32: }
Line 33: else if (getParameters().getOrder() ==
FenceAgentOrder.Secondary) {
what happens if we want to work with two agents in parallel? we will issue this
query twice?
Line 34:
tempVar.setPmSecondaryIp(getParameters().getManagementIp());
Line 35:
tempVar.setPmSecondaryOptionsMap(getParameters().getFencingOptions());
Line 36: tempVar.setPmSecondaryType(getParameters().getPmType());
Line 37: tempVar.setPmSecondaryUser(getParameters().getUser());
--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82f243593f2b361ca75d97e06f9aede246d4a1b1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
