Oved Ourfali has posted comments on this change.
Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in
Spanish (#871379)
..
Patch Set 1: Verified
Verified on all languages
--
To view, visit http://gerrit.ov
Oved Ourfali has uploaded a new change for review.
Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in
Spanish (#871379)
..
webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379)
https:/
Michael Pasternak has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
please documen
Itamar Heim has posted comments on this change.
Change subject: core: RFE: allow to define deletion protection per vm
..
Patch Set 1:
no need for secret UI app.
backend should perform the validation to cover REST API as well
-
Yair Zaslavsky has uploaded a new change for review.
Change subject: packaging: Fixing engine-config install properties for fc18
..
packaging: Fixing engine-config install properties for fc18
The following patch is required afte
Roy Golan has posted comments on this change.
Change subject: core: RFE: allow to define deletion protection per vm
..
Patch Set 1: Fails
(3 inline comments)
File backend/ma
Omer Frenkel has posted comments on this change.
Change subject: core: RFE: allow to define deletion protection per vm
..
Patch Set 1:
Roy, yes, but someone is secretly writing a mobile client without this check..
i still thin
Haim Ateya has posted comments on this change.
Change subject: packaging: Add yum installtion indication for upgrade
..
Patch Set 2: (1 inline comment)
File packaging/fedora/
Daniel Erez has posted comments on this change.
Change subject: restapi: Extend block domain - override_luns
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/
Roy Golan has posted comments on this change.
Change subject: core: RFE: allow to define deletion protection per vm
..
Patch Set 1:
Omer the next dependant patch is a UI patch with all the protection code
--
To view, visit htt
ofri masad has posted comments on this change.
Change subject: core: Fix storage quota release on stopStatelessVm
..
Patch Set 1: (2 inline comments)
File
backend/manager/mo
Michael Pasternak has posted comments on this change.
Change subject: restapi: Extend block domain - override_luns
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Oved Ourfali has posted comments on this change.
Change subject: typo fix: Action Faild
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9502
To unsubscribe, visit http://gerrit.ovirt.org/set
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config cleanup 2.2 LocalStorageEnabled
..
Patch Set 1:
1. Engine side looks good to me.
2. Adding Michael as reviewer for API part- although look
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config cleanup 2.2 SupportCustomProperties
..
Patch Set 1: Looks good to me, but someone else must approve
Giving +1 on engine side.
UI side looks
Shahar Havivi has posted comments on this change.
Change subject: typo fix: Action Faild
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Shahar Havivi has uploaded a new change for review.
Change subject: typo fix: Action Faild
..
typo fix: Action Faild
Change-Id: Ibc3e1bde594301367cc4e67990e96ac249b46d7a
Signed-off-by: Shahar Havivi
---
M python/WebHandler.py
1
Yair Zaslavsky has posted comments on this change.
Change subject: core: DB upgrade from 3.0 to 3.1 fails(#880350)
..
Patch Set 1: Looks good to me, approved
+2 from my side.
Allon?
--
To view, visit http://gerrit.ovirt.org/95
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config cleanup all 2.2 keys from db
..
Patch Set 1: (1 inline comment)
File backend/manager/d
Ravi Nori has posted comments on this change.
Change subject: tools: engine-config cleanup 2.2 UseRtl8139_pv
..
Patch Set 1:
Hi Itamar, can you please elaborate which enum you would like cleaned up.
--
To view, visit http://ge
Itamar Heim has posted comments on this change.
Change subject: tools: engine-config cleanup 2.2 SupportCustomProperties
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Itamar Heim has posted comments on this change.
Change subject: tools: engine-config cleanup 2.2 SupportGetDevicesVisibility
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Itamar Heim has posted comments on this change.
Change subject: tools: engine-config cleanup 2.2 UseRtl8139_pv
..
Patch Set 1: Looks good to me, but someone else must approve
what about cleaning the 8139_pv enum status?
--
To
Eli Mesika has uploaded a new change for review.
Change subject: core: DB upgrade from 3.0 to 3.1 fails(#880350)
..
core: DB upgrade from 3.0 to 3.1 fails(#880350)
upgrade from 3.0.x to 3.1 failed in 2 points ;
1) 03_01_0950
R
Sharad Mishra has posted comments on this change.
Change subject: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg
..
Patch Set 1: (1 inline comment)
File
bac
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup all 2.2 keys from db
..
tools: engine-config cleanup all 2.2 keys from db
Remove deprecated config values for version 2.2 from engine-c
Yaniv Kaul has posted comments on this change.
Change subject: packaging: Add yum installtion indication for upgrade
..
Patch Set 2: (1 inline comment)
File packaging/fedora/
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup 2.2 UseRtl8139_pv
..
tools: engine-config cleanup 2.2 UseRtl8139_pv
Remove deprecated config values for version 2.2 from engine-config
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup 2.2 SupportStorageFormat
..
tools: engine-config cleanup 2.2 SupportStorageFormat
Remove deprecated config values for version 2.2 from
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup 2.2 SupportGetDevicesVisibility
..
tools: engine-config cleanup 2.2 SupportGetDevicesVisibility
Remove deprecated config values for ver
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup 2.2 SupportCustomProperties
..
tools: engine-config cleanup 2.2 SupportCustomProperties
Remove deprecated config values for version 2.2
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup 2.2 LocalStorageEnabled
..
tools: engine-config cleanup 2.2 LocalStorageEnabled
Remove deprecated config values for version 2.2 from en
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup 2.2 LimitNumberOfNetworkInterfaces
..
tools: engine-config cleanup 2.2 LimitNumberOfNetworkInterfaces
Remove deprecated config values f
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config cleanup 2.2 IsNeedSupportForOldVgAPI
..
tools: engine-config cleanup 2.2 IsNeedSupportForOldVgAPI
Remove deprecated config values for version 2
Sharad Mishra has posted comments on this change.
Change subject: engine: Perfromance improvements at IrsBrokerCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/94
Sharad Mishra has posted comments on this change.
Change subject: core: remove redundant constructors from VmStatistics
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9
Sharad Mishra has posted comments on this change.
Change subject: core,ui: add linking bll-error messages.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9450
To unsubs
Moran Goldboim has uploaded a new change for review.
Change subject: packaging: Add yum installtion indication for upgrade
..
packaging: Add yum installtion indication for upgrade
An indication to the user that rpm installation
Alon Bar-Lev has posted comments on this change.
Change subject: core: remove unused private method from AddVdsCommand
..
Patch Set 3: Looks good to me, but someone else must approve
I guess rebase.
--
To view, visit http://ge
Liron Aravot has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: cleanup approve command
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9452
To
Liron Aravot has abandoned this change.
Change subject: core: ReconstructMasterDomainCommand-added methods for commands
execution
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/7135
To unsubscribe, visit h
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: bootstrap: make approve command respect installation
failure
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view,
Maor Lipchuk has posted comments on this change.
Change subject: core: validate max lun disk attachment
..
Patch Set 3: (5 inline comments)
minor comments, logic looks good, consider to add a test for the PCI and IDE
.
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2890/
Build Number: 2890
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,509
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2889/
Build Number: 2889
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,508
-
Changes Since
Roy Golan has posted comments on this change.
Change subject: core: better general VDSM exception handling
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9479
To unsubscribe, visit http://gerrit.ovirt.org/se
Michael Kublin has posted comments on this change.
Change subject: core: better general VDSM exception handling
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9479
To unsubscribe, visit htt
Roy Golan has uploaded a new change for review.
Change subject: core: better general VDSM exception handling
..
core: better general VDSM exception handling
refactor error translation to separate network exceptions and protocol
Ori Liel has uploaded a new change for review.
Change subject: restapi: #839205 Display Host Hooks
..
restapi: #839205 Display Host Hooks
https://bugzilla.redhat.com/839205
Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09568ca7
S
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Perfromance improvements at IrsBrokerCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9469
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Query getdisksvmguid caused postmaster processes to
consume constantly 100%cpu.
..
Patch Set 1: Looks good to me, but someone else must approve
(2 inli
Doron Fediuck has posted comments on this change.
Change subject: core: Fix storage quota release on stopStatelessVm
..
Patch Set 1: (2 inline comments)
File
backend/manager
ofri masad has uploaded a new change for review.
Change subject: core: Fix storage quota release on stopStatelessVm
..
core: Fix storage quota release on stopStatelessVm
StopVmBase was defined QuotaStorageDependent and the
getQu
Michael Kublin has posted comments on this change.
Change subject: engine: Perfromance improvements at IrsBrokerCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9469
To unsubscribe, visit http://gerrit
Michael Kublin has posted comments on this change.
Change subject: engine: Query getdisksvmguid caused postmaster processes to
consume constantly 100%cpu.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9468
Michael Kublin has uploaded a new change for review.
Change subject: engine: Query getdisksvmguid caused postmaster processes to
consume constantly 100%cpu.
..
engine: Query getdisksvmguid caused postmaster processes to consume
Michael Kublin has uploaded a new change for review.
Change subject: engine: Perfromance improvements at IrsBrokerCommand
..
engine: Perfromance improvements at IrsBrokerCommand
The following patch is removing unneeded query for
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Changed edit VM disk to use run single action
(#848806)
..
webadmin: Changed edit VM disk to use run single action (#848806)
The edit VM disk command in
Ori Liel has uploaded a new change for review.
Change subject: restapi: #853739 - Actions Should Return Entities In Body
..
restapi: #853739 - Actions Should Return Entities In Body
https://bugzilla.redhat.com/853739
Change-Id:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Create systemd unit dir in the Makefile
..
Patch Set 2:
But it was a good change... using the proper _unitdir etc..
--
To view, visit http://gerrit.ov
Juan Hernandez has posted comments on this change.
Change subject: packaging: Create systemd unit dir in the Makefile
..
Patch Set 2:
Because I don't need it any longer.
--
To view, visit http://gerrit.ovirt.org/9427
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5:
Gal, from the first we added .gitattributes. So something is changed, please
address the change.
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5:
Vinzenz: sources should be LF, so can be edited and reviewed properly at all
platforms.
--
To v
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5:
Yes. That's what I said at first.
--
To view, visit http://gerrit.ovirt.org/9463
To unsubscribe, v
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5:
Gal,
Please address the technical discussion. If git enforces the line-ends what is
the problem
Vinzenz Feenstra has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 1:
Gal: So do you want all windows related files to be CRLF? Including the source
files?
--
To
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/9463
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 4:
Gal, exactly because of this git have the .gitattributes. You never forget as
it enforces specif
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 4:
Alon, I know that VC can handle LF. The problem is that "someone" will alway
forget a file (the in
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9463
To
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 4:
Gal, can you please address my comment?
--
To view, visit http://gerrit.ovirt.org/9463
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Create systemd unit dir in the Makefile
..
Patch Set 2:
Why abandon?
--
To view, visit http://gerrit.ovirt.org/9427
To unsubscribe, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 4: I would prefer that you didn't submit this
See my previous comment.
--
To view, visit http://gerri
Tal Nisan has posted comments on this change.
Change subject: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9464
To unsubscr
Juan Hernandez has abandoned this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/9426
To unsubscribe, visit http://gerrit.ovirt.org/s
Juan Hernandez has abandoned this change.
Change subject: packaging: Create systemd unit dir in the Makefile
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9427
To unsubscribe, visit http://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 1:
And... for these files you have .gitattributes.
A common .gitattribues for mixed unix/windows en
Alon Bar-Lev has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 1:
Gal,
Except of *.vc*, visual studio eats LF files good.
Alon
--
To view, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 10: Looks good to me, but someone else must approve
Although I really don't like the Pr
Roy Golan has submitted this change and it was merged.
Change subject: core: db - fixing wrong nfs_version argument in storage_san.sp
..
core: db - fixing wrong nfs_version argument in storage_san.sp
67761e1f513bdd17915ba7a47a6
Roy Golan has posted comments on this change.
Change subject: core: db - fixing wrong nfs_version argument in storage_san.sp
..
Patch Set 2: Verified; Looks good to me, approved
rebased, already acked
--
To view, visit http://
Roy Golan has posted comments on this change.
Change subject: core: db - fixing wrong nfs_version argument in storage_san.sp
..
Patch Set 2:
rebased, already acked
--
To view, visit http://gerrit.ovirt.org/9459
To unsubscribe,
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg
..
engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg
Specified error level for US
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 1: I would prefer that you didn't submit this
Please don't do that to Windows-only projects' files.
-
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Create systemd unit dir in the Makefile
..
Patch Set 2: (1 inline comment)
Minor comment... if you disagree go with this.
Alon Bar-Lev has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 9:
spec file missing?
--
To view, visit http://gerrit.ovirt.org/8715
To unsubscribe, v
Juan Hernandez has posted comments on this change.
Change subject: packaging: Create systemd unit dir in the Makefile
..
Patch Set 2:
Introduced the SYSTEMD_UNIT_DIR variable (instead of LIB_DIR) and passed the
value from the
Alon Bar-Lev has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 8:
dos2unix should be in its own patch to ease review... sorry for bothering
you... bu
Vinzenz Feenstra has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 8:
Note that the line endings have been 'fixed'
--
To view, visit http://gerrit.ov
Itamar Heim has posted comments on this change.
Change subject: core: Add Intel Haswel model
..
Patch Set 2:
not sure why this change and the opteron change aren't dependant, as they
conflict on same line.
in any case, both do
Roy Golan has posted comments on this change.
Change subject: core: db - fixing wrong nfs_version argument in storage_san.sp
..
Patch Set 1: Verified
since the SP isn't being invocked my validation is that it doesn't screw any
Vinzenz Feenstra has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 5: (1 inline comment)
File Gin
Alon Bar-Lev has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
Something is wrong w
Vinzenz Feenstra has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 4: (3 inline comments)
File Ma
Daniel Erez has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9390
To unsubscribe, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: db - fixing wrong nfs_version argument in storage_san.sp
..
Patch Set 1: Looks good to me, approved
I'd prefer leaving the ability to perform the full CRU
Doron Fediuck has posted comments on this change.
Change subject: packaging: Bump package version to 3.2.0
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8993
To unsubs
Juan Hernandez has posted comments on this change.
Change subject: packaging: Bump package version to 3.2.0
..
Patch Set 4:
Fixed the a typo in the commit message.
--
To view, visit http://gerrit.ovirt.org/8993
To unsubscribe,
Eli Mesika has submitted this change and it was merged.
Change subject: upgrade from 3.0.7 to SI24.4 fail(#879918)
..
upgrade from 3.0.7 to SI24.4 fail(#879918)
upgrade from 3.0.7 to SI24.4 fails: ERROR: insert or update on tab
1 - 100 of 122 matches
Mail list logo
