Michael Pasternak has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
please document new api remove signature in yaml metafile
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
Line 110: return performAction(VdcActionType.RemoveVds, new
RemoveVdsParameters(asGuid(id)));
Line 111: }
Line 112:
Line 113: @Override
Line 114: public Response remove(String id, Action action) {
do "getEntity(id);" here to throw 404 if this is not existent entity
Line 115: return performAction(VdcActionType.RemoveVds,
Line 116: new RemoveVdsParameters(asGuid(id), action != null &&
action.isSetForce() ? action.isForce() : false));
Line 117: }
Line 118:
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-18 17:03:11 +0530
Line 4: Commit: Dhandapani <[email protected]>
Line 5: CommitDate: 2012-11-22 19:11:25 +0530
Line 6:
Line 7: engine: Introduced force action in gluster peer detach command
you say "in gluster" while actually introduce new action on host, rather fix
the commit message or explain why it is 'gluster' related
Line 8:
Line 9: Change-Id: If2b8fa947cd6a6ece79ecfe00041f54e31e9e7ae
--
To view, visit http://gerrit.ovirt.org/8894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b8fa947cd6a6ece79ecfe00041f54e31e9e7ae
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
