Liron Aravot has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 428: }
Line 429: if (jobProperties == null) {
Line 430: jobProperties = super.getJobMessageProperties();
Line 431: jobProperties.put("sourcesd", sourceSDName);
Line 432: jobProperties.put("targetsd", getStorageDomainName());
please use == when comparing enums
Line 433: if
(ImageOperation.Move.equals(getParameters().getOperation())) {
Line 434: jobProperties.put("action", "Moving");
Line 435: } else {
Line 436: jobProperties.put("action", "Copying");
--
To view, visit http://gerrit.ovirt.org/9303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
