Doron Fediuck has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
After further investigation I was able to find this URL:
http://www.atl
Shireesh Anjal has posted comments on this change.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Michael Kublin has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (5 inline comments)
Not all question is answered
File
Doron Fediuck has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: I would prefer that you didn't submit this
Hi Justin,
Looking at https:/
Yair Zaslavsky has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (4 inline comments)
File backend/manager/dbscripts/upgr
Liron Aravot has posted comments on this change.
Change subject: core: WIP : OvfDataUpdater - removal calls to
updateVm/TemplateInSpm
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.o
Justin Hammond has uploaded a new change for review.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
engine: Integrate Atlassian Crowd Client as a new Authentication Domain
This adds s
Justin Hammond has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: Verified
been in production on a 3.1 node for about 3 months already.
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 10:
> I have to say that I feel a bit offended when you say that I have to o
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Show PM confirmation only in Virt Cluster
..
webadmin: Show PM confirmation only in Virt Cluster
While adding a new host to a cluster, PM confirmation d
Selvasundaram has posted comments on this change.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/dal/s
Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/commo
Kanagaraj M has posted comments on this change.
Change subject: engine: Adding null check for VDS in NewGlusterServersQuery
..
Patch Set 1: (1 inline comment)
File
backend/m
liron aravot has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (5 inline comments)
File backend/manager/dbscripts/create
Eli Mesika has posted comments on this change.
Change subject: core: [WIP] Remove global lock on SPM calls from engine side
..
Patch Set 1: (1 inline comment)
Commit Message
Eli Mesika has posted comments on this change.
Change subject: engine: Fixing a possible bug at SPM election
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/
Eli Mesika has posted comments on this change.
Change subject: engine: cannot run VM when path is null in devices spec-params
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9327
To unsubscr
Michael Kublin has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: I would prefer that you didn't submit this
(7 inline comments)
These patch not solves problems of races.
T
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Updated ui text for the handling of the system tasks
..
packaging: Updated ui text for the handling of the system tasks
Change-Id: I67eba20d
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Updated ui text for the handling of the system tasks
..
Patch Set 3: Verified; Looks good to me, approved
Verified by Author, acked by Simon, Alon &
liron aravot has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (10 inline comments)
Yair, i've replied your comments.
regarding the equals method, no - those fields are bas
Daniel Erez has uploaded a new change for review.
Change subject: restapi: Extend block domain - override_luns
..
restapi: Extend block domain - override_luns
Added 'override_luns' flag to update storage domain api:
* An optiona
Daniel Erez has uploaded a new change for review.
Change subject: core: Adding force extend support to extendVG
..
core: Adding force extend support to extendVG
* Added 'SupportForceExtendVG' configuration value
(true for vers
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated ui text for the handling of the system tasks
..
Patch Set 2: Looks good to me, but someone else must approve
Not that I have any value in going
Ravi Nori has uploaded a new change for review.
Change subject: engine: search does not complete boolean fields values
..
engine: search does not complete boolean fields values
Search engine does not complete values for boolean
Yair Zaslavsky has posted comments on this change.
Change subject: core: WIP : OvfDataUpdater - removal calls to
updateVm/TemplateInSpm
..
Patch Set 2: (1 inline comment)
Fi
Yair Zaslavsky has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: I would prefer that you didn't submit this
(10 inline comments)
And another comment - these new long fields
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2763/
Build Number: 2763
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,480
-
Change
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 10: (10 inline comments)
Regarding the _ and s_, do you expect to maintain
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 10:
Hi,
> Before starting to review the actual changes I would like to underst
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 10: (14 inline comments)
Thank you for review!
> Don't use the _ and s_ pre
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2762/
Build Number: 2762
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,479
-
Change
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 10:
Before starting to review the actual changes I would like to understand h
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 10: (14 inline comments)
Don't use the _ and s_ prefixes.
Some more comme
Liron Aravot has uploaded a new change for review.
Change subject: core: WIP : OvfDataUpdater - removal calls to updateVm/Template
in spm.
..
core: WIP : OvfDataUpdater - removal calls to updateVm/Template in spm.
Change-Id: Ie
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2761/
Build Number: 2761
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,478
-
Changes Sinc
Simon Grinberg has posted comments on this change.
Change subject: packaging: Updated ui text for the handling of the system tasks
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9330
To unsubscribe, visit ht
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: LSM - rephrasing move dialog warning
..
webadmin: LSM - rephrasing move dialog warning
Rephrasing move dialog warning to:
"Note: Moving the disk w
Tal Nisan has posted comments on this change.
Change subject: webadmin: LSM - rephrasing move dialog warning
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9338
To unsubscribe, vi
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: LSM - rephrasing move dialog warning
..
webadmin: LSM - rephrasing move dialog warning
Rephrasing move dialog warning to:
"Note: Moving the disk while t
Moran Goldboim has posted comments on this change.
Change subject: packaging: Updated ui text for the handling of the system tasks
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Itamar Heim has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
Hi Justin,
this looks very interesting (though i have to admit i didn't h
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding system information to getCapabilities from host
..
Adding system information to getCapabilities from host
Bug-Id: https://bugzilla.redhat.com/show_bug.c
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated ui text for the handling of the system tasks
..
Patch Set 2: Verified
Simon, please take a look at the text, if you like.
Thanks.
--
To view,
Yaniv Dary has uploaded a new change for review.
Change subject: history: added 3.2 views.
..
history: added 3.2 views.
Change-Id: I15c43f19d3dbac350f081e509b322cd70c77bf4a
Signed-off-by: Yaniv Dary
---
A data-warehouse/history
Yaniv Dary has uploaded a new change for review.
Change subject: history: updated create db scripts
..
history: updated create db scripts
Change-Id: I85c5e7129c63e43298a63cbec37049d2ee7e4afa
Signed-off-by: Yaniv Dary
---
M data
Yaniv Dary has uploaded a new change for review.
Change subject: history: added user tables
..
history: added user tables
Change-Id: Ife90396992238b9919bcf6377825c12a17082871
Signed-off-by: Yaniv Dary
---
M data-warehouse/histo
Yaniv Dary has uploaded a new change for review.
Change subject: history: added users tables views
..
history: added users tables views
Change-Id: I53af9329bb8d59a767aea797af0656f5d62e0024
Signed-off-by: Yaniv Dary
---
M data-w
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated ui text for the handling of the system tasks
..
packaging: Updated ui text for the handling of the system tasks
Change-Id: I67eba20d4f71c028808
Michael Pasternak has posted comments on this change.
Change subject: restapi: Privileged user cannot create VM via API (#876460)
..
Patch Set 1: I would prefer that you didn't submit this
[1] is saying that reason for this bug
Ravi Nori has posted comments on this change.
Change subject: restapi: API should expose hypervisor version (#829625)
..
Patch Set 3: (1 inline comment)
File
backend/manager
Michael Pasternak has posted comments on this change.
Change subject: restapi: API should expose hypervisor version (#829625)
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Also please add test t
Michael Pasternak has posted comments on this change.
Change subject: restapi: Mapping of empty name in user object (#B861098)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9138
To unsubsc
Ravi Nori has posted comments on this change.
Change subject: restapi: Inherited perms are not seen via RESTAPI (#871365)
..
Patch Set 2: (1 inline comment)
File
backend/man
Selvasundaram has posted comments on this change.
Change subject: engine: Gluster Volume Geo-replication Start
..
Patch Set 7: (3 inline comments)
File
backend/manager/dbscr
Liron Aravot has uploaded a new change for review.
Change subject: core:WIP: introducing OvfAutoUpdate
..
core:WIP: introducing OvfAutoUpdate
vm/template configurations (including disks info) are stored on the master
storage
do
Shahar Havivi has posted comments on this change.
Change subject: engine: cannot run VM when path is null in devices spec-params
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9327
To unsubscribe, visit http
Shahar Havivi has uploaded a new change for review.
Change subject: engine: cannot run VM when path is null in devices spec-params
..
engine: cannot run VM when path is null in devices spec-params
Change-Id: I1d5e2d67adcbb46608a
Tal Nisan has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerr
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix error message for locked disks
..
core: Fix error message for locked disks
This fix is related to bug Bug-Url: https://bugzilla.redhat.com/865551
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: style by pep8
..
Patch Set 1:
The more time is passed the harder it will be to apply.
--
To view, visit http://gerrit.ovirt.org/8854
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: code warning by pyflakes
..
Patch Set 1:
The more time is passed the harder it will be to apply.
--
To view, visit http://gerrit.ovirt.org/8853
To unsub
Liron Aravot has posted comments on this change.
Change subject: core: Extract disk alias generation methods
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/
Vered Volansky has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 14: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerrit.o
Vered Volansky has posted comments on this change.
Change subject: core: Extract disk alias generation methods
..
Patch Set 4: (1 inline comment)
File
backend/manager/module
Selvasundaram has posted comments on this change.
Change subject: engine: Configure passwordless ssh setup between the gluster
node and remote server
..
Patch Set 6: (1 inline comment)
Trailing White Spaces removed
..
Selvasundaram has uploaded a new change for review.
Change subject: engine: Get Gluster Volume Geo-replication Config query
..
engine: Get Gluster Volume Geo-replication Config query
- To fetch the Gluster Geo-replication Conf
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Quota refactor
..
core: Quota refactor
Design can be found here:
http://wiki.ovirt.org/wiki/Features/Design/Quota-3.2
Adding Objects for Quota co
Gilad Chaplik has posted comments on this change.
Change subject: core: Quota refactor
..
Patch Set 13: Verified; Looks good to me, approved
Reviewed (also by others), verified all flows (or at least complexed ones).
great job
Liron Aravot has posted comments on this change.
Change subject: core: Extract disk alias generation methods
..
Patch Set 4: (8 inline comments)
File
backend/manager/modules
Tomas Jelinek has posted comments on this change.
Change subject: userportal: rephrase user-portal login dialog title
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9143
To unsubscribe, vis
Vered Volansky has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerrit.ovirt.org/
Tal Nisan has posted comments on this change.
Change subject: core: Disallow removing of a DC when not all hosts are in
maintenance (#850286)
..
Patch Set 6:
No change, just rebase
--
To view, visit http://gerrit.ovirt.org/91
Tal Nisan has submitted this change and it was merged.
Change subject: core: Disallow removing of a DC when not all hosts are in
maintenance (#850286)
..
core: Disallow removing of a DC when not all hosts are in maintenance (#8
Tal Nisan has posted comments on this change.
Change subject: core: Disallow removing of a DC when not all hosts are in
maintenance (#850286)
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Shireesh Anjal has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9044
To unsubs
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: tar: throw an exception if base does not exist
..
utils: tar: throw an exception if base does not exist
Change-Id: I25e4e41f7c68c9a6b797b7436c85
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Event log - a method to bypass flow
..
core: Event log - a method to bypass flow
Event log - a method to bypass flood filtering
Adding a customI
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
bootstrap: host add: differentiate between authentication error and
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: do not check connectivity nor unique id when
VdsInstall=false
..
bootstrap: do not check connectivity nor unique id when VdsInstall=false
C
Yair Zaslavsky has submitted this change and it was merged.
Change subject: pki: accept subject name for certificate
..
pki: accept subject name for certificate
This enables generating a completely empty certificate request, se
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: ssh: move to member '_' convention
..
utils: ssh: move to member '_' convention
We had several discussion over this.
Convention for members/sta
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: do not get unique id at canDoAction
..
bootstrap: do not get unique id at canDoAction
CURRENT IMPLEMENTATION
engine has duplicate complex v
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: move Tar, CachedTar classes to own package
..
utils: move Tar, CachedTar classes to own package
Change-Id: Ic0227d540ede0be17f5803e3046092a73172
Yair Zaslavsky has submitted this change and it was merged.
Change subject: pki: cleanup the ca interface
..
pki: cleanup the ca interface
VdsInstaller is about the retire, but it contains some dirty code that
is actually belon
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: fix ovirt-node parameters and locations
..
bootstrap: fix ovirt-node parameters and locations
currently we hold old rhev-h settings, while o
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: tests: tar: cleanup main() entry point
..
utils: tests: tar: cleanup main() entry point
People found that this unused testing only code needs to
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: ssh: don't add ssh command to exception
..
utils: ssh: don't add ssh command to exception
It results in a long unclear message to the user.
Cha
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: tar: support long file names within tar
..
utils: tar: support long file names within tar
Change-Id: I364d67dc408af21e08a20014c6a0c99a413fe3be
S
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: handle bootstrap messages using string member
..
bootstrap: handle bootstrap messages using string member
Current implementation holds the V
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: tests: do not use default key alias
..
utils: tests: do not use default key alias
Allow to specify key to use as client.
Change-Id: I6242a2b6f1
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: ssh: optimize progress streams
..
utils: ssh: optimize progress streams
Default java implementation of filtered stream is byte-by-byte
operation
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: allow distinguish error from non error messages
..
bootstrap: allow distinguish error from non error messages
The old bootstrap xml like pro
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: ssh: fixup activity detection
..
utils: ssh: fixup activity detection
Current implementation considers only the first active stream, leaving
oth
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: ssh: cleanup: rename server with host
..
utils: ssh: cleanup: rename server with host
'Host' is more compatible with the other API.
Change-Id:
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
bootstrap: split the logic of ovirt-node upgrade out
Currently we have 4 separate bootstrap met
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: fix ovirt-node parameters and locations
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9156
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: do not check connectivity nor unique id when
VdsInstall=false
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: do not get unique id at canDoAction
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9159
To unsubscribe, visit h
1 - 100 of 163 matches
Mail list logo
