Michael Pasternak has posted comments on this change. Change subject: restapi: API should expose hypervisor version (#829625) ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Also please add test to this use-case. thanks. .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java Line 139: StorageManager sm = new StorageManager(); Line 140: sm.setPriority(entity.getVdsSpmPriority()); Line 141: sm.setValue(entity.getspm_status() == VdsSpmStatus.SPM); Line 142: model.setStorageManager(sm); Line 143: model.setOs(getHostOs(entity.gethost_os())); Her ravi, where /version element is gone? i meant adding OS in addition to the vdsm /version. Line 144: model.setKsm(new KSM()); Line 145: model.getKsm().setEnabled(Boolean.TRUE.equals(entity.getksm_state())); Line 146: model.setTransparentHugepages(new TransparentHugePages()); Line 147: model.getTransparentHugepages().setEnabled(!(entity.getTransparentHugePagesState() == null || -- To view, visit http://gerrit.ovirt.org/9220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8d3d090ae4c0ba489f3c7484d5c232c55f3c059 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
