Ravi Nori has posted comments on this change. Change subject: restapi: Inherited perms are not seen via RESTAPI (#871365) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java Line 214 Line 215 Line 216 Line 217 Line 218 Because VM and Disk are not assignable from DataCenter, Role or User so getParentModel(R model, Class<?> parentType) when called with getParentModel(Permission model, VM parentType) returns null. Resulting in private static Collection getCollection(BaseResource model, Class<? extends BaseResource> suggestedParentType) { ParentToCollectionMap collections = TYPES.get(model.getClass()); throwing a null pointer exception because model is null So my understanding is if VM and Disk are not subclasses of DataCenter, Role or User they should not be in the map -- To view, visit http://gerrit.ovirt.org/9243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1a05d64ed61ae2bcf813b926bb548842bada237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches