Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: disks main-tab - disable prefix localization
..
webadmin: disks main-tab - disable prefix localization
Extract disks search prefix strings to NO
Einav Cohen has posted comments on this change.
Change subject: webadmin: disks main-tab - disable prefix localization
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9296
To unsub
Sharad Mishra has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
..
Patch Set 4:
I agree with Yair on convention. At the same time I am open to new ideas.
We should not follow multip
Daniel Erez has posted comments on this change.
Change subject: webadmin: disks main-tab - disable prefix localization
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9296
To unsubscribe, visit http://gerrit.
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: disks main-tab - disable prefix localization
..
webadmin: disks main-tab - disable prefix localization
Extract disks search prefix strings to NON-NLS co
Sharad Mishra has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
one minor formatting co
Sharad Mishra has posted comments on this change.
Change subject: registration: fix null pointer exception
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9158
To unsubs
Sharad Mishra has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9148
To unsub
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Fix log message in VdsInstaller
..
core: Fix log message in VdsInstaller
The current code uses {1} in a log message with only one parameter, it
s
Juan Hernandez has posted comments on this change.
Change subject: core: Fix log message in VdsInstaller
..
Patch Set 1: Looks good to me, approved
This is so minor that I am merging it without further review.
--
To view, visi
Alon Bar-Lev has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
Rebase, sorry.
--
To view, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: core: Fix log message in VdsInstaller
..
Patch Set 1: Looks good to me, but someone else must approve
Thanks!
--
To view, visit http://gerrit.ovirt.org/9291
To u
Alon Bar-Lev has posted comments on this change.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
..
Patch Set 7: No score
--
To view, visit http://gerrit.ovirt.org/9160
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tar: split tar unit test from VdsInstallerSSH tests.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9292
To unsubscribe, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: cleanup: rename server with host
..
Patch Set 3: Verified
Fix error in the to be removed VdsInstallerSSH.java.
--
To view, visit http://gerrit.ovirt.
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
Patch Set 7: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9178
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: handle bootstrap messages using string member
..
Patch Set 6: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9173
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 6: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
..
Patch Set 7: Verified
Mock the EngeineSSHDialog as requested.
This is how one pays for compromising in de
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 6: Verified
Fix per Douglas comment.
--
To view, visit http://gerrit.ovirt.org/9161
To un
Alon Bar-Lev has uploaded a new change for review.
Change subject: utils: tar: split tar unit test from VdsInstallerSSH tests.
..
utils: tar: split tar unit test from VdsInstallerSSH tests.
VdsInstallerSSH.java is about to retir
Juan Hernandez has posted comments on this change.
Change subject: core: Fix log message in VdsInstaller
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9291
To unsubscribe, visit http://gerrit.ovirt.org/sett
Juan Hernandez has uploaded a new change for review.
Change subject: core: Fix log message in VdsInstaller
..
core: Fix log message in VdsInstaller
The current code uses {1} in a log message with only one parameter, it
should us
Federico Simoncelli has uploaded a new change for review.
Change subject: tools: add the nossl option for the engine connection
..
tools: add the nossl option for the engine connection
Change-Id: I84dcfe472006add3e0a7ba42661ea9d
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pki: accept subject name for certificate
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 5: (1 inline comment)
Please don't abuse the -1.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
-1 since I
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: handle bootstrap messages using string member
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://ge
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: tests: do not use default key alias
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerri
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: tar: support long file names within tar
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Douglas Schilling Landgraf has posted comments on this change.
Change subject: registration: fix null pointer exception
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9
Ravi Nori has posted comments on this change.
Change subject: restapi: API should expose hypervisor version (#829625)
..
Patch Set 3: (1 inline comment)
File
backend/manager
Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 6:
After moving fn_db_delete_version_map function to action_version_map_sp.sql, it
was no longer
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: do not check connectivity nor unique id when
VdsInstall=false
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: fix ovirt-node parameters and locations
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Douglas Schilling Landgraf has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
Patch Set 6: Looks good to me, but someone else must approve
--
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: move Tar, CachedTar classes to own package
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: ssh: cleanup: rename server with host
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: introduce new libosinfo query
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9047
T
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2191/
Build Number: 2191
Build Status: Fixed
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: UI: libosinfo - validate VM minimum RAM with libosinfo
..
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
Relative mino
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Aligning labels in Volume dialog for Japanese locale
..
webadmin: Aligning labels in Volume dialog for Japanese locale
Changed the width of the labels a
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packagin: libosinfo - add libosinfo RPM dependency
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
..
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: libosinfo delete unused queries
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9055
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2190/
Build Number: 2190
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Eli Mesika has submitted this change and it was merged.
Change subject: core:Do not force fencing proxy to be ...(#876235)
..
core:Do not force fencing proxy to be ...(#876235)
Do not force fencing proxy to be in UP status
Cur
Eli Mesika has posted comments on this change.
Change subject: core:Do not force fencing proxy to be ...(#876235)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9251
To unsubscrib
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
..
Patch Set 4:
Again, look at the discussion I had with the gluster people.
I am sorry to say, but java people are pri
Alon Bar-Lev has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
All the patches needs to be merged now. You ca
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: optimize progress streams
..
Patch Set 4:
Please merge this as-is, when needed we move.
--
To view, visit http://gerrit.ovirt.org/9170
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup the ca interface
..
Patch Set 4:
Better to use java-7 try-close.
--
To view, visit http://gerrit.ovirt.org/9162
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
..
Patch Set 4:
A patch should do not move and change in same command.
Please flag.
--
To view, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tests: tar: cleanup main() entry point
..
Patch Set 4:
Totally unrelated.
There is unit test:
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=
Yair Zaslavsky has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 6:
Suggestion - why not break dependency in patches and get this merged already?
there is a seperate bug
56 matches
Mail list logo
