Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh: move to member '_' convention ......................................................................
Patch Set 4: Again, look at the discussion I had with the gluster people. I am sorry to say, but java people are primitive as it relates to the tools they use. These conventions relays on the nature you have some syntax highlight and code processor. Now that you review patches and need to review hanks within git, and look at hanks within gerrit, you need more information out of the code than the syntax highlighter. These examples of conventions are incorrect as it does not show you real life scenarios. It only shows you the principals. It is by far *NOT* a bible. The '_' attributes EXTENDS the convention not replace it, it only marks objects to context, following the convention AS-IS. It follow the java convention out to the letter, as you allow to add suffixes, one should also allow to add prefix. PLEASE PLEASE PLEASE PLEASE open your mind, and see that the world is not flat. -- To view, visit http://gerrit.ovirt.org/9171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bca20cec1e309105805d2c741c56abf04ab33d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
