Alon Bar-Lev has posted comments on this change.

Change subject: bootstrap: allow distinguish error from non error messages
......................................................................


Patch Set 5: (1 inline comment)

Please don't abuse the -1.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
Line 87:             }
Line 88:             AuditLogableBase logable = new AuditLogableBase(_vdsId);
Line 89:             logable.AddCustomValue("Message", 
StringUtils.stripEnd(sb.toString(), " "));
Line 90:             AuditLogDirector.log(logable, logType);
Line 91:             return error;
You are right.
Line 92:         }
Line 93: 
Line 94:         return error;
Line 95:     }


--
To view, visit http://gerrit.ovirt.org/9161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62de9fab0ae3c10d245ed6c2580bf8fcc09057d6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to