[Engine-patches] Change in ovirt-engine[master]: utils: cleanup: SSHClient: add properties get methods

2012-09-14 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: utils: cleanup: SSHClient: add properties get methods .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: utils: cleanup: SSHClient: add properties get methods

2012-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: cleanup: SSHClient: add properties get methods .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/8009 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: utils: cleanup: SSHClient: add properties get methods

2012-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: cleanup: SSHClient: add properties get methods .. Patch Set 1: (1 inline comment) File backend/manage

[Engine-patches] Change in ovirt-engine[master]: utils: cleanup: SSHClient: add properties get methods

2012-09-14 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: utils: cleanup: SSHClient: add properties get methods .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Minor comment inside.

[Engine-patches] Change in ovirt-engine[master]: utils: cleanup: SSHClient: add properties get methods

2012-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: cleanup: SSHClient: add properties get methods .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8009 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: utils: cleanup: SSHClient: add properties get methods

2012-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: utils: cleanup: SSHClient: add properties get methods .. utils: cleanup: SSHClient: add properties get methods This is required to allow proper messaging and pro

[Engine-patches] Change in ovirt-engine[master]: core: Refactored roles to Role.

2012-09-14 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Refactored roles to Role. .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7229 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: Refactored roles to Role.

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: Refactored roles to Role. .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/7229 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: Replaced getDiskImageDAO with getDiskImageDao

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: Replaced getDiskImageDAO with getDiskImageDao .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/7846 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Replaced getDiskImageDAO with getDiskImageDao

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: Replaced getDiskImageDAO with getDiskImageDao .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/7846 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: engine: Refactored ExecuteVmCommand() to conform to java sta...

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: engine: Refactored ExecuteVmCommand() to conform to java standards. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7937 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: alert count notation is a prefix instead of a numb...

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: webadmin: alert count notation is a prefix instead of a number (#854166) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: Refactored EndWithFailure()

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: engine: Refactored EndWithFailure() .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/7938 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: removing unused class AdGroupsHandlingOperationBase

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: removing unused class AdGroupsHandlingOperationBase .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7994 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Renamed Execute() to execute() in BrokerCommandBase cl...

2012-09-14 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: Renamed Execute() to execute() in BrokerCommandBase class .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7996 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: HibernateVmCommand's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: HibernateVmCommand's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: core: VmCommand's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: VmCommand's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7801 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: RestoreFromSnapshot's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: RestoreFromSnapshot's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved see previous patch comment -- To view, visit http://gerrit.ovirt.org/78

[Engine-patches] Change in ovirt-engine[master]: core: RemoveTemplateSnapshot's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: RemoveTemplateSnapshot's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved see previous patch comment -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: RemoveSnapshotSingleDisk ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: RemoveSnapshotSingleDisk ConcreteCreateTask .. Patch Set 5: Looks good to me, approved (1 inline comment) minor comment ..

[Engine-patches] Change in ovirt-engine[master]: core: RemoveImage's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: RemoveImage's ConcreteCreateTask .. Patch Set 5: (1 inline comment) File backend/manager/modules/bll/s

[Engine-patches] Change in ovirt-engine[master]: core: RemoveImage's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: RemoveImage's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7797 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: MoveOrCopyImageGroup's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: MoveOrCopyImageGroup's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7796 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: CreateCloneOfTemplate's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: CreateCloneOfTemplate's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7795 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: CreateImageTemplate's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: CreateImageTemplate's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7794 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: AddImageFromScratch's ConcreteCreateTask

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: AddImageFromScratch's ConcreteCreateTask .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7793 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: CommandsBase: refactor task creation

2012-09-14 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: CommandsBase: refactor task creation .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7792 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-iso-uploader[master]: Fix default port (BZ857480)

2012-09-14 Thread kroberts
Keith Robertson has uploaded a new change for review. Change subject: Fix default port (BZ857480) .. Fix default port (BZ857480) Change-Id: Idab93219597d8199ffb79a0c7c664c6369c0416a Signed-off-by: Keith Robertson --- M src/engi

[Engine-patches] Change in ovirt-log-collector[master]: tools: Fix default port (BZ857128)

2012-09-14 Thread kroberts
Keith Robertson has uploaded a new change for review. Change subject: tools: Fix default port (BZ857128) .. tools: Fix default port (BZ857128) Change-Id: Ice63ed76f3c5166ed5586ad8984709d7ff77e62c Signed-off-by: Keith Robertson

[Engine-patches] Change in ovirt-image-uploader[master]: tools: Fix default port (BZ857128)

2012-09-14 Thread kroberts
Keith Robertson has uploaded a new change for review. Change subject: tools: Fix default port (BZ857128) .. tools: Fix default port (BZ857128) Change-Id: I1be2e0c2af8f6c0f05144323686ab84801b2aa45 Signed-off-by: Keith Robertson

[Engine-patches] Change in ovirt-engine[master]: engine: Get Gluster Servers query

2012-09-14 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Get Gluster Servers query .. Patch Set 14: (1 inline comment) Incorporated review comments. File

[Engine-patches] Change in ovirt-engine[master]: engine: Get Gluster Servers query

2012-09-14 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Get Gluster Servers query .. Patch Set 13: (1 inline comment) File backend/manager/modules/bll/src

[Engine-patches] Change in ovirt-engine[master]: engine: Get Gluster Servers query

2012-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: Get Gluster Servers query .. Patch Set 14: (1 inline comment) File backend/manager/modules/bll/src/m