Maor Lipchuk has posted comments on this change.
Change subject: core: HibernateVmCommand's ConcreteCreateTask
......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
Line 69: new AddImageFromScratchCommand(new
AddImageFromScratchParameters()),
Line 70: new CreateImageTemplateCommand(new
CreateImageTemplateParameters()),
Line 71: new CreateCloneOfTemplateCommand(new
CreateCloneOfTemplateParameters()),
Line 72: new RemoveVmCommand(new RemoveVmParameters()),
Line 73: new HibernateVmCommand(new HibernateVmParameters()) {
Consider refator to method
Line 74: @Override
Line 75: public VM getVm() {
Line 76: VM vm = new VM();
Line 77: vm.setId(Guid.NewGuid());
--
To view, visit http://gerrit.ovirt.org/7802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I813d7a7b8933cdcdedb343322359756b345d3765
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
