[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 4: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/646/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: core: bad value mapping causes audio device AC97 to be ignor...

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: bad value mapping causes audio device AC97 to be ignored (#850823) .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt

[Engine-patches] Change in ovirt-engine[master]: core: fix updating a Vm console type will update video devic...

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix updating a Vm console type will update video devices .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/644/

[Engine-patches] Change in ovirt-engine[master]: core: bad value mapping causes audio device AC97 to be ignor...

2012-08-23 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: bad value mapping causes audio device AC97 to be ignored (#850823) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7451 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: fix updating a Vm console type will update video devic...

2012-08-23 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: fix updating a Vm console type will update video devices .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7450 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/7414 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: bad value mapping causes audio device AC97 to be ignor...

2012-08-23 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: bad value mapping causes audio device AC97 to be ignored (#850823) .. core: bad value mapping causes audio device AC97 to be ignored (#850823) Change-Id: I43

[Engine-patches] Change in ovirt-engine[master]: core: fix updating a Vm console type will update video devic...

2012-08-23 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: fix updating a Vm console type will update video devices .. core: fix updating a Vm console type will update video devices if the console type has changed or

[Engine-patches] Change in ovirt-engine[master]: engine: Exception when updating lun disk properties (#844153...

2012-08-23 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: engine: Exception when updating lun disk properties (#844153) .. Patch Set 3: s/The id for the storage pool id/The storage pool id for this operation in the audi

[Engine-patches] Change in ovirt-engine[master]: engine: Exception when updating lun disk properties (#844153...

2012-08-23 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: engine: Exception when updating lun disk properties (#844153) .. Patch Set 3: Verified Maor, thanks, I removed the method. The id for the storage pool id is now

[Engine-patches] Change in ovirt-engine[master]: engine: Exception when updating lun disk properties (#844153...

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Exception when updating lun disk properties (#844153) .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/643/

[Engine-patches] Change in ovirt-engine[master]: packaging: Move defaults out of service script

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: Move defaults out of service script .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/641/ : FAILURE http

[Engine-patches] Change in ovirt-engine[master]: engine: Exception when updating lun disk properties (#844153...

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Exception when updating lun disk properties (#844153) .. Patch Set 2: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/639/

[Engine-patches] Change in ovirt-engine[master]: core, packaging: Don't use JBoss default ports (#831193)

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, packaging: Don't use JBoss default ports (#831193) .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/638/ : FAI

[Engine-patches] Change in ovirt-engine[master]: packaging: Clean pgpass file on engine-cleanup

2012-08-23 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Clean pgpass file on engine-cleanup .. packaging: Clean pgpass file on engine-cleanup We should clean pgpass file on engine-cleanup. This pa

[Engine-patches] Change in ovirt-engine[master]: packaging: Clean pgpass file on engine-cleanup

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Clean pgpass file on engine-cleanup .. Patch Set 12: Verified; Looks good to me, approved Based on previous acks and verification. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: Move defaults out of service script

2012-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Move defaults out of service script .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7387 To u

[Engine-patches] Change in ovirt-engine[master]: packaging: Move defaults out of service script

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Move defaults out of service script .. Patch Set 3: Fixed whitespace. -- To view, visit http://gerrit.ovirt.org/7387 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: [WIP] Allow to attach V1 and V2 data domains to a DC 3.1

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Allow to attach V1 and V2 data domains to a DC 3.1 .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/637/ : FAI

[Engine-patches] Change in ovirt-engine[master]: engine: Added new column 'ssh_key_fingerprint' in the vds_st...

2012-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: Added new column 'ssh_key_fingerprint' in the vds_static table .. Patch Set 3: Just to make sure... fingerprint can be null right? both in database and i

[Engine-patches] Change in ovirt-engine[master]: Engine: set Rhev-H upgrade version via config value (#842767...

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Engine: set Rhev-H upgrade version via config value (#842767) .. Patch Set 2: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/636/

[Engine-patches] Change in ovirt-engine[master]: packaging: Move defaults out of service script

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: Move defaults out of service script .. Patch Set 2: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/634/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[master]: core: Fix notifier parameters

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix notifier parameters .. Patch Set 4: Looks good to me, approved Following Itamar's comment - approving this patch. -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Add local configuration helper

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add local configuration helper .. Patch Set 9: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/633/ : SUCCESS http://jenkins

[Engine-patches] Change in ovirt-engine[master]: core: Fix notifier parameters

2012-08-23 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Fix notifier parameters .. Patch Set 4: no point on working on something there isn't a clear demand for. notification can be assumed to be on same server -

[Engine-patches] Change in ovirt-engine[master]: core: Fix notifier parameters

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Fix notifier parameters .. Patch Set 4: Good question Yair. In fact the notifier can't be installed without the engine, and (to some degree) the engine c

[Engine-patches] Change in ovirt-engine[master]: core: Fix notifier parameters

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix notifier parameters .. Patch Set 4: Juan, this looks good. General question - I understood why you took off all server URL (i.e - localhost:80) - do

[Engine-patches] Change in ovirt-engine[master]: packaging: Clean pgpass file on engine-cleanup

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: Clean pgpass file on engine-cleanup .. Patch Set 11: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/630/ : FAILURE htt

[Engine-patches] Change in ovirt-engine[master]: core: Add local configuration helper

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Add local configuration helper .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: Add local configuration helper

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Add local configuration helper .. Patch Set 9: Juan, I agree with Alon's approach. -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Add local configuration helper

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Add local configuration helper .. Patch Set 9: Previous incarnations of the patch had those methods where the called can provide the default values. Alon

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove "expect" header from requests (#849442)

2012-08-23 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: restapi: Remove "expect" header from requests (#849442) .. restapi: Remove "expect" header from requests (#849442) https://bugzilla.redhat.com/849442

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove "expect" header from requests (#849442)

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: restapi: Remove "expect" header from requests (#849442) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7399 To u

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove "expect" header from requests (#849442)

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: restapi: Remove "expect" header from requests (#849442) .. Patch Set 3: Good job on this :) -- To view, visit http://gerrit.ovirt.org/7399 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Add local configuration helper

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Add local configuration helper .. Patch Set 9: Juan, Sorry for the "late thought" about this (Was just explaining some new guy at Infra something about c

[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 3: (1 inline comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 3: - also fixed: when creating with num of monitors > 1 we should create a video device per moni

[Engine-patches] Change in ovirt-engine[master]: core, packaging: Don't use JBoss default ports (#831193)

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core, packaging: Don't use JBoss default ports (#831193) .. Patch Set 3: Rebased. I need some time to deeply re-verify it. -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core : create template from VM with no snappable disks (#841...

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : create template from VM with no snappable disks (#841534) .. Patch Set 7: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/62

[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/624/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: core, packaging: Don't use JBoss default ports (#831193)

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core, packaging: Don't use JBoss default ports (#831193) .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6348 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: Cleanup quota view (#848107)

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Cleanup quota view (#848107) .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/623/ : SUCCESS http://jenki

[Engine-patches] Change in ovirt-engine[master]: core: Fix quota calc for stateless (#848107)

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix quota calc for stateless (#848107) .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/622/ : FAILURE http:/

[Engine-patches] Change in ovirt-engine[master]: packaging: Move defaults out of service script

2012-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Move defaults out of service script .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: core: Add local configuration helper

2012-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: Add local configuration helper .. Patch Set 9: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: Fix handle quota release (#848107)

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix handle quota release (#848107) .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/621/ : FAILURE http://jen

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove "expect" header from requests (#849442)

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: restapi: Remove "expect" header from requests (#849442) .. Patch Set 3: Verified Used the following JSP to verify that the web server actually removes the "exp

[Engine-patches] Change in ovirt-engine[master]: [WIP] Allow to attach V1 and V2 data domains to a DC 3.1

2012-08-23 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Allow to attach V1 and V2 data domains to a DC 3.1 .. [WIP] Allow to attach V1 and V2 data domains to a DC 3.1 RHBZ: 844367 Signed-off-by: Federico

[Engine-patches] Change in ovirt-engine[master]: Engine: set Rhev-H upgrade version via config value (#842767...

2012-08-23 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Engine: set Rhev-H upgrade version via config value (#842767) .. Patch Set 2: 1. these versions are not relevant to ovirt-node. 2. these are the versions of ovirt-

[Engine-patches] Change in ovirt-engine[master]: core: Usage as Lowercase and in Caps (#817798)

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Usage as Lowercase and in Caps (#817798) .. Patch Set 2: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/620/ : FAILURE http

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster server peer list command

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Gluster server peer list command .. Patch Set 7: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/619/ : FAILURE http://jen

[Engine-patches] Change in ovirt-engine[master]: restapi: Add 3.1 Features To Capabilities

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Add 3.1 Features To Capabilities .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/618/ : SUCCESS http://je

[Engine-patches] Change in ovirt-engine[master]: Engine: set Rhev-H upgrade version via config value (#842767...

2012-08-23 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: Engine: set Rhev-H upgrade version via config value (#842767) .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/7430 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: Engine: set Rhev-H upgrade version via config value (#842767...

2012-08-23 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: Engine: set Rhev-H upgrade version via config value (#842767) .. Patch Set 1: this versions are in the folder /usr/share cd rhev-hypervisor/version-*.txt files

[Engine-patches] Change in ovirt-engine[master]: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from...

2012-08-23 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from template .. packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from template Current

[Engine-patches] Change in ovirt-engine[master]: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from...

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from template .. Patch Set 4: Verified Based on previous acks and verification. -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from...

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from template .. Patch Set 4: Looks good to me, approved Based on previous acks and verification. -- T

[Engine-patches] Change in ovirt-engine[master]: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from...

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from template .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7398

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove "expect" header from requests (#849442)

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: restapi: Remove "expect" header from requests (#849442) .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7399 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: Add local configuration helper

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Add local configuration helper .. Patch Set 9: Added the ENGINE_DEFAULTS environment variable to point to the file containing the defaults. -- To view,

[Engine-patches] Change in ovirt-engine[master]: packaging: Move defaults out of service script

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Move defaults out of service script .. Patch Set 2: Added the ENGINE_DEFAULTS environment variable to point to the defaults file. Moved the merging

[Engine-patches] Change in ovirt-engine[master]: Engine: set Rhev-H upgrade version via config value (#842767...

2012-08-23 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Engine: set Rhev-H upgrade version via config value (#842767) .. Patch Set 1: these versions aren't related to ovirt-node? the right approach would be to expose in

[Engine-patches] Change in ovirt-engine[master]: core: Propagate correlation id in maintenance commmand (#846...

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Propagate correlation id in maintenance commmand (#846227) .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/7412 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Propagate correlation id in maintenance commmand (#846...

2012-08-23 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Propagate correlation id in maintenance commmand (#846227) .. core: Propagate correlation id in maintenance commmand (#846227) https://bugzilla.r

[Engine-patches] Change in ovirt-engine[master]: core: Propagate correlation id in maintenance commmand (#846...

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Propagate correlation id in maintenance commmand (#846227) .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7412 To un

[Engine-patches] Change in ovirt-engine[master]: core: Propagate correlation id in maintenance commmand (#846...

2012-08-23 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Propagate correlation id in maintenance commmand (#846227) .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7412 To un

[Engine-patches] Change in ovirt-reports[master]: reports: fixed axis colors in webadmin dashboards (#846311)

2012-08-23 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: reports: fixed axis colors in webadmin dashboards (#846311) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7443 To u

[Engine-patches] Change in ovirt-reports[master]: reports: fixed axis colors in webadmin dashboards (#846311)

2012-08-23 Thread ydary
Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed axis colors in webadmin dashboards (#846311) .. reports: fixed axis colors in webadmin dashboards (#846311) now all the axis colors match ac

[Engine-patches] Change in ovirt-reports[master]: reports: fixed axis colors in webadmin dashboards (#846311)

2012-08-23 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: reports: fixed axis colors in webadmin dashboards (#846311) .. reports: fixed axis colors in webadmin dashboards (#846311) now all the axis colors match across the

[Engine-patches] Change in ovirt-engine[master]: packaging: Clean pgpass file on engine-cleanup

2012-08-23 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: packaging: Clean pgpass file on engine-cleanup .. Patch Set 11: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: BZ#850727 bootstrap: acquire time for host immediately befor...

2012-08-23 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: BZ#850727 bootstrap: acquire time for host immediately before send .. BZ#850727 bootstrap: acquire time for host immediately before send Engine uses it

[Engine-patches] Change in ovirt-engine[master]: BZ#850727 bootstrap: acquire time for host immediately befor...

2012-08-23 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: BZ#850727 bootstrap: acquire time for host immediately before send .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: BZ#850727 bootstrap: acquire time for host immediately befor...

2012-08-23 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: BZ#850727 bootstrap: acquire time for host immediately before send .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7381 To

[Engine-patches] Change in ovirt-engine[master]: webadmin: Cleanup quota view (#848107)

2012-08-23 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: webadmin: Cleanup quota view (#848107) .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7382 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: restapi: Support action links on collection context

2012-08-23 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Support action links on collection context .. Patch Set 1: Do not submit requires further discussion -- To view, visit http://gerrit.ovirt.org/6816

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdk: rebase to latest api .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_engine_sdk_testing_rpms/15/ : SUCCESS -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: webadmin: filter V3 SDs for 3.0 DCs (#845067)

2012-08-23 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: filter V3 SDs for 3.0 DCs (#845067) .. webadmin: filter V3 SDs for 3.0 DCs (#845067) https://bugzilla.redhat.com/845067 Attach storage dialog -

[Engine-patches] Change in ovirt-engine[master]: webadmin: filter V3 SDs for 3.0 DCs (#845067)

2012-08-23 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: filter V3 SDs for 3.0 DCs (#845067) .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/7389 To unsub

[Engine-patches] Change in ovirt-engine[master]: webadmin: allow unattached V1 block SD (#840558)

2012-08-23 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: allow unattached V1 block SD (#840558) .. webadmin: allow unattached V1 block SD (#840558) https://bugzilla.redhat.com/840558 Allow creation of

[Engine-patches] Change in ovirt-engine[master]: webadmin: allow unattached V1 block SD (#840558)

2012-08-23 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: allow unattached V1 block SD (#840558) .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/7388 To un

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: clean context on disconnect

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdk: clean context on disconnect .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_engine_sdk_testing_rpms/14/ : SUCCESS -- To vi

[Engine-patches] Change in ovirt-engine-cli[master]: cli: implement /filter flag

2012-08-23 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: cli: implement /filter flag .. cli: implement /filter flag sdk resource /api invoked on /connect has few queries (such as GetSystemStatistics, etc.) which r

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-08-23 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: rebase to latest api .. sdk: rebase to latest api - added create/update/delete methods to template.nics - brokers module classes been reordered due to

[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 3: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: clean context on disconnect

2012-08-23 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: clean context on disconnect .. sdk: clean context on disconnect Change-Id: Ic1f8f8b035cd68cf411ae7f0802827d62cc6e537 Signed-off-by: Michael Pasternak

[Engine-patches] Change in ovirt-engine[master]: core: Fix quota calc for stateless (#848107)

2012-08-23 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Fix quota calc for stateless (#848107) .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7438 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: engine: Added new column 'ssh_key_fingerprint' in the vds_st...

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added new column 'ssh_key_fingerprint' in the vds_static table .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_a

[Engine-patches] Change in ovirt-engine[master]: core: Fix handle quota release (#848107)

2012-08-23 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Fix handle quota release (#848107) .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Ofri, OVF is persisting a VM. e need to h

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk (#850795)

2012-08-23 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix potential NPE when adding LUN disk (#850795) .. core: Fix potential NPE when adding LUN disk (#850795) https://bugzilla.redhat.com/show_bug.cgi

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk (#850795)

2012-08-23 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk (#850795) .. Patch Set 4: Verified; Looks good to me, approved Acked by derez -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-23 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 2: Looks good to me, approved Please remove redundant extra lines on rebase. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from...

2012-08-23 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Generate /etc/httpd/conf.d/ovirt-engine.conf from template .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7398 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster server peer list command

2012-08-23 Thread sesubram
Selvasundaram has posted comments on this change. Change subject: engine: Gluster server peer list command .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/7242 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: fix adding the right video device type (#849635)

2012-08-23 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: fix adding the right video device type (#849635) .. Patch Set 3: Verified - patch was changed completly -- To view, visit http://gerrit.ovirt.org/7414 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: Fix quota calc for stateless (#848107)

2012-08-23 Thread omasad
ofri masad has posted comments on this change. Change subject: core: Fix quota calc for stateless (#848107) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7438 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: webadmin: Cleanup quota view (#848107)

2012-08-23 Thread omasad
ofri masad has posted comments on this change. Change subject: webadmin: Cleanup quota view (#848107) .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7382 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: core: Fix handle quota release (#848107)

2012-08-23 Thread omasad
ofri masad has posted comments on this change. Change subject: core: Fix handle quota release (#848107) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7437 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster server peer list command

2012-08-23 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Gluster server peer list command .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7242 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: Fix handle quota release (#848107)

2012-08-23 Thread omasad
ofri masad has uploaded a new change for review. Change subject: core: Fix handle quota release (#848107) .. core: Fix handle quota release (#848107) https://bugzilla.redhat.com/848107 Add a release for storage quota when a vm

  1   2   3   >