[Engine-patches] Change in ovirt-engine[master]: core: when iso domain is inactive we still go to the cache

2012-08-11 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: when iso domain is inactive we still go to the cache .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) Basically looks g

[Engine-patches] Change in ovirt-engine[master]: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCom...

2012-08-11 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCommand (#840838) .. Patch Set 7: I would prefer that you didn't submit this (11 inline comments) See

[Engine-patches] Change in ovirt-engine[master]: core: simplify 'is null' sql expression

2012-08-11 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: simplify 'is null' sql expression .. Patch Set 5: Looks good to me, but someone else must approve I agree with this change. No database I know (Oracle, MS

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 4: Build Started http://jenkins.ovirt.info/job/patch_engine_manager/20/ -- To v

[Engine-patches] Change in ovirt-engine[master]: utils: ssh public key entry should contain new line

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: ssh public key entry should contain new line .. Patch Set 4: Build Started http://jenkins.ovirt.info/job/patch_engine_manager/17/ -- To view, v

[Engine-patches] [oVirt Jenkins Testing] patch_engine_create_rpms - Build # 3 - Fixed!

2012-08-11 Thread Jenkins testing Server
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/ Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/3/ Build Number: 3 Build Status: Fixed Triggered By: Started by upstream project "patch_engine_manager" build number 11 - Changes Sin

[Engine-patches] [oVirt Jenkins Testing] patch_engine_create_rpms - Build # 2 - Still Failing!

2012-08-11 Thread Jenkins testing Server
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/ Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/2/ Build Number: 2 Build Status: Still Failing Triggered By: Started by upstream project "patch_engine_manager" build number 10 - Cha

[Engine-patches] [oVirt Jenkins Testing] patch_engine_create_rpms - Build # 1 - Failure!

2012-08-11 Thread Jenkins testing Server
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/ Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/1/ Build Number: 1 Build Status: Failure Triggered By: Started by upstream project "patch_engine_manager" build number 9 - Changes Si

[Engine-patches] Change in ovirt-engine[master]: pki: remove the need to store ssh public key

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: remove the need to store ssh public key .. Patch Set 10: Verified -- To view, visit http://gerrit.ovirt.org/4853 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: pki: remove the need to store ssh public key

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: remove the need to store ssh public key .. Patch Set 10: Rebased on [1], so we won't need to merge and remerge. [1] http://gerrit.ovirt.org/#/c/7027 add ne

[Engine-patches] Change in ovirt-engine[master]: utils: ssh public key entry should contain new line

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh public key entry should contain new line .. Patch Set 4: Rebased on master. -- To view, visit http://gerrit.ovirt.org/7027 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Use BLOB servlet to serve .iso files (#840356)

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: Use BLOB servlet to serve .iso files (#840356) .. Patch Set 4: Notice, [1] was merged, can be tested against master. This change may be abandoned. [1] htt

[Engine-patches] Change in ovirt-engine[master]: utils: ssh public key entry should contain new line

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh public key entry should contain new line .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7027 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/7068 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: pki: remove the need to store ssh public key

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: remove the need to store ssh public key .. Patch Set 9: Juan, Doron? I would like to get this merged too... any comments? -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fixing vlan capitalization (#821456)

2012-08-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: webadmin: Fixing vlan capitalization (#821456) .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6975 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7068 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7068 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Cred...

2012-08-11 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Credentials .. cleanup: remove org.ovirt.engine.core.utils.hostinstall.Credentials Used interna

[Engine-patches] Change in ovirt-engine[master]: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Cred...

2012-08-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Credentials .. Patch Set 12: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: bootstrap: new implementation for apache-sshd usage

2012-08-11 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: bootstrap: new implementation for apache-sshd usage .. bootstrap: new implementation for apache-sshd usage Major changes: 1. Do not use temporary fil

[Engine-patches] Change in ovirt-engine[master]: bootstrap: new implementation for apache-sshd usage

2012-08-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: bootstrap: new implementation for apache-sshd usage .. Patch Set 15: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6722 To unsub

[Engine-patches] Change in ovirt-engine[master]: cleanup: VdsInstaller* methods name compliance

2012-08-11 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: cleanup: VdsInstaller* methods name compliance .. cleanup: VdsInstaller* methods name compliance Modify the following classes methods to meet Java stand

[Engine-patches] Change in ovirt-engine[master]: cleanup: VdsInstaller* methods name compliance

2012-08-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: cleanup: VdsInstaller* methods name compliance .. Patch Set 15: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6723 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: cleanup: remove install wrappers as there is no selection

2012-08-11 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: cleanup: remove install wrappers as there is no selection .. cleanup: remove install wrappers as there is no selection In the past there was multiple im

[Engine-patches] Change in ovirt-engine[master]: cleanup: remove install wrappers as there is no selection

2012-08-11 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: cleanup: remove install wrappers as there is no selection .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7026 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: simplify 'is null' sql expression

2012-08-11 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: simplify 'is null' sql expression .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7047 To unsubscrib