Allon Mureinik has posted comments on this change. Change subject: core: simplify 'is null' sql expression ......................................................................
Patch Set 5: Looks good to me, but someone else must approve I agree with this change. No database I know (Oracle, MS-SQL, MySQL and PostgresSQL) supports "=" for nulls, as null is not a value, it is the absence of a value. Doron - regarding empty strings - the treatment varies between database vendors. Oracle implicitly treats empty strings as nulls (i.e, select * from mytable where mystring ='' will NEVER return any results). MS-SQL and Postgresql allow empty strings, which are different than null (i.e., for these vendors, an empty string is a value of zero length. NULL is the lack of a value). I don't think we should give any special support for this in the search mechanism - let's disallow empty values on insertion and keep the code as straight forward as possible. -- To view, visit http://gerrit.ovirt.org/7047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d186f0f354026086a7f7039deaca1c236cfc7be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
