Allon Mureinik has posted comments on this change.
Change subject: core: when iso domain is inactive we still go to the cache
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Basically looks good, see one inline comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
Line 43: } else if
((VmRunHandler.getInstance().findActiveISODomain(getVm().getstorage_pool_id())
== null) && !StringUtils.isEmpty(mCdImagePath)) {
This seems like nothing but a formatting change.
If I'm missing somethign - please elaboarte.
If not - please save it for a different patch. This patchset is large enough
as-is, and will be a pain to cherry-pick if required.
--
To view, visit http://gerrit.ovirt.org/5184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d24c94c4dd630c5a76ae1fee65bee257b5e40f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
