Moti Asayag has posted comments on this change.
Change subject: core: Do Not Allow Same Mac Address (#845837)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6911
To unsubscribe, visit http:
Muli Salem has posted comments on this change.
Change subject: core: Reloadable AutoRecoveryAllowedTypes config
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6918
To unsubscribe, visit htt
Allon Mureinik has posted comments on this change.
Change subject: core: Reloadable AutoRecoveryAllowedTypes config
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6918
To unsubscribe, visit http://gerrit.ovi
Muli Salem has posted comments on this change.
Change subject: core: Do Not Allow Same Mac Address (#845837)
..
Patch Set 1: (1 inline comment)
Fixed according to masayag's comment.
Allon Mureinik has posted comments on this change.
Change subject: core: Align AutoRecoveryAllowedTypes conf defaults
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6917
To unsubscribe, visit http://gerrit.o
Allon Mureinik has uploaded a new change for review.
Change subject: core: Reloadable AutoRecoveryAllowedTypes config
..
core: Reloadable AutoRecoveryAllowedTypes config
Flagged the AutoRecoveryAllowedTypes config value as Reloa
Allon Mureinik has uploaded a new change for review.
Change subject: core: Align AutoRecoveryAllowedTypes conf defaults
..
core: Align AutoRecoveryAllowedTypes conf defaults
Aligned the defaults specified for the AutoRecoveryAll
Selvasundaram has posted comments on this change.
Change subject: engine: Move Gluster host
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules/bll/src/main/java
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 5: Verified
Addressed laravort's comments I agreed with (this patchset), and answered those
I don't (inlin
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 4: (4 inline comments)
File
backend/manager/modules/b
Allon Mureinik has posted comments on this change.
Change subject: core : correct message when suspend vm witout image
disks(#841504)
..
Patch Set 4: I would prefer that you didn't submit this
(4 inline comments)
See inline.
Allon Mureinik has posted comments on this change.
Change subject: core: HibernateVmCommand- simplified canDoAction() method
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: VmTemplateConditionFieldAutoCompleter cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
Looks good.
Might be nice to extract all tho
Allon Mureinik has posted comments on this change.
Change subject: core: minor SearchQuery cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6885
To unsubscribe, v
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2074/
Build Number: 2074
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,652,
Started by upstream project "ovirt_engine"
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2073/
Build Number: 2073
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,651
-
Chan
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2043/
Build Number: 2043
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 2,654
-
Chang
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Add DirectLUN dialog - single selection
..
webadmin: Add DirectLUN dialog - single selection
https://bugzilla.redhat.com/834240
Add DirectLUN d
Daniel Erez has posted comments on this change.
Change subject: webadmin: Add DirectLUN dialog - single selection
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6906
To u
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adding warnings to disk removal dialog
..
webadmin: adding warnings to disk removal dialog
https://bugzilla.redhat.com/819277
https://bugzilla.r
Daniel Erez has posted comments on this change.
Change subject: webadmin: adding warnings to disk removal dialog
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6905
To un
Moti Asayag has posted comments on this change.
Change subject: core: Do Not Allow Same Mac Address (#xx Waiting for BZ)
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: non vm networks in template-vnic dialog (add and edit)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6897
To uns
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add sync network to setup networks
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6809
To unsubscribe, visit http
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: no error messages after jboss restart (#842112)
..
webadmin: no error messages after jboss restart (#842112)
https://bugzilla.redhat.com/842112
when
Muli Salem has uploaded a new change for review.
Change subject: core: Do Not Allow Same Mac Address (#xx Waiting for BZ)
..
core: Do Not Allow Same Mac Address (#xx Waiting for BZ)
https://bugzilla.redhat.com/XX
Th
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2042/
Build Number: 2042
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 2,653
-
Changes Sin
ofri masad has posted comments on this change.
Change subject: webadmin: Bad formatting in dialog (#835404)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6910
To unsubscribe, visit http://gerrit.ovirt.org/s
ofri masad has uploaded a new change for review.
Change subject: webadmin: Bad formatting in dialog (#835404)
..
webadmin: Bad formatting in dialog (#835404)
https://bugzilla.redhat.com/835404
When the user trys to "Configure l
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add DirectLUN dialog - single selection
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6906
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: adding warnings to disk removal dialog
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6905
To unsubscribe, visit
Muli Salem has submitted this change and it was merged.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
..
core: Preventing two Network Interfaces with same IP (#839199)
https://bugzilla.redhat.co
Muli Salem has posted comments on this change.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6695
T
Michael Kublin has submitted this change and it was merged.
Change subject: core: Improve AutoRecoveryManagerTest
..
core: Improve AutoRecoveryManagerTest
Before this patch, the test ran the OnTime() method and checked that no
Michael Kublin has submitted this change and it was merged.
Change subject: core: Configuration to Enable/Disable Autorecovery
..
core: Configuration to Enable/Disable Autorecovery
Added configuration to enable/disable autoreco
Michael Kublin has posted comments on this change.
Change subject: core: Improve AutoRecoveryManagerTest
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6864
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Configuration to Enable/Disable Autorecovery
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6865
To unsubs
Michael Pasternak has posted comments on this change.
Change subject: restapi: RSDL - Bad Params Exposed for add/update Host-NIC
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6111
To unsub
Moti Asayag has posted comments on this change.
Change subject: engine: Add filling "managed" for network details (#838300)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6908
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: core: Improve AutoRecoveryManagerTest
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6864
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Configuration to Enable/Disable Autorecovery
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6865
To unsubs
Moti Asayag has posted comments on this change.
Change subject: core: Add "managed" to network details (#838300)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6907
To
Moti Asayag has posted comments on this change.
Change subject: core: Add "managed" to network details (#838300)
..
Patch Set 1: (1 inline comment)
File
backend/manager/modu
Muli Salem has submitted this change and it was merged.
Change subject: core: Unrequired Network Causes Non-operational (#844739)
..
core: Unrequired Network Causes Non-operational (#844739)
https://bugzilla.redhat.com/844739
Muli Salem has posted comments on this change.
Change subject: core: Unrequired Network Causes Non-operational (#844739)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6902
To uns
Moti Asayag has posted comments on this change.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6695
To unsubsc
Ori Liel has posted comments on this change.
Change subject: restapi: RSDL - Bad Params Exposed for add/update Host-NIC
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6111
To unsu
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Add "managed" to network details (#838300)
..
core: Add "managed" to network details (#838300)
https://bugzilla.redhat.com/838300
This field indicates if
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add filling "managed" for network details (#838300)
..
engine: Add filling "managed" for network details (#838300)
https://bugzilla.redhat.com/838300
A
Michael Kublin has posted comments on this change.
Change subject: core: Disable storage autorecovery (#845294)
..
Patch Set 1: No score
Please change commit message and change default for true
--
To view, visit http://gerrit.
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Add DirectLUN dialog - single selection
..
webadmin: Add DirectLUN dialog - single selection
https://bugzilla.redhat.com/834240
Add DirectLUN disk dial
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: adding warnings to disk removal dialog
..
webadmin: adding warnings to disk removal dialog
https://bugzilla.redhat.com/819277
https://bugzilla.redhat.co
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Fix NPE in SetupNetworksHelper (#842324)
..
engine: Fix NPE in SetupNetworksHelper (#842324)
https://bugzilla.redhat.com/842324
The method had
Mike Kolesnik has posted comments on this change.
Change subject: engine: Fix NPE in SetupNetworksHelper (#842324)
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no changes since ack by masayag
--
To view, visit
Livnat Peer has posted comments on this change.
Change subject: core: Unrequired Network Causes Non-operational (#844739)
..
Patch Set 1: Looks good to me, approved
next time it would be better to separate re-factoring and bug
Omer Frenkel has posted comments on this change.
Change subject: engine: Move Gluster host
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules/bll/src/main/java/
Muli Salem has posted comments on this change.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/6695
To unsubscribe, visit http://
Muli Salem has posted comments on this change.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
..
Patch Set 3: (5 inline comments)
File
backen
Muli Salem has posted comments on this change.
Change subject: core: Unrequired Network Causes Non-operational (#844739)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6902
To unsubscribe, visit http://gerri
Michael Kublin has posted comments on this change.
Change subject: core: Disable storage autorecovery (#845294)
..
Patch Set 1: I would prefer that you didn't submit this
The bug should be solved differently
--
To view, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin:Quota log messages with UNKNOWN (#844646)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6896
Muli Salem has uploaded a new change for review.
Change subject: core: Unrequired Network Causes Non-operational (#844739)
..
core: Unrequired Network Causes Non-operational (#844739)
https://bugzilla.redhat.com/844739
This pat
ofri masad has posted comments on this change.
Change subject: webadmin:Quota log messages with UNKNOWN (#844646)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6896
To unsubscribe, visit http://gerrit.ovirt
Moti Asayag has posted comments on this change.
Change subject: engine: Fix NPE in SetupNetworksHelper (#842324)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6895
To unsubscribe, visit ht
Allon Mureinik has abandoned this change.
Change subject: core: Don't select SPM on unreachable SD (#821634)
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/6898
To unsubscribe, visit http://gerrit.ovirt.org
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: added snapshot id to attached disk (#834004)
..
core: added snapshot id to attached disk (#834004)
https://bugzilla.redhat.com/834004
when attachi
Maor Lipchuk has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5718
To unsubsc
Maor Lipchuk has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5718
To unsubsc
Doron Fediuck has submitted this change and it was merged.
Change subject: bootstrap: cleanup command used to gather node id
..
bootstrap: cleanup command used to gather node id
1. There is no apparent reason to encapsulate wit
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: cleanup command used to gather node id
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6720
To unsubsc
Doron Fediuck has submitted this change and it was merged.
Change subject: cleanup: rename CBCInstaller->OVirtInstaller
..
cleanup: rename CBCInstaller->OVirtInstaller
Better name for this class implementation.
Change-Id: Ic63
Doron Fediuck has posted comments on this change.
Change subject: cleanup: rename CBCInstaller->OVirtInstaller
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6773
To unsubscribe,
Doron Fediuck has submitted this change and it was merged.
Change subject: cleanup: rename OVirtInstaller->OVirtUpgrader
..
cleanup: rename OVirtInstaller->OVirtUpgrader
Better name for this class implementation.
Change-Id: I8
Doron Fediuck has posted comments on this change.
Change subject: cleanup: rename OVirtInstaller->OVirtUpgrader
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6772
To unsubscribe,
Doron Fediuck has posted comments on this change.
Change subject: cleanup: rename OVirtInstaller->OVirtUpgrader
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6772
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5718
To unsubsc
Einav Cohen has posted comments on this change.
Change subject: webadmin: Make call to backend "more" async (#840388)
..
Patch Set 1: (1 inline comment)
see my inline comment.
..
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: Make call to backend "more" async (#840388)
..
webadmin: Make call to backend "more" async (#840388)
Change-Id: I12a0b708e61d21b2a6276620d7350e626eb12fd
Allon Mureinik has uploaded a new change for review.
Change subject: core: Don't select SPM on unreachable SD (#821634)
..
core: Don't select SPM on unreachable SD (#821634)
https://bugzilla.redhat.com/821634
Align the treatmen
Maor Lipchuk has posted comments on this change.
Change subject: core: Improve AutoRecoveryManagerTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6864
To unsubscribe, visit http://gerri
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add missing Expect header to vm add()
..
restapi: add missing Expect header to vm add()
Change-Id: Ie6b3ed58d824be905a196c7715a9fc29cec
Michael Pasternak has posted comments on this change.
Change subject: restapi: add missing Expect header to vm add()
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6892
To unsubsc
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: non vm networks in template-vnic dialog (add and edit)
..
webadmin: non vm networks in template-vnic dialog (add and edit)
https://bugzilla.redhat.com/
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2035/
Build Number: 2035
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,644
-
Changes Since
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: updated setup.py
..
cli: updated setup.py
Change-Id: Iecfb23295ef8bd00fe24723a6de9ef756350deb1
Signed-off-by: Michael Pasternak
---
M AUTHORS
Michael Pasternak has posted comments on this change.
Change subject: cli: updated setup.py
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6894
To unsubscribe, visit http://gerrit
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 3.1.0.5
..
sdk: release 3.1.0.5
Change-Id: I70d69f5165ca09e7bd3d60a92c3f2b0647c893cf
Signed-off-by: Michael Pasternak
---
M Makefile
M
Michael Pasternak has posted comments on this change.
Change subject: sdk: release 3.1.0.5
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6891
To unsubscribe, visit http://gerrit.
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: rebase to latest api
..
sdk: rebase to latest api
- added custom_configuration flag in host NIC
- added override_configuration flag in setupnet
Michael Pasternak has posted comments on this change.
Change subject: sdk: rebase to latest api
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6890
To unsubscribe, visit http://ge
Gilad Chaplik has posted comments on this change.
Change subject: webadmin:Quota log messages with UNKNOWN (#844646)
..
Patch Set 1: (1 inline comment)
change component to backend.
.
Michael Pasternak has posted comments on this change.
Change subject: codegen: support hyphen in http header name
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6889
To unsubscrib
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: support hyphen in http header name
..
codegen: support hyphen in http header name
hyphen is not permmited as part of the method arg in pyth
Ori Liel has posted comments on this change.
Change subject: cli: updated setup.py
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6894
To unsubscribe, visit http://gerr
Ori Liel has posted comments on this change.
Change subject: restapi: add missing Expect header to vm add()
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6892
To unsub
Ori Liel has posted comments on this change.
Change subject: sdk: release 3.1.0.5
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6891
To unsubscribe, visit http://gerri
Ori Liel has posted comments on this change.
Change subject: sdk: rebase to latest api
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6890
To unsubscribe, visit http://
Ori Liel has posted comments on this change.
Change subject: codegen: support hyphen in http header name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6889
To unsubscr
ofri masad has posted comments on this change.
Change subject: webadmin:Quota log messages with UNKNOWN (#844646)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6896
To unsubscribe, visit http://gerrit.ovirt
ofri masad has uploaded a new change for review.
Change subject: webadmin:Quota log messages with UNKNOWN (#844646)
..
webadmin:Quota log messages with UNKNOWN (#844646)
https://bugzilla.redhat.com/844646
creating, removing and
1 - 100 of 145 matches
Mail list logo
