Muli Salem has posted comments on this change.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/NoRepetitiveStaticIpInList.java
Line 20: */
Done
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraintTest.java
Line 25: @Test
Done
Line 26: public void twoNetworksSameIpTest() {
Done
Line 67: private <T> void validateAndAssertResult(List<VdsNetworkInterface>
listOfInterfaces, boolean isValid) {
Done
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 570: VALIDATION.REPETITIVE.IP.IN.VDS=Invalid list of interfaces, two
network interfaces have the same IP.
Done
--
To view, visit http://gerrit.ovirt.org/6695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I879959b49c7b8160bd2c7bb66284bb40d284011a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
