Maor Lipchuk has posted comments on this change.
Change subject: core:Replace vm id with number of vms in views.
..
Patch Set 2:
Changes from last patch sent:
1. Created a seperated view (Allon's comment)
2. Removed vm_guid (Mi
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Attach disk from VmGuideModel
..
webadmin: Attach disk from VmGuideModel
Added missing support for attaching a disk through GuideMe.
Change-Id: I31509e
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Remove redundant casting on UpdateVmDisk
..
webadmin: Remove redundant casting on UpdateVmDisk
UpdateVmDiskParameters - removed redundant casting to Dis
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Added dynamic message in the can do action message
..
Patch Set 2: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/5374
To unsubscribe, v
Oved Ourfali has posted comments on this change.
Change subject: packaging: Add key-alias to SSL connector
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5276
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 5: (1 inline comment)
File
backend/manager/m
Michael Pasternak has posted comments on this change.
Change subject: restapi: Use JBoss JACC artifact
..
Patch Set 2: Looks good to me, approved
pls. verify all works before submitting.
--
To view, visit http://gerrit.ovirt.o
Kanagaraj M has uploaded a new change for review.
Change subject: restapi: Gluster volume access control list validation added
(#831954)
..
restapi: Gluster volume access control list validation added (#831954)
https://bugzilla
Mike Kolesnik has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
..
Patch Set 3: (2 inline comments)
File
backend/m
Itamar Heim has uploaded a new change for review.
Change subject: text: change the term presented to user from ip tables to host
firewall
..
text: change the term presented to user from ip tables to host firewall
Change-Id: I96
Mike Kolesnik has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
..
Patch Set 3: I would prefer that you didn't submit this
(8 inline comments)
I put -1 because Sharad
Tal Nisan has uploaded a new change for review.
Change subject: core: Added template & pool cleanups to force remove SD
(#818091)
..
core: Added template & pool cleanups to force remove SD (#818091)
https://bugzilla.redhat.com/
Daniel Erez has uploaded a new change for review.
Change subject: core: Testing MaxBlockDiskSize validation
..
core: Testing MaxBlockDiskSize validation
Added tests for 'MaxBlockDiskSize' validation
in AddDiskToVmCommandTest.
C
Sharad Mishra has posted comments on this change.
Change subject: webadmin: use enums properly
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5356
To unsubscribe, visit
Sharad Mishra has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
..
Patch Set 3: (3 inline comments)
New to ovirt. Trying to learn by code review.
Please look at my inl
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: use enums properly
..
Patch Set 2: Looks good to me, but someone else must approve
Nice fix.
--
To view, visit http://gerrit.ovirt.org/5356
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: core: minor cleanup on RegisterVdsQuery
..
Patch Set 4: Looks good to me, approved
Looks good.
I would suggest to revisit this class , and get read of RefObject
Yair Zaslavsky has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 5: Looks good to me, approved
Miro comment = minor comment.
--
To view, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 5: (1 inline comment)
Miro comment on formatting issue, can be taken care of later.
+2 from my sid
Yair Zaslavsky has posted comments on this change.
Change subject: core: Run upgradeStoragePool on cluster compatibility change
..
Patch Set 16: (1 inline comment)
File
back
Yair Zaslavsky has posted comments on this change.
Change subject: core: Providing clear job name for
VdsNonRespondingTreatmentCommand
..
Patch Set 1: (1 inline comment)
Fil
Daniel Erez has submitted this change and it was merged.
Change subject: core: Minor cleanup on disk moving commands
..
core: Minor cleanup on disk moving commands
1. Solved some hiding issues (detected by Eclipse IDE)
2. Repla
Daniel Erez has posted comments on this change.
Change subject: core: Minor cleanup on disk moving commands
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5347
To unsubsc
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1319/
Build Number: 1319
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,732
-
Change
Yaniv Dary has posted comments on this change.
Change subject: packaging: changed setup to use the engine service
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5405
To unsubscrib
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: changed setup to use the engine service
..
packaging: changed setup to use the engine service
Change-Id: I8431e06f11f46dcb0284dcb82cfe1adba7a329
Yaniv Dary has uploaded a new change for review.
Change subject: packaging: changed setup to use the engine service
..
packaging: changed setup to use the engine service
Change-Id: I8431e06f11f46dcb0284dcb82cfe1adba7a32931
Signe
Daniel Erez has submitted this change and it was merged.
Change subject: core: Re-enable AddDiskToVmCommandTest
..
core: Re-enable AddDiskToVmCommandTest
This test was marked with @Ignore a while ago. This patch enables the
tes
Daniel Erez has posted comments on this change.
Change subject: core: Re-enable AddDiskToVmCommandTest
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5392
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: Providing clear job name for
VdsNonRespondingTreatmentCommand
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Michael Kublin has posted comments on this change.
Change subject: core: Run upgradeStoragePool on cluster compatibility change
..
Patch Set 16: I would prefer that you didn't submit this
(10 inline comments)
.
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: changed version to 3.1
..
etl: changed version to 3.1
Change-Id: I3dff7c308d2156d93235e95ae76e2546da0bf2bb
Signed-off-by: Yaniv Dary
---
M Makefile
D
Yaniv Dary has posted comments on this change.
Change subject: etl: changed version to 3.1
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5402
To unsubscribe, visit http://gerrit.
Yaniv Dary has submitted this change and it was merged.
Change subject: history: divided the views into seperate files.
..
history: divided the views into seperate files.
Views are now versioned into seperate files and ovirt en
Yaniv Dary has posted comments on this change.
Change subject: history: divided the views into seperate files.
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5401
To unsubscribe,
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Providing clear job name for
VdsNonRespondingTreatmentCommand
..
core: Providing clear job name for VdsNonRespondingTreatmentCommand
This patch provides
Eli Mesika has submitted this change and it was merged.
Change subject: core: adding column filtering white list to fixtures
..
core: adding column filtering white list to fixtures
Adding vds table column filtering white list t
Eli Mesika has posted comments on this change.
Change subject: core: adding column filtering white list to fixtures
..
Patch Set 2: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/5403
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding column filtering white list to fixtures
..
Patch Set 1: Verified
Verified by Eli
--
To view, visit http://gerrit.ovirt.org/5403
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding column filtering white list to fixtures
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5403
To unsubscribe, v
Eli Mesika has uploaded a new change for review.
Change subject: core: adding column filtering white list to fixtures
..
core: adding column filtering white list to fixtures
Adding vds table column filtering white list to fixtur
Yaniv Dary has uploaded a new change for review.
Change subject: history: divided the views into seperate files.
..
history: divided the views into seperate files.
Views are now versioned into seperate files and ovirt engine
rep
Yaniv Dary has uploaded a new change for review.
Change subject: etl: changed version to 3.1
..
etl: changed version to 3.1
Change-Id: I3dff7c308d2156d93235e95ae76e2546da0bf2bb
Signed-off-by: Yaniv Dary
---
M Makefile
D
data-w
Oved Ourfali has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 5: Looks good to me, but someone else must approve
Would have given +2, but I don't know if you thin
Michael Kublin has posted comments on this change.
Change subject: core: Add storage_format_type to Updatestorage_domain_static
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2440
To unsub
Michael Kublin has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
..
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Setup networks- edit dialogs
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5400
To unsubscribe, visit http://gerrit.ovirt.org/setti
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Setup networks- edit dialogs
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5400
To unsubscribe, visit http://gerrit.ovirt.org/setti
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Setup networks- edit dialogs
..
webadmin: Setup networks- edit dialogs
https://bugzilla.redhat.com/show_bug.cgi?id=823881
- The "edit pencil" should b
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1318/
Build Number: 1318
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,731
Shahar Havivi has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5290
To unsubscribe, visit http://ger
Oved Ourfali has posted comments on this change.
Change subject: core: using user_disk_permissions_view in get vm disks
..
Patch Set 2:
changed the implementation of the user_disk_permission_view, and based the
query to use it
Liron Aravot has posted comments on this change.
Change subject: core: minor cleanup on RegisterVdsQuery
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/5352
To unsubscribe, visit http://gerrit.ovirt.org/sett
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Add validation for not null cpu
..
core: Add validation for not null cpu
Not null cpu (for virt service upon adding a new
Cluster) should be added.
Curre
Maor Lipchuk has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
..
Patch Set 8: (1 inline comment)
File
backend/manager/mod
Eli Mesika has submitted this change and it was merged.
Change subject: core:add support for engine case-insensitive search
..
core:add support for engine case-insensitive search
Bug origin is the caching mechanism we are using
Eli Mesika has posted comments on this change.
Change subject: core:add support for engine case-insensitive search
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5393
To unsubscri
Maor Lipchuk has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5267
To
Yair Zaslavsky has posted comments on this change.
Change subject: core:add support for RHEVM case-insensitive search
..
Patch Set 1: Looks good to me, approved
Looks good.
I would suggest just to change RHEVM to engine at the
Liron Aravot has posted comments on this change.
Change subject: core: fix logging in StorageHelperDirector
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5398
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: StorageHelperDirector - change log output to debug in
case of ClassNotFoundException while looking for helper classes
..
Patch Set 2: I would prefer that
Allon Mureinik has posted comments on this change.
Change subject: core: minor cleanup on RegisterVdsQuery
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5352
To unsubs
Liron Aravot has posted comments on this change.
Change subject: core: minor cleanup on RegisterVdsQuery
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5352
To unsubscribe, visit http://gerrit.ovirt.org/sett
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1317/
Build Number: 1317
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,730
Liron Aravot has posted comments on this change.
Change subject: core: StorageHelperDirector - change log output to debug in
case of ClassNotFoundException while looking for helper classes
..
Patch Set 2: Verified
--
To view,
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Fix VmNetworkInterfaceValidationTest
..
core: Fix VmNetworkInterfaceValidationTest
Test for short MAC was failing intermittently due to wrong rand
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix VmNetworkInterfaceValidationTest
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5386
To unsubscribe, visit http:
Mike Kolesnik has posted comments on this change.
Change subject: core: Fix VmNetworkInterfaceValidationTest
..
Patch Set 2: Verified
Rebased, had to tinker a bit since for create an empty string is allowed, so
the shorter MAC
Allon Mureinik has posted comments on this change.
Change subject: core: Re-enable AddDiskToVmCommandTest
..
Patch Set 1:
disagree.
many of these methods that wrap out external resources do hide implementation
details from th
Alex Lourie has posted comments on this change.
Change subject: packaging: Block 3.1 upgrade if DC/cluster 2.2 present
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5186
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix VmNetworkInterfaceValidationTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5386
To unsubscribe, visit http:
Liron Aravot has uploaded a new change for review.
Change subject: core: StorageHelperDirector - change log output to debug in
case of ClassNotFoundException while looking for helper classes
..
core: StorageHelperDirector - chan
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1316/
Build Number: 1316
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,729
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Casting to Disk in GuideMe AddDisk
..
webadmin: Casting to Disk in GuideMe AddDisk
GetVmDiskList - Casting to Disk instead of DiskImage
(fixing
Daniel Erez has posted comments on this change.
Change subject: webadmin: Casting to Disk in GuideMe AddDisk
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5397
To unsubs
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1315/
Build Number: 1315
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,728
Michael Kublin has posted comments on this change.
Change subject: webadmin: Casting to Disk in GuideMe AddDisk
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5397
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: engine: Added dynamic message in the can do action message
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5374
To unsubscrib
Omer Frenkel has posted comments on this change.
Change subject: engine: Avoid PM/storage alerts for GlusterOnly clusters
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
..
Omer Frenkel has posted comments on this change.
Change subject: engine: Move Gluster host
..
Patch Set 2: (7 inline comments)
File
backend/manager/modules/bll/src/main/java
Maor Lipchuk has posted comments on this change.
Change subject: core: Minor cleanup on disk moving commands
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5347
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: using user_disk_permissions_view in get vm disks
..
Patch Set 1: (1 inline comment)
File backend/mana
Michael Kublin has posted comments on this change.
Change subject: core: Re-enable AddDiskToVmCommandTest
..
Patch Set 1:
I am sorry, but but introducing a test we are make our code ugly.
In order to make all tests we are repla
Daniel Erez has posted comments on this change.
Change subject: core: Re-enable AddDiskToVmCommandTest
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5392
To unsubscribe, visit ht
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1314/
Build Number: 1314
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,727
Daniel Erez has posted comments on this change.
Change subject: webadmin: Casting to Disk in GuideMe AddDisk
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5397
To unsubscribe, visit http://gerrit.ovirt.org/
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Casting to Disk in GuideMe AddDisk
..
webadmin: Casting to Disk in GuideMe AddDisk
GetVmDiskList - Casting to Disk instead of DiskImage
(fixing ClassCas
Yair Zaslavsky has posted comments on this change.
Change subject: core: version fix
..
Patch Set 25:
Itamar - correct.
What I meant is that not sure that I like is the fact RpmVersion extends
Version (I would like to have a
Daniel Erez has submitted this change and it was merged.
Change subject: engine: Fixing remove of VM with direct lun disk
..
engine: Fixing remove of VM with direct lun disk
A following patch will allow to remove a vm which has
Daniel Erez has posted comments on this change.
Change subject: engine: Fixing remove of VM with direct lun disk
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5396
To unsubscribe, visit ht
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing remove of VM with direct lun disk
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5396
To unsubscribe, visit http://gerrit.ovi
Michael Kublin has uploaded a new change for review.
Change subject: engine: Fixing remove of VM with direct lun disk
..
engine: Fixing remove of VM with direct lun disk
A following patch will allow to remove a vm which has a di
Itamar Heim has posted comments on this change.
Change subject: core: version fix
..
Patch Set 25:
Yair - versions are different than compat levels already
--
To view, visit http://gerrit.ovirt.org/4679
To unsubscribe, visit h
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1313/
Build Number: 1313
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,726
-
Chan
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: display SD status Templates-Storage
..
webadmin: display SD status Templates-Storage
https://bugzilla.redhat.com/819307
Display StorageDomainSh
Daniel Erez has posted comments on this change.
Change subject: webadmin: display SD status Templates-Storage
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5394
To unsub
Daniel Erez has posted comments on this change.
Change subject: webadmin: display SD status Templates-Storage
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5394
To unsubscribe, visit http://gerrit.ovirt.org
Oved Ourfali has uploaded a new change for review.
Change subject: core: using user_disk_permissions_view in get vm disks
..
core: using user_disk_permissions_view in get vm disks
This patch uses user_disk_permissions_view in ad
Eli Mesika has submitted this change and it was merged.
Change subject: core: user level queries - filtered entities
..
core: user level queries - filtered entities
This patch enables to filter data vertically in addition to th
Eli Mesika has posted comments on this change.
Change subject: core: user level queries - filtered entities
..
Patch Set 8: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/4469
To unsubscr
1 - 100 of 136 matches
Mail list logo
