Yair Zaslavsky has posted comments on this change. Change subject: core: version fix ......................................................................
Patch Set 25: Itamar - correct. What I meant is that not sure that I like is the fact RpmVersion extends Version (I would like to have a clear distinction that there is a class for Compatibility version issues, and class for RpmVersion issues, not sure they should be in the same class hierarchy) and the existence of VdsVersion. We need to think through. -- To view, visit http://gerrit.ovirt.org/4679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42dbe36b83c78d4ff2940b2d8b3e5ff5b0f59b19 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
