Michael Kublin has posted comments on this change. Change subject: core: Re-enable AddDiskToVmCommandTest ......................................................................
Patch Set 1: I am sorry, but but introducing a test we are make our code ugly. In order to make all tests we are replacing a one code line by method which just performing return, it is ugly and has not any reason to do. Also, please take close look to tests, they don't check anything, the only thing we are checking it is if of java, how these can help ? (I am sure the if of java works well and tested by guys from jvm) The tests should check something, the following test is worst nothing and in order to run it we are making our code ugly, correct me if I am wrong -- To view, visit http://gerrit.ovirt.org/5392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b061a6f381f4e19d6666b24140b0583a244a63d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
