Oved Ourfali has uploaded a new change for review.
Change subject: core: changing jbossas to ovirt-engine in service restart in
utlities
..
core: changing jbossas to ovirt-engine in service restart in utlities
In the new ovirt
Allon Mureinik has posted comments on this change.
Change subject: userportal: NPE when there is no Blank template
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5018
T
Tomas Jelinek has posted comments on this change.
Change subject: userportal: NPE when there is no Blank template
..
Patch Set 2:
Extracted the convert method
--
To view, visit http://gerrit.ovirt.org/5018
To unsubscribe, visi
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1045/
Build Number: 1045
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,417
-
Changes
Allon Mureinik has posted comments on this change.
Change subject: core:Use appropriate message for plural VMS.
..
Patch Set 1: (6 inline comments)
File backend/manager/modul
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: RunMultipleAction - execution status checks removed
..
webadmin: RunMultipleAction - execution status checks removed
In case of RunMutipleAction, the ex
Allon Mureinik has posted comments on this change.
Change subject: userportal: NPE when there is no Blank template
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/
Allon Mureinik has posted comments on this change.
Change subject: [WIP] core: Use the hostSpmId during reconstructMaster
..
Patch Set 1: Looks good to me, but someone else must approve
there is not much code here, just delegat
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: NPE when there is no Blank template
..
userportal: NPE when there is no Blank template
The problem was, that the it was expected, that
there has to
Hello Omer Frenkel,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/5017
to review the following change.
Change subject: core: store the create time of a vm under
vm_dynamic.vm_last_boot_time
..
co
Michael Pasternak has submitted this change and it was merged.
Change subject: resstapi: Fix missing "actions" under vm nics
..
resstapi: Fix missing "actions" under vm nics
Change-Id: I3b2b0506351d7cbafcd3ee4de6a478c26a6b5caa
Michael Pasternak has posted comments on this change.
Change subject: resstapi: Fix missing "actions" under vm nics
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5011
To unsubscr
Shireesh Anjal has uploaded a new change for review.
Change subject: restapi: Update only cluster id in addParents
..
restapi: Update only cluster id in addParents
Modified BackendGlusterVolumesResource#addParents to update
only
Shireesh Anjal has posted comments on this change.
Change subject: engine: Adding brick order to Gluster volume bricks
..
Patch Set 5: (5 inline comments)
Few comments inline.
..
Itamar Heim has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 5: (1 inline comment)
File backend/manager/dbscripts/upgrade/pre_up
Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix for GUI should check for volume name uniqueness
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1044/
Build Number: 1044
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,416
-
Changes
Shireesh Anjal has posted comments on this change.
Change subject: engine: Changed string "host" to "server" in gluster related
messages
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://
Shireesh Anjal has posted comments on this change.
Change subject: engine: canDoAction for No up server found validation added
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Roy Golan has posted comments on this change.
Change subject: resstapi: Fix missing "actions" under vm nics
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5011
To unsub
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Gluster Volume - Summary tab changes, localization
..
webadmin: Gluster Volume - Summary tab changes, localization
Volume type in summary sub tab is loc
Shireesh Anjal has posted comments on this change.
Change subject: engine,webadmin: RunMultipleAction - execution and error
handling
..
Patch Set 1:
The use case here was that user may select one or more rows from the table an
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1043/
Build Number: 1043
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,415
-
Changes
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1042/
Build Number: 1042
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,414
-
Changes
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1041/
Build Number: 1041
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,413
-
Changes
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1040/
Build Number: 1040
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,412
-
Changes
Daniel Erez has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 5: (4 inline comments)
File backend/manager/dbscripts/upgrade/pre_u
Eli Mesika has posted comments on this change.
Change subject: restapi: Add Vm Ballooning Support
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5013
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Eli Mesika has posted comments on this change.
Change subject: core: add memory balloon device support
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/4993
To unsubscribe, visit http://gerrit.ovirt.org/settin
Eli Mesika has uploaded a new change for review.
Change subject: restapi: Add Vm Ballooning Support
..
restapi: Add Vm Ballooning Support
REST API implementation for balloon device support.
Change-Id: I50ae28e645c7236dbf0f1dad5
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1039/
Build Number: 1039
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,411
-
Changes
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1038/
Build Number: 1038
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,410
-
Changes
Ayal Baron has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 5: I would prefer that you didn't submit this
(5 inline comments)
F
Michael Pasternak has uploaded a new change for review.
Change subject: resstapi: Fix missing "actions" under vm nics
..
resstapi: Fix missing "actions" under vm nics
Change-Id: I3b2b0506351d7cbafcd3ee4de6a478c26a6b5caa
Signed-o
Ayal Baron has posted comments on this change.
Change subject: core: Clean storage server connections on storage removal
..
Patch Set 2: Looks good to me, but someone else must approve
Assuming StorageDomainRemoved is really ca
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1037/
Build Number: 1037
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,409
-
Changes
Allon Mureinik has posted comments on this change.
Change subject: core: Clean storage server connections on storage removal
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Moti Asayag has posted comments on this change.
Change subject: core: ConfigurationValues Shareable and DirectLUN
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5009
To unsubscribe, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: Clean storage server connections on storage removal
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
small style issue.
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1036/
Build Number: 1036
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,407,
Started by upstream project "ovirt_engine" b
Omer Frenkel has posted comments on this change.
Change subject: engine: Reducing replica count feature in Remove brick
..
Patch Set 2: (1 inline comment)
File
backend/manag
Allon Mureinik has posted comments on this change.
Change subject: core: Remove AsyncQuery leftovers
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove AsyncQuery leftovers
..
core: Remove AsyncQuery leftovers
AsyncQuery was removed in a previous patch
(I3734abc8a99ebcfdd8e8c8ea8c6b3a674a139f10).
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1035/
Build Number: 1035
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,405,
Started by upstream project "ovirt_engine" b
Michael Pasternak has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 1: (1 inline comment)
well done!, now you can:
1. from CodeGen (before RSDL proces
Yair Zaslavsky has abandoned this change.
Change subject: core: Unifying LdapProviderType enum
..
Patch Set 1: Abandoned
Already merged up stream
--
To view, visit http://gerrit.ovirt.org/3270
To unsubscribe, visit http://gerr
Yair Zaslavsky has abandoned this change.
Change subject: core: Changes in ldap auto detection
..
Patch Set 1: Abandoned
Not relevant anymore.
--
To view, visit http://gerrit.ovirt.org/3283
To unsubscribe, visit http://gerrit.
Daniel Erez has uploaded a new change for review.
Change subject: core: ConfigurationValues Shareable and DirectLUN
..
core: ConfigurationValues Shareable and DirectLUN
Added 'ShareableDiskEnabled' and 'DirectLUNDiskEnabled' to
Tal Nisan has uploaded a new change for review.
Change subject: core: Clean storage server connections on storage removal
..
core: Clean storage server connections on storage removal
Clean up the storage server connections from
Omer Frenkel has posted comments on this change.
Change subject: engine,webadmin: RunMultipleAction - execution and error
handling
..
Patch Set 1: I would prefer that you didn't submit this
i dont understand this change, RunMu
Oved Ourfali has posted comments on this change.
Change subject: webadmin: fix en-US locale sent to reports server to en_US
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4985
To
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock RemoveAdGroupCommandTest
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/4932
To unsubscribe, visit http://gerrit.ovirt.org
Michael Kublin has posted comments on this change.
Change subject: core: Add query for getting storages by image id
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3479
To unsubscribe, visit
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1034/
Build Number: 1034
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,403,
Started by upstream project "ovirt_engine" b
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Visual fix of Posix FS storage dialog
..
webadmin: Visual fix of Posix FS storage dialog
- Label font
- Text box width
Change-Id: Ieae1a56d3fe9
Einav Cohen has posted comments on this change.
Change subject: webadmin: Visual fix of Posix FS storage dialog
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5000
To unsubscribe,
Oved Ourfali has posted comments on this change.
Change subject: webadmin: fix en-US locale sent to Jasper to en_US
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4985
To unsubscr
Yaniv Kaul has posted comments on this change.
Change subject: packaging: Updated error for preallocated http port (#813688)
..
Patch Set 2: (1 inline comment)
File packaging
Oved Ourfali has posted comments on this change.
Change subject: webadmin: fix en-US locale sent to Jasper to en_US
..
--
To view, visit http://gerrit.ovirt.org/4985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Oved Ourfali has posted comments on this change.
Change subject: webadmin: fix en-US locale sent to Jasper to en_US
..
Patch Set 1: Looks good to me, approved
Just one question, are the locale options in the login menu have und
Alona Kaplan has posted comments on this change.
Change subject: webadmin: fix en-US locale sent to Jasper to en_US
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4985
To unsubscribe, visit http://gerrit.ovi
Michael Kublin has submitted this change and it was merged.
Change subject: core : Fixing NPE at ImagesHandle.setDiskAlias
..
core : Fixing NPE at ImagesHandle.setDiskAlias
The following patch will fix a NPE at ImagesHandle.set
Michael Kublin has posted comments on this change.
Change subject: core : Fixing NPE at ImagesHandle.setDiskAlias
..
Patch Set 2: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/5007
To un
Michael Kublin has posted comments on this change.
Change subject: core : Fixing NPE at ImagesHandle.setDiskAlias
..
--
To view, visit http://gerrit.ovirt.org/5007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Omer Frenkel has posted comments on this change.
Change subject: core: Remove ConfigMocker
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4935
To unsubscribe, visit http://gerrit.ovirt.org/
Omer Frenkel has posted comments on this change.
Change subject: core: UnPowerMock BackendTest
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4936
To unsubscribe, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: core : Fixing NPE at ImagesHandle.setDiskAlias
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5007
To unsubscribe, visit htt
Daniel Erez has submitted this change and it was merged.
Change subject: core: DirectLUNDiskEnabled configuration value
..
core: DirectLUNDiskEnabled configuration value
Added 'DirectLUNDiskEnabled' configuration value
to 'conf
Daniel Erez has posted comments on this change.
Change subject: core: DirectLUNDiskEnabled configuration value
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/4978
To unsu
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1033/
Build Number: 1033
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,402
-
Changes Since
Allon Mureinik has posted comments on this change.
Change subject: core: Stop forking JUnit tests
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/4780
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock RemoveQuotaCommandTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5003
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock UpdateVdsGroupCommandTest
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/4938
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock validator tests
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/4937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock BackendTest
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
Patch Set 5: Verified; Looks good to me, but someone els
Allon Mureinik has posted comments on this change.
Change subject: core: Remove ConfigMocker
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
Patch Set 5: Verified; Looks good to me, but someone else mu
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock Hot[Un]PlugDiskToVmCommandTest
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/4934
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock GetUserVmsByUserIdAndGroupsQueryTest
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/4933
To unsubscribe, visit http://gerr
Michael Kublin has posted comments on this change.
Change subject: core : Fixing NPE at ImagesHandle.setDiskAlias
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5007
To unsubscribe, visit http://gerrit.ovirt
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing NPE at ImagesHandle.setDiskAlias
..
core : Fixing NPE at ImagesHandle.setDiskAlias
The following patch will fix a NPE at ImagesHandle.setDiskAlia
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: fix error handling regression
..
sdk: fix error handling regression
when response.read() called - it removes body from
server response, so late
Michael Pasternak has posted comments on this change.
Change subject: sdk: fix error handling regression
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5006
To unsubscribe, visit
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: fix error handling regression
..
sdk: fix error handling regression
when response.read() called - it removes body from
server response, so later when R
Allon Mureinik has posted comments on this change.
Change subject: core: Remove BaseMockitoTest
..
Patch Set 6: Looks good to me, but someone else must approve
Patch Set 5: Verified; Looks good to me, but someone else must appr
Allon Mureinik has posted comments on this change.
Change subject: core: Remove BaseMockitoTest
..
Patch Set 6: Verified
Patch Set 5: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock GetoVirtISOsTest
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/4930
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has uploaded a new change for review.
Change subject: core: UnPowerMock RemoveQuotaCommandTest
..
core: UnPowerMock RemoveQuotaCommandTest
Removed PowerMock dependency and replaced it with spying the command.
Cha
Yaniv Dary has uploaded a new change for review.
Change subject: history: removed vm disk internal drive mapping
..
history: removed vm disk internal drive mapping
Change-Id: I977871555c592d1531a0f8687a758f0abb272df9
Signed-off-
Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 5: (1 inline comment)
There's a bug in your DAO - please fix it (see inline).
Also, adding tests for the DAO is impo
Daniel Erez has posted comments on this change.
Change subject: restapi: Grayed-Out LUNs Support
..
Patch Set 6: Verified; Looks good to me, approved
rebased, already approved by Michael Pasternak
--
To view, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: core: report properly RunVmOnce task completion (#818165)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Oved Ourfali has submitted this change and it was merged.
Change subject: core: changing jboss-as to jbossas in service restart in
utlities
..
core: changing jboss-as to jbossas in service restart in utlities
In the new jboss
Oved Ourfali has posted comments on this change.
Change subject: core: changing jboss-as to jbossas in service restart in
utlities
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5001
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: core: changing jboss-as to jbossas in service restart in
utlities
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5001
To
Oved Ourfali has uploaded a new change for review.
Change subject: core: changing jboss-as to jbossas in service restart in
utlities
..
core: changing jboss-as to jbossas in service restart in utlities
In the new jboss version,
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: Visual fix of Posix FS storage dialog
..
webadmin: Visual fix of Posix FS storage dialog
- Label font
- Text box width
Change-Id: Ieae1a56d3fe96e7cf660
Roy Golan has abandoned this change.
Change subject: core: report completed runVmOnce command
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/4991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Advanced NFS options
..
webadmin: Advanced NFS options
New options in NfsStorageView:
* NFS Version
* Retransmissions
* Timeout
* Mount Options
Einav Cohen has posted comments on this change.
Change subject: webadmin: Advanced NFS options
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4921
To unsubscribe, visit http://ger
Yaniv Dary has uploaded a new change for review.
Change subject: report: changed datasource defaults
..
report: changed datasource defaults
Change-Id: I0f3b0be29d3c21580091f5042eee27b82355881d
Signed-off-by: Yaniv Dary
---
M
r
1 - 100 of 231 matches
Mail list logo
