Allon Mureinik has posted comments on this change. Change subject: core:Use appropriate message for plural VMS. ......................................................................
Patch Set 1: (6 inline comments) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 141: ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL=Cannot ${action} ${type}. The VM status is illegal. "is in status is illegal" -> "is in illegal status" .................................................... File backend/manager/modules/utils/src/test/resources/AppErrors.properties Line 104: ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL=Cannot ${action} ${type}. The VM status is illegal. "is in status is illegal" -> "is in illegal status" .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java Line 347: "is in status is illegal" -> "is in illegal status" .................................................... File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 139: ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL=Cannot ${action} ${type}. The VM status is illegal. "is in status is illegal" -> "is in illegal status" .................................................... File frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 116: ACTION_TYPE_FAILED_ONE_OUT_OF_MULTIPLE_VMS_IS_IN_STATUS_ILLEGAL=Cannot ${action} ${type}. At least one of The VMs is in status is illegal. "is in status is illegal" -> "is in illegal status" .................................................... File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 138: ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL=Cannot ${action} ${type}. The VM status is illegal. "is in status is illegal" -> "is in illegal status" -- To view, visit http://gerrit.ovirt.org/4792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18f8e88d419a2052e2a2bd8a64aac098c6284f5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches