[Engine-patches] Change in ovirt-engine[master]: engine: New query to fetch brick by id

2012-05-28 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: engine: New query to fetch brick by id .. Patch Set 2: Looks good to me, approved for the api change -- To view, visit http://gerrit.ovirt.org/4783 To unsub

[Engine-patches] Change in ovirt-engine[master]: restapi: Cluster schema changes

2012-05-28 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Cluster schema changes .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4824 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: restapi: Gluster Brick resource implementation

2012-05-28 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Gluster Brick resource implementation .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4786 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Fix bridgless network recognition

2012-05-28 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix bridgless network recognition .. core: Fix bridgless network recognition Bridgeless network was not recognized as part of GetVdsCapabilities c

[Engine-patches] Change in ovirt-engine[master]: core: Fix bridgless network recognition

2012-05-28 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix bridgless network recognition .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4843 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: Change validation groups to inherit default

2012-05-28 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Change validation groups to inherit default .. -- To view, visit http://gerrit.ovirt.org/4374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-M

[Engine-patches] Change in ovirt-engine[master]: webadmin: Gluster Volume - Replace brick implementation

2012-05-28 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: Gluster Volume - Replace brick implementation .. Patch Set 5: Verified Rebase and verified. -- To view, visit http://gerrit.ovirt.org/4546 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Fix bridgless network recognition

2012-05-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Fix bridgless network recognition .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4843 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: Change validation groups to inherit default

2012-05-28 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Change validation groups to inherit default .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4374 To unsubscribe, visit htt

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 940 - Unstable!

2012-05-28 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/940/ Build Number: 940 Build Status: Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,337 - Changes Since

[Engine-patches] Change in ovirt-engine[master]: virt-engine: Support RHEVManager url

2012-05-28 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: virt-engine: Support RHEVManager url .. virt-engine: Support RHEVManager url Added rewrite rule from RHEVManager to OvirtEngine to support old rhev-h on ovi

[Engine-patches] Change in ovirt-engine[master]: virt-engine: Support RHEVManager url

2012-05-28 Thread rgolan
Roy Golan has posted comments on this change. Change subject: virt-engine: Support RHEVManager url .. Patch Set 14: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1120 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor LdapProviderType and LdapVendorNameEnum

2012-05-28 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4727 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: Use ping verb to check connectivity with host

2012-05-28 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Use ping verb to check connectivity with host .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4830 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Grayed-Out LUNs Support

2012-05-28 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: Grayed-Out LUNs Support .. Patch Set 1: (1 inline comment) File backend/manager/modules/bll/src/main/jav

[Engine-patches] Change in ovirt-engine[master]: core: Return 1 from StoreUtils on error

2012-05-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Return 1 from StoreUtils on error .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4848 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: Grayed-Out LUNs Support

2012-05-28 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: core: Grayed-Out LUNs Support .. core: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out (disabled) LUNs: * Added 'isPartitioned'

[Engine-patches] Change in ovirt-engine[master]: restapi: Grayed-Out LUNs Support

2012-05-28 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: restapi: Grayed-Out LUNs Support .. restapi: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out (disabled) LUNs: * Added 'partition

[Engine-patches] Change in ovirt-engine[master]: webadmin: Grayed-Out LUNs Support

2012-05-28 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: Grayed-Out LUNs Support .. webadmin: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out/Disabled LUNs (LUNS that are not

[Engine-patches] Change in ovirt-engine[master]: webadmin: LOCALFS storage path regex validation.

2012-05-28 Thread apahim
Amador Pahim has abandoned this change. Change subject: webadmin: LOCALFS storage path regex validation. .. Patch Set 1: Restored -- To view, visit http://gerrit.ovirt.org/4857 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: webadmin: LOCALFS storage path regex validation.

2012-05-28 Thread apahim
Amador Pahim has abandoned this change. Change subject: webadmin: LOCALFS storage path regex validation. .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/4857 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: webadmin: LOCALFS storage path regex validation.

2012-05-28 Thread apahim
Amador Pahim has uploaded a new change for review. Change subject: webadmin: LOCALFS storage path regex validation. .. webadmin: LOCALFS storage path regex validation. LOCALFS storage path is not validated with regex in frontend

[Engine-patches] Change in ovirt-engine[master]: restapi: Support Correlation Id

2012-05-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: restapi: Support Correlation Id .. Patch Set 1: Please note that upon illegal value for the correlation-ID, the command will be failed. See definition of the cor

[Engine-patches] Change in ovirt-engine[master]: core: Added GetManagementInterfaceAddressByVdsId query

2012-05-28 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Added GetManagementInterfaceAddressByVdsId query .. Patch Set 1: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: webadmin: oVirt Modes - hide DC in GlusterOnly

2012-05-28 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: oVirt Modes - hide DC in GlusterOnly .. webadmin: oVirt Modes - hide DC in GlusterOnly Data Center list box in cluster, host, volume dialogs will be hid

[Engine-patches] Change in ovirt-engine[master]: core: Added GetManagementInterfaceAddressByVdsId query

2012-05-28 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Added GetManagementInterfaceAddressByVdsId query .. core: Added GetManagementInterfaceAddressByVdsId query Added a query to retrieve a host management interfa

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set Spice & VNC console models to use different qu...

2012-05-28 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: webadmin: Set Spice & VNC console models to use different query .. webadmin: Set Spice & VNC console models to use different query Spice & VNC models used get GetVd

[Engine-patches] Change in ovirt-engine[master]: core : Removing of using internal drive mapping at all vm sc...

2012-05-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: core : Removing of using internal drive mapping at all vm scenarious .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: ActionGroup filter by AppMode

2012-05-28 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: ActionGroup filter by AppMode .. webadmin: ActionGroup filter by AppMode filtering action groups in new role according to its supported applic

[Engine-patches] Change in ovirt-engine[master]: webadmin: ActionGroup filter by AppMode

2012-05-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: ActionGroup filter by AppMode .. Patch Set 2: Verified; Looks good to me, approved rebased & verified -- To view, visit http://gerrit.ovirt.org/4852 T

[Engine-patches] Change in ovirt-engine[master]: core: [CpuPinning] db support for cpu_pinning

2012-05-28 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: [CpuPinning] db support for cpu_pinning .. Patch Set 7: I would prefer that you didn't submit this (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: webadmin: format code

2012-05-28 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: format code .. webadmin: format code format the code of the action group tree no code change Change-Id: Id659555e8022c3a84483444fab944182df76

[Engine-patches] Change in ovirt-engine[master]: webadmin: format code

2012-05-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: format code .. Patch Set 2: Verified; Looks good to me, approved rebased & verified -- To view, visit http://gerrit.ovirt.org/4851 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Support Appliction Mode for ActionGroup

2012-05-28 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: core: Support Appliction Mode for ActionGroup .. core: Support Appliction Mode for ActionGroup Adding property to action group, that indicates in which

[Engine-patches] Change in ovirt-engine[master]: core: Support Appliction Mode for ActionGroup

2012-05-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: Support Appliction Mode for ActionGroup .. Patch Set 2: Verified; Looks good to me, approved rebased & verified -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: ActionGroup filter by AppMode

2012-05-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: ActionGroup filter by AppMode .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4852 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: format code

2012-05-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: format code .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4851 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: core : Last patch for removing internal_drive_mappings

2012-05-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: core : Last patch for removing internal_drive_mappings .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/48

[Engine-patches] Change in ovirt-engine[master]: core : Last patch for removing internal_drive_mappings

2012-05-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Last patch for removing internal_drive_mappings .. Patch Set 1: Looks good to me, but someone else must approve engine part looks good. Now that you remo

[Engine-patches] Change in ovirt-engine[master]: core: Support Appliction Mode for ActionGroup

2012-05-28 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Support Appliction Mode for ActionGroup .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4849 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: packaging: DO NOT MERGE: Moving Jboss configuration functio...

2012-05-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: DO NOT MERGE: Moving Jboss configuration functions to separate module .. Patch Set 1: Looks good to me, but someone else must approve -- To view, v

[Engine-patches] Change in ovirt-engine[master]: core : Removing internal_drive_mappings - db scripts

2012-05-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Removing internal_drive_mappings - db scripts .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4846 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: New validations in add/edit cluster

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: engine: New validations in add/edit cluster .. engine: New validations in add/edit cluster - At least one service (virt/gluster) must be enabled - Cannot

[Engine-patches] Change in ovirt-engine[master]: engine: New validations in add/edit cluster

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: New validations in add/edit cluster .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4823 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: engine: New validations in add/edit cluster

2012-05-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: New validations in add/edit cluster .. Patch Set 2: Verified rebased. -- To view, visit http://gerrit.ovirt.org/4823 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: New validations in add/edit cluster

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: New validations in add/edit cluster .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4823 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Enable allowing view children permissions

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Enable allowing view children permissions .. core: Enable allowing view children permissions This patch changes the user permissions views so they

[Engine-patches] Change in ovirt-engine[master]: core: Update roles.allow_viewing_children properly

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Update roles.allow_viewing_children properly .. core: Update roles.allow_viewing_children properly This patch contains the logic for updating roles

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup PredifnedRoles

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Cleanup PredifnedRoles .. core: Cleanup PredifnedRoles Fixed all the Guids to use upper case notation. Change-Id: I5a16596b30e60916e80cee7cf97bbeb

[Engine-patches] Change in ovirt-engine[master]: core: Update roles.allow_viewing_children properly

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Update roles.allow_viewing_children properly .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4607 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Fix DISK CREATOR role

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix DISK CREATOR role .. core: Fix DISK CREATOR role DISK CREATOR role was mistakenly given extra action groups. This patch fixes that problems, an

[Engine-patches] Change in ovirt-engine[master]: core: VM and Template creator roles

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: VM and Template creator roles .. core: VM and Template creator roles Added two new predefined roles - VM creator and Template creator to allow admi

[Engine-patches] Change in ovirt-engine[master]: core: Enable allowing view children permissions

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Enable allowing view children permissions .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4608 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup PredifnedRoles

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Cleanup PredifnedRoles .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4615 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: VM and Template creator roles

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VM and Template creator roles .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4616 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Fix DISK CREATOR role

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Fix DISK CREATOR role .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4650 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: VM and Template creator roles

2012-05-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: VM and Template creator roles .. Patch Set 8: Also fixed ofrenkel's comments from last patchset :-) -- To view, visit http://gerrit.ovirt.org/4616 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Fix DISK CREATOR role

2012-05-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix DISK CREATOR role .. Patch Set 7: Verified rebase, renumbered upgrade script. -- To view, visit http://gerrit.ovirt.org/4650 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: VM and Template creator roles

2012-05-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: VM and Template creator roles .. Patch Set 8: Verified rebase, renumbered upgrade script. -- To view, visit http://gerrit.ovirt.org/4616 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup PredifnedRoles

2012-05-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup PredifnedRoles .. Patch Set 8: Verified rebase. -- To view, visit http://gerrit.ovirt.org/4615 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: core: Enable allowing view children permissions

2012-05-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Enable allowing view children permissions .. Patch Set 9: Verified rebase. -- To view, visit http://gerrit.ovirt.org/4608 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Update roles.allow_viewing_children properly

2012-05-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Update roles.allow_viewing_children properly .. Patch Set 9: Verified rebase, renumbered upgrade script. -- To view, visit http://gerrit.ovirt.org/4607 T

[Engine-patches] Change in ovirt-engine[master]: core: Add servlets for CA and SSH keys

2012-05-28 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Add servlets for CA and SSH keys .. core: Add servlets for CA and SSH keys Added two servlets that generate the CA certificate and SSH public key from th

[Engine-patches] Change in ovirt-engine[master]: engine: Common method to update brick server name

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: engine: Common method to update brick server name .. engine: Common method to update brick server name Moved the logic of updating server names in bricks

[Engine-patches] Change in ovirt-engine[master]: engine: Common method to update brick server name

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Common method to update brick server name .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4785 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: filter ActionGroup by Application Mode

2012-05-28 Thread gchaplik
Gilad Chaplik has abandoned this change. Change subject: webadmin: filter ActionGroup by Application Mode .. Patch Set 1: Abandoned sent in another patch: http://gerrit.ovirt.org/#change,4852 -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: webadmin: ActionGroup filter by AppMode

2012-05-28 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: ActionGroup filter by AppMode .. webadmin: ActionGroup filter by AppMode filtering action groups in new role according to its supported application mo

[Engine-patches] Change in ovirt-engine[master]: webadmin: format code

2012-05-28 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: format code .. webadmin: format code format the code of the action group tree no code change Change-Id: Id659555e8022c3a84483444fab944182df7639ea Sig

[Engine-patches] Change in ovirt-engine[master]: engine: Common method to update brick server name

2012-05-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Common method to update brick server name .. Patch Set 4: Verified Incorporated review comments, rebased and verified. -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: filter ActionGroup by Application Mode

2012-05-28 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: filter ActionGroup by Application Mode .. webadmin: filter ActionGroup by Application Mode using recursion to filter the action group tree by applicat

[Engine-patches] Change in ovirt-engine[master]: core: Support Appliction Mode for ActionGroup

2012-05-28 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: Support Appliction Mode for ActionGroup .. core: Support Appliction Mode for ActionGroup Adding property to action group, that indicates in which app mode

[Engine-patches] Change in ovirt-engine[master]: engine: Common method to update brick server name

2012-05-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Common method to update brick server name .. Patch Set 3: (2 inline comments) New patch-set to follow.

[Engine-patches] Change in ovirt-engine[master]: core: Return 1 from StoreUtils on error

2012-05-28 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Return 1 from StoreUtils on error .. core: Return 1 from StoreUtils on error The StoreUtils class should return 1 when an exception is generated during t

[Engine-patches] Change in ovirt-engine[master]: engine: Common method to update brick server name

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Common method to update brick server name .. Patch Set 3: (2 inline comments) please use formatter on all changed code ..

[Engine-patches] Change in ovirt-engine[master]: engine: fix for Rebalance Start event notification.

2012-05-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: fix for Rebalance Start event notification. .. Patch Set 2: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster Volume Replace brick vdsm verb change

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: engine: Gluster Volume Replace brick vdsm verb change .. engine: Gluster Volume Replace brick vdsm verb change - Vdsm verb changed - Database upd

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster Volume Replace brick vdsm verb change

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Gluster Volume Replace brick vdsm verb change .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4544 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster Volume Replace brick vdsm verb change

2012-05-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Gluster Volume Replace brick vdsm verb change .. Patch Set 4: Verified rebased. -- To view, visit http://gerrit.ovirt.org/4544 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: engine: New query to fetch brick by id

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: New query to fetch brick by id .. Patch Set 2: Looks good to me, but someone else must approve this patch contains changes to rest api, so need ack for th

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for Bricks status is always Down

2012-05-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fix for Bricks status is always Down .. engine: Fix for Bricks status is always Down Updating the Brick status while changing the volume st

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for Bricks status is always Down

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Fix for Bricks status is always Down .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4756 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for Bricks status is always Down

2012-05-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Fix for Bricks status is always Down .. Patch Set 3: Verified rebased -- To view, visit http://gerrit.ovirt.org/4756 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster Volume Replace brick vdsm verb change

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Gluster Volume Replace brick vdsm verb change .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4544 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for Bricks status is always Down

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Fix for Bricks status is always Down .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4756 To unsubscribe, visit http:

[Engine-patches] [oVirt Jenkins] ovirt_engine_create_update_db - Build # 1146 - Fixed!

2012-05-28 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/ Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1146/ Build Number: 1146 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 1,326 - Ch

[Engine-patches] Change in ovirt-engine[master]: core: Fix DISK CREATOR role

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Fix DISK CREATOR role .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4650 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: fix vm_device alias upgrade

2012-05-28 Thread oourfali
Oved Ourfali has submitted this change and it was merged. Change subject: core: fix vm_device alias upgrade .. core: fix vm_device alias upgrade Previous commit added a new column named alias to the vm_device table, with a defa

[Engine-patches] Change in ovirt-engine[master]: core: fix vm_device alias upgrade

2012-05-28 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: fix vm_device alias upgrade .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4844 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core : Last patch for removing internal_drive_mappings

2012-05-28 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core : Last patch for removing internal_drive_mappings .. core : Last patch for removing internal_drive_mappings The following patch is removing a usage of int

[Engine-patches] Change in ovirt-engine[master]: core : Removing internal_drive_mappings - db scripts

2012-05-28 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core : Removing internal_drive_mappings - db scripts .. core : Removing internal_drive_mappings - db scripts The following patch is a db scripts part for remov

[Engine-patches] Change in ovirt-engine[master]: core: fix vm_device alias upgrade

2012-05-28 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: fix vm_device alias upgrade .. -- To view, visit http://gerrit.ovirt.org/4844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: c

[Engine-patches] Change in ovirt-engine[master]: core: VM and Template creator roles

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VM and Template creator roles .. Patch Set 7: (1 inline comment) File backend/manager/dbscripts/upgrade

[Engine-patches] Change in ovirt-engine[master]: core: fix vm_device alias upgrade

2012-05-28 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: fix vm_device alias upgrade .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4844 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup PredifnedRoles

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Cleanup PredifnedRoles .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4615 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Enable allowing view children permissions

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Enable allowing view children permissions .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4608 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: Update roles.allow_viewing_children properly

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Update roles.allow_viewing_children properly .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4607 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Validate shareable disk version

2012-05-28 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate shareable disk version .. core: Validate shareable disk version Changing the validation of shareable disk to check the prior returnValue i

[Engine-patches] Change in ovirt-engine[master]: core: Validate shareable disk version

2012-05-28 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Validate shareable disk version .. Patch Set 6: Verified; Looks good to me, approved acked by ofrenkel -- To view, visit http://gerrit.ovirt.org/4781 To un

[Engine-patches] Change in ovirt-engine[master]: core: Validate shareable disk version

2012-05-28 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Validate shareable disk version .. Patch Set 5: Looks good to me, approved ack by ofrenekel -- To view, visit http://gerrit.ovirt.org/4781 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Validate shareable disk version

2012-05-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Validate shareable disk version .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4781 To unsubscribe, visit http://gerri

  1   2   3   >