Moti Asayag has posted comments on this change.

Change subject: restapi: Support Correlation Id
......................................................................


Patch Set 1:

Please note that upon illegal value for the correlation-ID, the command will be 
failed.

See definition of the correlation-ID on VdcActionParametersBase.correlationID 
(max size 50, no special characters):

    @Pattern(regexp = ValidationUtils.NO_SPECIAL_CHARACTERS, message = 
"VALIDATION_INVALID_CORRELATION_ID",
            groups = PreRun.class)
    @Size(min = 1, max = BusinessEntitiesDefinitions.CORRELATION_ID_SIZE, 
groups = PreRun.class)
    private String correlationId;

Not sure if it is acceptable, but you may block requests with incorrect 
correlation-ID before command is sent to the backend using same method as 
appeared on ExecutionHandler.evaluateCorrelationId

--
To view, visit http://gerrit.ovirt.org/4842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia353b98595c484d39414277785611a9430f83368
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to