Omer Frenkel has posted comments on this change.
Change subject: engine: add support for network port mirroring
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3726
To u
Allon Mureinik has posted comments on this change.
Change subject: core: Disk Permissions view
..
Patch Set 8: (1 inline comment)
File backend/manager/dbscripts/create_views.
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: Gluster Volumes Collection implementation
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/393
Michael Kublin has posted comments on this change.
Change subject: core: Introducing another checkStatusAndLockVm method
..
Patch Set 2: I would prefer that you didn't submit this
Sorry for -1, but concept is wrong, we should p
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: fix product name and vendor to oVirt Engine and
ovirt.org
..
restapi: fix product name and vendor to oVirt Engine and ovirt.org
Change-Id:
Michael Pasternak has posted comments on this change.
Change subject: restapi: fix product name and vendor to oVirt Engine and
ovirt.org
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetDiskConfigurationListQuery
..
Patch Set 9: (1 inline comment)
File
backend/manager/module
Alona Kaplan has posted comments on this change.
Change subject: ui: Add Port Mirroring mode to Vm Interface dialog
..
Patch Set 10: (2 inline comments)
File
frontend/webadm
Yair Zaslavsky has posted comments on this change.
Change subject: Work in progress - Build and run with Fedora 17 jboss-as
..
Patch Set 4: Looks good to me, but someone else must approve
Reviewed.
Tools look good (engine-confi
Allon Mureinik has posted comments on this change.
Change subject: core: Add floating disk to fixtures.xml
..
Patch Set 8: (1 inline comment)
File
backend/manager/modules/da
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: mistakenly grayed out console button
..
webadmin: mistakenly grayed out console button
ConsoleModel - reset 'isConnected' property when VM's
status isn'
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Update VmDao to return multiple Vms for disk.
..
core:Update VmDao to return multiple Vms for disk.
Changed the API of the VMDao to return list of VMs.
Also
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Update vm device DAO to reference vmId.
..
core:Update vm device DAO to reference vmId.
Update vm device store procedures to use vmId as a parameter when re
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Support move of shareable disk
..
core:Support move of shareable disk
Support shareable disk move operation.
Since all_disks list will return multi columns
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Validate unshare disk which attached to VMs
..
core:Validate unshare disk which attached to VMs
Use validation when updating disk to be un shared any more.
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Support remove of shared disk.
..
core:Support remove of shared disk.
Adding support to remove disk from multiple vms.
The remove command was counting on th
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Use attachable disk for shareable
..
core:Use attachable disk for shareable
Add shareable disks to be part of the attachable disk list.
Signed-off-by: Maor
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Use shareable disk only for 3.1 DC version
..
core:Use shareable disk only for 3.1 DC version
Block ability to configure shareable disk for Data Ceneters wh
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Remove use of container id for snapshot
..
core:Remove use of container id for snapshot
Remove the use of container id since the field should not be used.
I
Douglas Schilling Landgraf has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 10: I would prefer that you didn't submit this
Looks like it's no more valid:
$ git fetch http://
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Gluster Volume Options - populating from help xml
..
webadmin: Gluster Volume Options - populating from help xml
In the Volume Option dialog, the option
Itamar Heim has posted comments on this change.
Change subject: core: user level queries - filtered entities
..
Patch Set 2: (2 inline comments)
Commit Message
Line 30: horiz
Maor Lipchuk has posted comments on this change.
Change subject: core: Filter GetAllAttachableDisksByPoolId
..
Patch Set 8: (1 inline comment)
Looks good, minor comments
Fil
Maor Lipchuk has posted comments on this change.
Change subject: core: Disk Permissions view
..
Patch Set 8: (1 inline comment)
File backend/manager/dbscripts/create_views.sq
Maor Lipchuk has posted comments on this change.
Change subject: core: GetVdsGroupsByStoragePoolId as a user query
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4366
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup GetDiskConfigurationListQuery
..
Patch Set 9: Looks good to me, approved
(1 inline comment)
minor comment to consider.
...
Maor Lipchuk has posted comments on this change.
Change subject: core: GetDiskConfigurationList as a user query
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4381
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup DiskDao and its tests
..
Patch Set 8: Looks good to me, approved
+3 for the fixturesTool
--
To view, visit http://gerrit.ovirt.org/4435
To unsubscr
Maor Lipchuk has posted comments on this change.
Change subject: core: Add floating disk to fixtures.xml
..
Patch Set 8: (1 inline comment)
looks good, minor comments
File
Itamar Heim has uploaded a new change for review.
Change subject: move NlsCheck.java to checks package per declaration in file
..
move NlsCheck.java to checks package per declaration in file
Change-Id: I3934f6745c93aa1f2465538a3
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Gluster Volumes Collection implementation
..
Patch Set 4:
Complete implementation of BackendGlusterVolumesResource, including JUnit tests.
--
To view,
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Gluster Resources Implementation classes
..
Patch Set 7:
Updated the TODO comment in unimplemented methods with "(pending backend
functionality)" wher
Juan Hernandez has posted comments on this change.
Change subject: Work in progress - Build and run with Fedora 17 jboss-as
..
Patch Set 4:
Install the .jar files to /usr/share/java/ovirt-engine.jar, and the POM files
to /usr/
Shireesh Anjal has posted comments on this change.
Change subject: engine: Add ID fields to gluster brick and option
..
Patch Set 2:
rebased and resolved conflicts.
--
To view, visit http://gerrit.ovirt.org/4431
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: WIP: is_inheritable property to MLA entities
..
Patch Set 2: Verified
Removed TWS
--
To view, visit http://gerrit.ovirt.org/4484
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup Permissions Commands
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4483
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: Roles commands cleanup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup RoleDAO and its test
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4474
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup roles
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup RoleGroupMapDAO and its tests
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4472
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: GetAllVdsByStoragePoolQuery
..
Patch Set 5: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4456
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: VdsDAO.getAllForStoragePool
..
Patch Set 5: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4455
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Support floating lun in the DAO
..
Patch Set 3: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4466
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Flag GetAllAttachableDisks as a user query
..
Patch Set 8: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4446
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: Filter GetAllAttachableDisksByPoolId
..
Patch Set 8: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4438
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: Add floating disk to fixtures.xml
..
Patch Set 8: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4436
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup DiskDao and its tests
..
Patch Set 8: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4435
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Disk Permissions view
..
Patch Set 8: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4434
To unsubscribe, visit http://gerrit.ovirt.org/setti
Allon Mureinik has posted comments on this change.
Change subject: core: GetDiskConfigurationList as a user query
..
Patch Set 9: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4381
To unsubscribe, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetDiskConfigurationListQuery
..
Patch Set 9: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4380
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: GetVdsGroupsByStoragePoolId as a user query
..
Patch Set 10: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4366
To unsubscribe, visit http:/
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup Permissions Commands
..
core: Cleanup Permissions Commands
1. Replaced DbFacade.getInstance() with getDbFacade()
2. Added serialVersionUID
3. Sol
Allon Mureinik has uploaded a new change for review.
Change subject: core: WIP: is_inheritable property to MLA entities
..
core: WIP: is_inheritable property to MLA entities
Added the is_inheritable property to the Action Group
Allon Mureinik has uploaded a new change for review.
Change subject: core: Roles commands cleanup
..
core: Roles commands cleanup
1. Replaced ArrayList declarations with List declarations where
possible.
2. Replaced DbFacade.
Itamar Heim has posted comments on this change.
Change subject: ui: fix naming to oVirt Engine
..
Patch Set 1:
i agree this could be generalized, but this can be done in a later patch, while
this fixes the current incorrect na
Dan Kenigsberg has posted comments on this change.
Change subject: ui: fix naming to oVirt Engine
..
Patch Set 1: I would prefer that you didn't submit this
In Vdsm we try to have such strings depend on a single configurable, s
Itamar Heim has uploaded a new change for review.
Change subject: ui: fix naming to oVirt Engine
..
ui: fix naming to oVirt Engine
Change-Id: I5cdb57667ff5d7a8d9e8664e7edb198ba93b8823
Signed-off-by: Itamar Heim
---
M
frontend/
Douglas Schilling Landgraf has abandoned this change.
Change subject: Makefile: Add /etc/engine into create_dirs target
..
Patch Set 1: Abandoned
No required
--
To view, visit http://gerrit.ovirt.org/2363
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: Work in progress - Build and run with Fedora 17 jboss-as
..
Patch Set 3:
Rebased, fixed the issues detected so far and checked that the
engine-manage-domains u
Itamar Heim has uploaded a new change for review.
Change subject: restapi: fix product name and vendor to oVirt Engine and
ovirt.org
..
restapi: fix product name and vendor to oVirt Engine and ovirt.org
Change-Id: I9d82aed8a9ba
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Fix Java 7 compilation issues
..
Patch Set 4:
Did clean build with tests again, no regression anymore regarding the
permission dialog, need to test it
Gilad Chaplik has posted comments on this change.
Change subject: [WIP] webadmin: expose the V3 domain format in dc 3.1
..
Patch Set 2: (1 inline comment)
File
frontend/weba
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Adding virt service checkbox in Cluster dialog
..
Patch Set 2:
another thing, you need to support also the DC guide me -> add cluster.
--
To view, vis
Federico Simoncelli has posted comments on this change.
Change subject: [WIP] webadmin: expose the V3 domain format in dc 3.1
..
Patch Set 2: (1 inline comment)
File
fronten
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Adding virt service checkbox in Cluster dialog
..
Patch Set 2: (2 inline comments)
besides the 2 comments in constants.java:
in edit cluster dialog, i
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Move ROOT.war to the EAR
..
Patch Set 7: Looks good to me, but someone else must approve
ack on packaging code, no changes.
--
To view, visit http:/
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move ROOT.war to the EAR
..
Patch Set 7:
Doron, no suggestion from others, so I am taking yours and renaming the module
to "root-context". Note that
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Volume - Remove Bricks implementation
..
Patch Set 3: Verified; Looks good to me, approved
rebased & verified.
--
To view, visit http://gerrit
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Volume - Remove Bricks implementation
..
webadmin: Gluster Volume - Remove Bricks implementation
A mew ui action is added in Bricks Su
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Volume - Add Bricks implementation
..
Patch Set 2: Verified; Looks good to me, approved
rebased & verified.
--
To view, visit http://gerrit.ov
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Volume - Add Bricks implementation
..
webadmin: Gluster Volume - Add Bricks implementation
This enables adding bricks to existing volu
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Volume - Start Rebalance action
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4427
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: Work in progress - Build and run with Fedora 17 jboss-as
..
Patch Set 1: (4 inline comments)
File packaging
Ofer Schreiber has posted comments on this change.
Change subject: Work in progress - Build and run with Fedora 17 jboss-as
..
Patch Set 1: (3 inline comments)
First pass on the packaging and installer python code.
...
Juan Hernandez has posted comments on this change.
Change subject: webadmin: Fix Java 7 compilation issues
..
Patch Set 4:
Rebased and removed some changes that got into the patch by accident.
--
To view, visit http://gerrit.o
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Fix Java 7 compilation issues
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4315
To unsubs
Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Volume Add Brick command
..
Patch Set 8: (1 inline comment)
File
frontend/webadmin/modules/u
Selvasundaram has posted comments on this change.
Change subject: engine: Replace gluster Volume Brick Start
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/module
Federico Simoncelli has posted comments on this change.
Change subject: [WIP] webadmin: expose the V3 domain format in dc 3.1
..
Patch Set 1: (1 inline comment)
File
fronten
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Adding virt service checkbox in Cluster dialog
..
Patch Set 2: Verified
Rebase and Verified.
--
To view, visit http://gerrit.ovirt.org/4387
To unsubscri
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix NPE when creating VM server (#820227)
..
core: Fix NPE when creating VM server (#820227)
https://bugzilla.redhat.com/820227
Adding new server
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix NPE when creating VM server (#820227)
..
Patch Set 2: Verified; Looks good to me, approved
Acked by ofrenkel and emesika
--
To view, visit http://gerri
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix NPE when creating VM server (#820227)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4475
To unsubscribe
Eli Mesika has posted comments on this change.
Change subject: wip DON'T SUBMIT - core: USB devices
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/common/sr
Eli Mesika has posted comments on this change.
Change subject: core: Fix NPE when creating VM server (#820227)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4475
To unsubscribe, visit http
Omer Frenkel has posted comments on this change.
Change subject: core: Fix NPE when creating VM server (#820227)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4475
To unsubscribe, visit ht
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Conflict issue fix
..
engine: Conflict issue fix
Issue in patchset: http://gerrit.ovirt.org/#change,4302
Change-Id: Ic4f981bbc0e5cf37a8af9a0f17c9
Itamar Heim has posted comments on this change.
Change subject: engine: Conflict issue fix
..
Patch Set 1: Verified; Looks good to me, approved
submitting compile breaking fix
--
To view, visit http://gerrit.ovirt.org/4477
To
Dhandapani Gopal has uploaded a new change for review.
Change subject: engine: Conflict issue fix
..
engine: Conflict issue fix
Issue in patchset: http://gerrit.ovirt.org/#change,4302
Change-Id: Ic4f981bbc0e5cf37a8af9a0f17c97df
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] webadmin: expose the V3 domain format in dc 3.1
..
[WIP] webadmin: expose the V3 domain format in dc 3.1
Signed-off-by: Federico Simoncelli
Change-
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Fix NPE when creating VM server (#820227)
..
core: Fix NPE when creating VM server (#820227)
https://bugzilla.redhat.com/820227
Adding new server from tem
Einav Cohen has posted comments on this change.
Change subject: engine: Gluster Volume Add Brick command
..
Patch Set 8: (1 inline comment)
File
frontend/webadmin/modules/ui
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Don't use the setCharacterEncoding method
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/431
Juan Hernandez has posted comments on this change.
Change subject: webadmin: Fix Java 7 compilation issues
..
Patch Set 3:
> Thanks Juan, EntityModelTextColumn was indeed used with wrong type parameter
> on multiple places (En
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Fix Java 7 compilation issues
..
Patch Set 3:
Thanks Juan, EntityModelTextColumn was indeed used with wrong type parameter on
multiple places (EntityM
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Gluster Volume - Remove Bricks implementation
..
Patch Set 2: Verified
Comments are implemented.
Rebase and Verified.
--
To view, visit http://gerrit.o
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Gluster Volume - Remove Bricks implementation
..
Patch Set 1: (1 inline comment)
File
frontend/weba
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Gluster Volume Add Brick command
..
engine: Gluster Volume Add Brick command
Includes following related to the command for "Gluster Volume Add Br
Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Volume Add Brick command
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4302
To unsubscribe, visit http://ge
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Gluster Volume Add Brick command
..
Patch Set 8: Verified
Rebased with master
--
To view, visit http://gerrit.ovirt.org/4302
To unsubscribe, visit ht
1 - 100 of 282 matches
Mail list logo
