Vojtech Szocs has posted comments on this change.

Change subject: webadmin: Fix Java 7 compilation issues
......................................................................


Patch Set 3:

Thanks Juan, EntityModelTextColumn was indeed used with wrong type parameter on 
multiple places (EntityModelEnumColumn should be fine though). I'm just 
wondering why this worked when building with JRE 6 at all..

Few questions:
- why did you change CXFContextInterceptor? (causes compile error for me..)
- why did you change GwtDynamicHostPageServlet? (removing character encoding 
statement)

--
To view, visit http://gerrit.ovirt.org/4315
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1b74f3b84019b8ba28a2cefaef42db25f39f89
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to