Juan Hernandez has posted comments on this change.

Change subject: Work in progress - Build and run with Fedora 17 jboss-as
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File packaging/fedora/setup/engine-setup.py
Line 1692:     logging.debug(output)
No, no reason, this is just part of my debugging. I already removed it.

Line 1697:             f.write(rpm + "\n")
Same here ^

Line 2238:     return
I wish we had a "--no-check-memory" option! I always have to do this in my low 
memory environment ;-)

....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 8: %global __os_install_post %{nil}
Done.

--
To view, visit http://gerrit.ovirt.org/4416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cda15e5219d1b6c8e8306fc7b4f196e6afc66b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to