[Engine-patches] Change in ovirt-engine[master]: restapi: Poll Job-Id on Restore-Snapshot

2012-05-06 Thread oliel
Ori Liel has posted comments on this change. Change subject: restapi: Poll Job-Id on Restore-Snapshot .. Patch Set 2: Pre-integration tests successful -- To view, visit http://gerrit.ovirt.org/4117 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: restapi: Fix RSDL Regression

2012-05-06 Thread oliel
Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix RSDL Regression .. restapi: Fix RSDL Regression Regression in RSDL: .../api/vms/{vm:id}/disks/{disk:id} would show return type = CdRom .../api/v

[Engine-patches] Change in ovirt-engine[master]: restapi: Fix RSDL Regression

2012-05-06 Thread oliel
Ori Liel has posted comments on this change. Change subject: restapi: Fix RSDL Regression .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4090 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Change RemoveSnapshot end command behavior

2012-05-06 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Change RemoveSnapshot end command behavior .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4128 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove Update From User-Role, Group-Role

2012-05-06 Thread oliel
Ori Liel has posted comments on this change. Change subject: restapi: Remove Update From User-Role, Group-Role .. Patch Set 1: The change is supposed to fix both flows. Both flows use BackendAssignedRolesResource, and the met

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 1047 - Failure!

2012-05-06 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine/ Build: http://jenkins.ovirt.org/job/ovirt_engine/1047/ Build Number: 1047 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: - Chang

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup repo_files_meta_data_sp.sql

2012-05-06 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Cleanup repo_files_meta_data_sp.sql .. core: Cleanup repo_files_meta_data_sp.sql Removed commented-out statements. Change-Id: Iaab2feb7bce00df4369

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup repo_files_meta_data_sp.sql

2012-05-06 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Cleanup repo_files_meta_data_sp.sql .. Patch Set 11: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4057 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Removed unused license query types.

2012-05-06 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Removed unused license query types. .. core: Removed unused license query types. IsLicenseValid and IsLicenseSupported query types are no longer us

[Engine-patches] Change in ovirt-engine[master]: core: Removed unused license query types.

2012-05-06 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Removed unused license query types. .. Patch Set 11: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4056 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: search VM & Template by object id

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: search VM & Template by object id .. Patch Set 2: (1 inline comment) File backend/manager/modules/se

[Engine-patches] Change in ovirt-engine[master]: core: New queries to get ISOs by StoragePoolIds

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: New queries to get ISOs by StoragePoolIds .. Patch Set 3: Verified rebase, no change since last patchset. -- To view, visit http://gerrit.ovirt.org/4148

[Engine-patches] Change in ovirt-engine[master]: core: New base classes for GetAllImageListQuery

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: New base classes for GetAllImageListQuery .. Patch Set 3: Verified rebase, no change since last patchset. -- To view, visit http://gerrit.ovirt.org/4147

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup GetAllIsoImagesListParameters

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup GetAllIsoImagesListParameters .. Patch Set 3: Verified rebase, no change since last patchset. -- To view, visit http://gerrit.ovirt.org/4146 To u

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup IsoDomainListSyncronizer

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup IsoDomainListSyncronizer .. Patch Set 5: Verified rebase, no change since last patchset. -- To view, visit http://gerrit.ovirt.org/4077 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup RepoFileMetaDataDAO and its test

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup RepoFileMetaDataDAO and its test .. Patch Set 5: Verified rebase, no change since last patchset. -- To view, visit http://gerrit.ovirt.org/4076 T

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup repo_files_meta_data_sp.sql

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup repo_files_meta_data_sp.sql .. Patch Set 11: Verified rebase, no change since last patchset. -- To view, visit http://gerrit.ovirt.org/4057 To un

[Engine-patches] Change in ovirt-engine[master]: core: Removed unused license query types.

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Removed unused license query types. .. Patch Set 11: Verified rebase, no change since last patchset. -- To view, visit http://gerrit.ovirt.org/4056 To un

[Engine-patches] Change in ovirt-engine[master]: engine: getUpServer method moved to new class ClusterUtils

2012-05-06 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: getUpServer method moved to new class ClusterUtils .. Patch Set 4: Removed the PowerMock in JUnit test. Use the org.ovirt.engine.core.utils.RandomUti

[Engine-patches] Change in ovirt-engine[master]: core: Set parameters task success only for command

2012-05-06 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Set parameters task success only for command .. Patch Set 2: (1 inline comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Gluster Volume - Reset all options

2012-05-06 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: Gluster Volume - Reset all options .. Patch Set 2: Verified rebase and verified. -- To view, visit http://gerrit.ovirt.org/4071 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: webadmin: Gluster Volume dialog - remove CIFS

2012-05-06 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: Gluster Volume dialog - remove CIFS .. Patch Set 2: Verified rebase and verified. -- To view, visit http://gerrit.ovirt.org/4039 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: search VM & Template by object id

2012-05-06 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: search VM & Template by object id .. Patch Set 2: (2 inline comments) File backend/manager/modules/sear

[Engine-patches] Change in ovirt-engine[master]: core: Monitor any actions if executed with a correlation ID

2012-05-06 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: core: Monitor any actions if executed with a correlation ID .. core: Monitor any actions if executed with a correlation ID Each action which is executed

[Engine-patches] Change in ovirt-engine[master]: core: Monitor any actions if executed with a correlation ID

2012-05-06 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: Monitor any actions if executed with a correlation ID .. Patch Set 2: Verified; Looks good to me, approved no surprises as usual -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: import - vm or template in setup column

2012-05-06 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: import - vm or template in setup column .. Patch Set 1: opps :) -- To view, visit http://gerrit.ovirt.org/4160 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 564 - Fixed!

2012-05-06 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/564/ Build Number: 564 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 1,045 - Changes Since Last

[Engine-patches] Change in ovirt-engine[master]: core: search VM & Template by object id

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: search VM & Template by object id .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4159 To unsubs

[Engine-patches] Change in ovirt-engine[master]: webadmin: import - vm or template in setup column

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: webadmin: import - vm or template in setup column .. Patch Set 1: I would prefer that you didn't submit this Please remove the patch file. -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: restapi: Add console reconnect

2012-05-06 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Add console reconnect .. Patch Set 9: I would prefer that you didn't submit this please model this parameter in: definition/src/main/resources/rsdl

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove Update From User-Role, Group-Role

2012-05-06 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Remove Update From User-Role, Group-Role .. Patch Set 1: I would prefer that you didn't submit this i can't see you fixing /Groups/ (suffers from sa

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add session support

2012-05-06 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: Add session support .. Patch Set 2: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/4044 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add session support

2012-05-06 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: Add session support .. Patch Set 2: Hi Juan, nice piece of work!, but i have an issue with exposer of this feature to user: end-user doesn't have di

[Engine-patches] Change in ovirt-engine[master]: engine: Import VM more than once (#567580)

2012-05-06 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: engine: Import VM more than once (#567580) .. engine: Import VM more than once (#567580) https://bugzilla.redhat.com/567580 feature page: http://www.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Import VM more than once (#567580)

2012-05-06 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: Import VM more than once (#567580) .. webadmin: Import VM more than once (#567580) https://bugzilla.redhat.com/567580 feature page: http://www.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: search VM & Template by object id

2012-05-06 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: search VM & Template by object id .. core: search VM & Template by object id search Vms and templates by object_id: vm_guid, vmt_guid. It will not be visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: import - vm or template in setup column

2012-05-06 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: import - vm or template in setup column .. webadmin: import - vm or template in setup column Signed-off-by: Gilad Chaplik Change-Id: I97408628e3e547a

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix NPE in styles

2012-05-06 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: fix NPE in styles .. webadmin: fix NPE in styles Signed-off-by: Gilad Chaplik Change-Id: I02cb2abf31028d5db3c46ecfbcaa6916da1e4f81 --- M frontend/we

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 769 - Fixed!

2012-05-06 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/769/ Build Number: 769 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 1,044 - Changes Since Last

[Engine-patches] Change in ovirt-engine[master]: restapi: Fix RSDL Regression

2012-05-06 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Fix RSDL Regression .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4090 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Wrong usage of map at VmPropertiesUtils

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Wrong usage of map at VmPropertiesUtils .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/4157 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Wrong usage of map at VmPropertiesUtils

2012-05-06 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Wrong usage of map at VmPropertiesUtils .. core: Wrong usage of map at VmPropertiesUtils The following patch fixes wrong usage of map (for userde

[Engine-patches] Change in ovirt-engine[master]: core: Wrong usage of map at VmPropertiesUtils

2012-05-06 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Wrong usage of map at VmPropertiesUtils .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4157 To unsubscribe, visit http

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 768 - Still Unstable!

2012-05-06 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/768/ Build Number: 768 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,043 - Changes S

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 767 - Still Unstable!

2012-05-06 Thread Jenkins oVirt Server
ovirt_engine_find_bugs build status is Still Unstable for Build #767 -- Changes Since Last Success: --- Changes for Build #711 [sanjal] engine: Create Gluster Volume enhancements [emesika] core: removing async tasks and compensation data on upgrade [yzaslavs] engi

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 562 - Fixed!

2012-05-06 Thread Jenkins oVirt Server
ovirt_engine_gwt_admin build status is Fixed for Build #562 -- Changes Since Last Success: --- Changes for Build #561 [alourie] packaging: Fixed size calculations and dirname parsing in validation [oourfali] core: split configuration common stored procedure Chan

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 561 - Failure!

2012-05-06 Thread Jenkins oVirt Server
ovirt_engine_gwt_admin build status is Failure for Build #561 -- Changes Since Last Success: --- Changes for Build #561 [alourie] packaging: Fixed size calculations and dirname parsing in validation [oourfali] core: split configuration common stored procedure

[Engine-patches] Change in ovirt-engine[master]: core: Wrong usage of map at VmPropertiesUtils

2012-05-06 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Wrong usage of map at VmPropertiesUtils .. core: Wrong usage of map at VmPropertiesUtils The following patch fixes wrong usage of map (for userdefinedPro

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 766 - Still Unstable!

2012-05-06 Thread Jenkins oVirt Server
ovirt_engine_find_bugs build status is Still Unstable for Build #766 -- Changes Since Last Success: --- Changes for Build #711 [sanjal] engine: Create Gluster Volume enhancements [emesika] core: removing async tasks and compensation data on upgrade [yzaslavs] engi

[Engine-patches] Change in ovirt-engine[master]: core: some NFS mount options cleanup and test

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: some NFS mount options cleanup and test .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4091 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Introducing MockConfigRule

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: WIP: Introducing MockConfigRule .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Giving +1 for now - I agree with what

[Engine-patches] Change in ovirt-engine[master]: core: split configuration common stored procedure

2012-05-06 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: split configuration common stored procedure .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4156 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: split configuration common stored procedure

2012-05-06 Thread oourfali
Oved Ourfali has submitted this change and it was merged. Change subject: core: split configuration common stored procedure .. core: split configuration common stored procedure This commit adds a new "split configuration" funct

[Engine-patches] Change in ovirt-engine[master]: core: split configuration common stored procedure

2012-05-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: split configuration common stored procedure .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4156 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: Scheduling Jobs with Configurable Delay

2012-05-06 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Scheduling Jobs with Configurable Delay .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Introducing MockConfigRule

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WIP: Introducing MockConfigRule .. Patch Set 1: (1 inline comment) File backend/manager/modules/util

[Engine-patches] Change in ovirt-engine[master]: core: split configuration common stored procedure

2012-05-06 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: split configuration common stored procedure .. Patch Set 1: (1 inline comment) File backend/manager/dbscr

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed size calculations and dirname parsing in v...

2012-05-06 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Fixed size calculations and dirname parsing in validation .. packaging: Fixed size calculations and dirname parsing in validation * Chang

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed size calculations and dirname parsing in v...

2012-05-06 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed size calculations and dirname parsing in validation .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4129

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed size calculations and dirname parsing in v...

2012-05-06 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: Fixed size calculations and dirname parsing in validation .. Patch Set 4: Verified; Looks good to me, but someone else must approve -- To view, visit

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user-gwtp - Build # 779 - Still Failing!

2012-05-06 Thread Jenkins oVirt Server
ovirt_engine_gwt_user-gwtp build status is Still Failing for Build #779 -- New Changes: --- - Failed Tests: - No tests ran. -- Build Log: (check http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/779/ for f

[Engine-patches] Change in ovirt-engine[master]: core: split configuration common stored procedure

2012-05-06 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: core: split configuration common stored procedure .. core: split configuration common stored procedure This commit adds a new "split configuration" function, cal

[Engine-patches] Change in ovirt-engine[master]: core: New base classes for GetAllImageListQuery

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: New base classes for GetAllImageListQuery .. Patch Set 2: Verified rebase, addressed mkolesni's review. -- To view, visit http://gerrit.ovirt.org/4147 To

[Engine-patches] Change in ovirt-engine[master]: core: New queries to get ISOs by StoragePoolIds

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: New queries to get ISOs by StoragePoolIds .. Patch Set 2: Verified rebased, fixed according to mkolesni's comments -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup GetAllIsoImagesListParameters

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup GetAllIsoImagesListParameters .. Patch Set 2: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup IsoDomainListSyncronizer

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup IsoDomainListSyncronizer .. Patch Set 4: Verified rebased, no changes since last patchset -- To view, visit http://gerrit.ovirt.org/4077 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup RepoFileMetaDataDAO and its test

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup RepoFileMetaDataDAO and its test .. Patch Set 4: Verified rebased, no changes since last review -- To view, visit http://gerrit.ovirt.org/4076 To

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup repo_files_meta_data_sp.sql

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup repo_files_meta_data_sp.sql .. Patch Set 10: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review -

[Engine-patches] Change in ovirt-engine[master]: core: Removed unused license query types.

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Removed unused license query types. .. Patch Set 10: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review -

[Engine-patches] Change in ovirt-engine[master]: core: new base classes for GetAllImageListQuery

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new base classes for GetAllImageListQuery .. Patch Set 1: (2 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed size calculations and dirname parsing in v...

2012-05-06 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed size calculations and dirname parsing in validation .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4129

[Engine-patches] Change in ovirt-engine[master]: core: Change RemoveSnapshot end command behavior

2012-05-06 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Change RemoveSnapshot end command behavior .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4128 To

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user-gwtp - Build # 778 - Failure!

2012-05-06 Thread Jenkins oVirt Server
ovirt_engine_gwt_user-gwtp - Build # 778 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/778/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] Change in ovirt-engine[master]: restapi: add VmPayload support

2012-05-06 Thread oliel
Ori Liel has posted comments on this change. Change subject: restapi: add VmPayload support .. Patch Set 5: (10 inline comments) File backend/manager/modules/restapi/jaxrs/s

[Engine-patches] Change in ovirt-engine[master]: core: Set parameters task success only for command

2012-05-06 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Set parameters task success only for command .. Patch Set 2: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add prestarted VMs field to pool dialog

2012-05-06 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Add prestarted VMs field to pool dialog .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/4079 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: New queries to get ISOs by StoragePoolIds

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: New queries to get ISOs by StoragePoolIds .. Patch Set 1: (3 inline comments) Agree with all three points - will upload a new patchset shortly. .

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Introducing MockConfigRule

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: WIP: Introducing MockConfigRule .. Patch Set 1: (1 inline comment) File backend/manager/modules/util

[Engine-patches] Change in ovirt-engine[master]: core: Added command id to parameters

2012-05-06 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Added command id to parameters .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4125 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding change localization to the login

2012-05-06 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: adding change localization to the login .. webadmin: adding change localization to the login no bz Adding change localization combobox to the

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding change localization to the login

2012-05-06 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: adding change localization to the login .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4154 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding change localization to the login

2012-05-06 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: adding change localization to the login .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4154 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Update to Quartz 2.1

2012-05-06 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Update to Quartz 2.1 .. core: Update to Quartz 2.1 This helps packaging for Fedora, as 2.1 is the version avaiable there. Change-Id: Ib86bab5350a0

[Engine-patches] Change in ovirt-engine[master]: core: Update to Quartz 2.1

2012-05-06 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Update to Quartz 2.1 .. Patch Set 5: Verified; Looks good to me, approved just rebased for merging. -- To view, visit http://gerrit.ovirt.org/3250 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: Update to Quartz 2.1

2012-05-06 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Update to Quartz 2.1 .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3250 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Introducing MockConfigRule

2012-05-06 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WIP: Introducing MockConfigRule .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/4155 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Introducing MockConfigRule

2012-05-06 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: WIP: Introducing MockConfigRule .. core: WIP: Introducing MockConfigRule Introduing MockConfigRule, as an easy way of mocking Config in order to avoid th

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed size calculations and dirname parsing in v...

2012-05-06 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: Fixed size calculations and dirname parsing in validation .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: api: [nfs] map nfs connection

2012-05-06 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: api: [nfs] map nfs connection .. Patch Set 2: Please abandon this patch. These fixes are already merged. Thanks! -- To view, visit http://gerrit.ovirt.org/3770

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding change localization to the login

2012-05-06 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: adding change localization to the login .. webadmin: adding change localization to the login no bz Adding change localization combobox to the login po

[Engine-patches] Change in ovirt-engine[master]: core: db - adding a flag for upgrade to clean tasks metadata

2012-05-06 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: db - adding a flag for upgrade to clean tasks metadata .. Patch Set 1: (1 inline comment) File backend

[Engine-patches] Change in ovirt-engine[master]: packaging: Fixed size calculations and dirname parsing in v...

2012-05-06 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: Fixed size calculations and dirname parsing in validation .. Patch Set 1: Fails (1 inline comment) fix: 1. input and output of translation func 2.

[Engine-patches] Change in ovirt-engine[master]: core: after running vm as stateless we can no longer run the...

2012-05-06 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: after running vm as stateless we can no longer run the vm .. core: after running vm as stateless we can no longer run the vm Was unable to reproduce the bug.

[Engine-patches] Change in ovirt-engine[master]: webadmin: Shorten java.util.* namespace

2012-05-06 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Shorten java.util.* namespace .. webadmin: Shorten java.util.* namespace Signed-off-by: Alexey Chub Change-Id: Iee19960abbfdd318136ac79b1c5f9d8

[Engine-patches] Change in ovirt-engine[master]: webadmin: Shorten java.util.* namespace

2012-05-06 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Shorten java.util.* namespace .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4088 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: webadmin: Gluster Volume - Reset all options

2012-05-06 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Gluster Volume - Reset all options .. Patch Set 1: please verify -- To view, visit http://gerrit.ovirt.org/4071 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: webadmin: Gluster Volume dialog - remove CIFS

2012-05-06 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Gluster Volume dialog - remove CIFS .. Patch Set 1: MK, please verify -- To view, visit http://gerrit.ovirt.org/4039 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: wip - engine: adding new support for native USB

2012-05-06 Thread oliel
Ori Liel has posted comments on this change. Change subject: wip - engine: adding new support for native USB .. Patch Set 1: Oh and I forgot one other thing: we should add the new 'type' parameter as an optional property when

[Engine-patches] Change in ovirt-engine[master]: wip - engine: adding new support for native USB

2012-05-06 Thread oliel
Ori Liel has posted comments on this change. Change subject: wip - engine: adding new support for native USB .. Patch Set 1: (1 inline comment) REST side looks great :) In the code itself I only had one minor comment. But I

[Engine-patches] Change in ovirt-engine[master]: core: After clean installation the default cluster and defau...

2012-05-06 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: After clean installation the default cluster and default data center versions are 3.0 .. core: After clean installation the default cluster and default data

  1   2   >