Allon Mureinik has uploaded a new change for review.

Change subject: core: WIP: Introducing MockConfigRule
......................................................................

core: WIP: Introducing MockConfigRule

Introduing MockConfigRule, as an easy way of mocking Config in order to
avoid the dependency on PowerMock that many tests have.

LdapSearchQueryTest is refactored to use this new @Rule as a usage
example.
If this strategy will get the community's approval (i.e., the patch
will be approved), other tests that can benefit from this @Rule will be
refactored in separate patches.

NOTE:
The test-jar approach introduced in the two pom.xml files in this patch
is currently being debated in the engine-devel mailing list.
Do not submit this patch until the issue is discussed and agreed upon.

Change-Id: I9d5d66b135c07b6d6e61fb70bc477d2171cfcb22
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M backend/manager/modules/bll/pom.xml
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapSearchQueryTest.java
M backend/manager/modules/utils/pom.xml
A 
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockConfigRule.java
4 files changed, 72 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/4155/1
--
To view, visit http://gerrit.ovirt.org/4155
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d5d66b135c07b6d6e61fb70bc477d2171cfcb22
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to