Allon Mureinik has posted comments on this change.

Change subject: core: New queries to get ISOs by StoragePoolIds
......................................................................


Patch Set 1: (3 inline comments)

Agree with all three points - will upload a new patchset shortly.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGetAllImagesListByStoragePoolIdQuery.java
Line 25:         storage_pool pool =
Done

Line 32:             List<storage_domains> domains = 
getDbFacade().getStorageDomainDAO().getAllForStoragePool(pool.getId());
Done

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllImagesListByStoragePoolIdQueryTest.java
Line 134:         
when(getQuery().getDbFacade().getStoragePoolDAO()).thenReturn(null);
Done

--
To view, visit http://gerrit.ovirt.org/4148
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86add10f226074792966d6d3efcc67499e459565
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to