[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 78 - Still Failing!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 78 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/78/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup and fix iNPE in HSMGetAllTasksStatusesVDSComma...

2012-03-21 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Cleanup and fix iNPE in HSMGetAllTasksStatusesVDSCommand .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2889

[Engine-patches] Change in ovirt-engine[master]: core: Add grant_mode attribute to permissions entity

2012-03-21 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Add grant_mode attribute to permissions entity .. Patch Set 2: * restapi support will be added in a separate patch, depended on this one. * the enum values

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup for permissions business entity

2012-03-21 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: Cleanup for permissions business entity .. core: Cleanup for permissions business entity The patch organize the class, removes deprecated annotation

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup for permissions business entity

2012-03-21 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Cleanup for permissions business entity .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2977 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: Refactor PermissionDAODbFacadeImpl

2012-03-21 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: Refactor PermissionDAODbFacadeImpl .. core: Refactor PermissionDAODbFacadeImpl The patch modify the mapper class modifier to static, move it to the

[Engine-patches] Change in ovirt-engine[master]: core: Refactor PermissionDAODbFacadeImpl

2012-03-21 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Refactor PermissionDAODbFacadeImpl .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2976 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: restapi: Add support for grant mode attribute in permission

2012-03-21 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: restapi: Add support for grant mode attribute in permission .. restapi: Add support for grant mode attribute in permission The patch adds support for grant mode a

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo - audit log when mtu on host and ...

2012-03-21 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo - audit log when mtu on host and cluster differs .. Patch Set 1: (4 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: Work in progress, don't submit - Uupdate to Spring 3

2012-03-21 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: Work in progress, don't submit - Uupdate to Spring 3 .. Work in progress, don't submit - Uupdate to Spring 3 These are the changes required to update the Sprin

[Engine-patches] Change in ovirt-engine[master]: core: Fixing wrong usage of images in ImportVmTemplate

2012-03-21 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing wrong usage of images in ImportVmTemplate .. core: Fixing wrong usage of images in ImportVmTemplate Two issues: a. A fix in VmDeviceUtils.

[Engine-patches] Change in ovirt-engine[master]: core: Fixing wrong usage of images in ImportVmTemplate

2012-03-21 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Fixing wrong usage of images in ImportVmTemplate .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3001 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Fixing wrong usage of images in ImportVmTemplate

2012-03-21 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing wrong usage of images in ImportVmTemplate .. Patch Set 1: Verified Verified. Made sure using debugger I do not get images at getImageList in order

[Engine-patches] Change in ovirt-engine[master]: core: Fixing wrong usage of images in ImportVmTemplate

2012-03-21 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fixing wrong usage of images in ImportVmTemplate .. core: Fixing wrong usage of images in ImportVmTemplate Two issues: a. A fix in VmDeviceUtils.addImpor

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #75

2012-03-21 Thread Jenkins oVirt Server
See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-21 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 6: rebased -- To view, visit http://gerrit.ovirt.org/2936 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: add mtu to setupnetworks

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: add mtu to setupnetworks .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo - audit log when mtu on host and ...

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo - audit log when mtu on host and cluster differs .. Patch Set 1: (2 inline comments) Some minor comments... .

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo break long method

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo break long method .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2996 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: audit mtu misconfiguration

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: audit mtu misconfiguration .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments) minor comments.

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmTemplatesByImageGuidQuery

2012-03-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: new GetVmTemplatesByImageGuidQuery .. core: new GetVmTemplatesByImageGuidQuery A new query to return VM Templates connected to a given image, for

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmTemplatesByImageGuidQuery

2012-03-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: new GetVmTemplatesByImageGuidQuery .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2953 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: clean unused member and Linq comments

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: clean unused member and Linq comments .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2208 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: add mtu validator

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: add mtu validator .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2995 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Fix warnings in QuotaHelper

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix warnings in QuotaHelper .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/2975 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: added mtu support on newtorks

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: added mtu support on newtorks .. Patch Set 4: Verified; Looks good to me, approved (1 inline comment) Assuming fixing spaces in network_sp.sql. ..

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmTemplatesByImageGuidQuery

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetVmTemplatesByImageGuidQuery .. Patch Set 8: Verified fixed javadoc as per mkolesni's review. -- To view, visit http://gerrit.ovirt.org/2953 To uns

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #74

2012-03-21 Thread Jenkins oVirt Server
See -- [...truncated 1939 lines...] [ERROR] [AppClassLoader@61ba34f2] info register aspect org.ovirt.engine.ui.gwtextension.DontPrune [ERROR] [AppClassLoader@61ba34f2] info register aspect org.ovi

[Engine-patches] Change in ovirt-engine[master]: core: clean XMl annotations for VdsNetworkInterface

2012-03-21 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: clean XMl annotations for VdsNetworkInterface .. Patch Set 4: Verified; Looks good to me, approved rebase already acked -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo - audit log when mtu on host and ...

2012-03-21 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: VdsUpdateRunTimeInfo - audit log when mtu on host and cluster differs .. core: VdsUpdateRunTimeInfo - audit log when mtu on host and cluster differs Change-I

[Engine-patches] Change in ovirt-engine[master]: core: add mtu to setupnetworks

2012-03-21 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: add mtu to setupnetworks .. core: add mtu to setupnetworks Change-Id: I6ed9a13e3b8dcc8456a83266e01539303ca38b1d --- R backend/manager/dbscripts/upgrade/03_01_

[Engine-patches] Change in ovirt-engine[master]: REST: add mtu support

2012-03-21 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: REST: add mtu support .. REST: add mtu support Change-Id: Ied36ef8a86bed18a34a30a7e59e3cae41188ecc7 --- M backend/manager/modules/restapi/interface/definition/src/

[Engine-patches] Change in ovirt-engine[master]: core: add mtu validator

2012-03-21 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: add mtu validator .. core: add mtu validator Change-Id: Ib4f6255c677d5e3371594998bc9b06a17e9d846d --- M backend/manager/modules/common/src/main/java/org/ovir

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo break long method

2012-03-21 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: VdsUpdateRunTimeInfo break long method .. core: VdsUpdateRunTimeInfo break long method break the long checkInterfaces method and prepare place for future chec

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 600 - Fixed!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine - Build # 600 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/600/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: webadmin: Input widget styling fix (#784379)

2012-03-21 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Input widget styling fix (#784379) .. webadmin: Input widget styling fix (#784379) https://bugzilla.redhat.com/784379 AbstractValidatedWidgetWithLabe

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-03-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api .. sdk: rebase to latest api methods argumets documentation fixes Change-Id: I4baecfa98d1daeb1fc9523e6252dafa79d8091bf --

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: release 1.6.3-1

2012-03-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.6.3-1 .. sdk: release 1.6.3-1 Change-Id: Ia7a3c9d91bd262c90a58e47822db58c94f31a4a0 --- M Makefile M ovirt-engine-sdk.spec.in M setup.

[Engine-patches] Change in ovirt-engine-cli[master]: cli: release 2.1.4-1

2012-03-21 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: cli: release 2.1.4-1 .. cli: release 2.1.4-1 Change-Id: I10dbfa70be5905f24c65eca9d2b9c7d57b384870 --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 fil

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: rebase to latest api .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2990 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: release 1.6.3-1

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: release 1.6.3-1 .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2991 To unsubscribe, visit http://gerrit.

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #73

2012-03-21 Thread Jenkins oVirt Server
See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 599 - Still Failing!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine - Build # 599 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/599/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patche

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 598 - Still Failing!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine - Build # 598 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/598/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patche

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 597 - Still Failing!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine - Build # 597 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/597/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patche

[Engine-patches] Change in ovirt-engine-cli[master]: cli: release 2.1.4-1

2012-03-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 2.1.4-1 .. cli: release 2.1.4-1 Change-Id: I10dbfa70be5905f24c65eca9d2b9c7d57b384870 --- M Makefile M ovirt-engine-cli.spec.in M setup.

[Engine-patches] Change in ovirt-engine-cli[master]: cli: release 2.1.4-1

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: cli: release 2.1.4-1 .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2992 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: release 1.6.3-1

2012-03-21 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: release 1.6.3-1 .. sdk: release 1.6.3-1 Change-Id: Ia7a3c9d91bd262c90a58e47822db58c94f31a4a0 --- M Makefile M ovirt-engine-sdk.spec.in M setup.py 3 fil

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-03-21 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: rebase to latest api .. sdk: rebase to latest api methods argumets documentation fixes Change-Id: I4baecfa98d1daeb1fc9523e6252dafa79d8091bf --- M src/

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 596 - Still Failing!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine - Build # 596 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/596/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patche

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #72

2012-03-21 Thread Jenkins oVirt Server
See Changes: [oliel] restapi: RSDL - Add Host To Vm Create/Update [amureini] core: Fix VmDAO.getForImage to return multiple VMs [amureini] core: new GetVmsByImageGuidQuery [amureini] core: Cleanup VmTemplateDAODbFacadeImpl [am

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmTemplatesByImageGuidQuery

2012-03-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: new GetVmTemplatesByImageGuidQuery .. Patch Set 7: (1 inline comment) File backend/manager/modules/bl

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 595 - Failure!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine - Build # 595 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/595/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: VmTamplateDAO.getAllForImage

2012-03-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: VmTamplateDAO.getAllForImage .. core: VmTamplateDAO.getAllForImage Added a new method to retreive all the VM Templates assossiated to a given imag

[Engine-patches] Change in ovirt-engine[master]: core: VmTamplateDAO.getAllForImage

2012-03-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: VmTamplateDAO.getAllForImage .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2950 To unsubscribe, visit http://gerrit.

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 414 - Fixed!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 414 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/414/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: webadmin: Support configuring the title (#723866)

2012-03-21 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Support configuring the title (#723866) .. webadmin: Support configuring the title (#723866) https://bugzilla.redhat.com/723866 Before this patch, ap

[Engine-patches] Change in ovirt-engine[master]: engine-core: [nfs-options] cleanup StorageDomainStaticDAODbF...

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine-core: [nfs-options] cleanup StorageDomainStaticDAODbFacadeImpl .. Patch Set 1: Looks good to me, but someone else must approve Nice! didn't know about

[Engine-patches] Change in ovirt-engine[master]: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool

2012-03-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool .. core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool Moved these constants from VmDAOTest to FixturesT

[Engine-patches] Change in ovirt-engine[master]: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool

2012-03-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2949 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmTemplateDAODbFacadeImpl

2012-03-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Cleanup VmTemplateDAODbFacadeImpl .. core: Cleanup VmTemplateDAODbFacadeImpl Clean up VmTemplateDAODbFacadeImpl. Use a static instance of the row

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmTemplateDAODbFacadeImpl

2012-03-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Cleanup VmTemplateDAODbFacadeImpl .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2941 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmsByImageGuidQuery

2012-03-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: new GetVmsByImageGuidQuery .. core: new GetVmsByImageGuidQuery A new query to return VMs connected to a given image, for use in (future) UI featur

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmsByImageGuidQuery

2012-03-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: new GetVmsByImageGuidQuery .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2934 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Fix warnings in QuotaHelper

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix warnings in QuotaHelper .. Patch Set 6: Verified rebase -- To view, visit http://gerrit.ovirt.org/2975 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmTemplatesByImageGuidQuery

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetVmTemplatesByImageGuidQuery .. Patch Set 7: Verified rebase -- To view, visit http://gerrit.ovirt.org/2953 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: VmTamplateDAO.getAllForImage

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: VmTamplateDAO.getAllForImage .. Patch Set 8: Verified rebase -- To view, visit http://gerrit.ovirt.org/2950 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool .. Patch Set 7: Verified rebase -- To view, visit http://gerrit.ovirt.org/2949 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Fix VmDAO.getForImage to return multiple VMs

2012-03-21 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix VmDAO.getForImage to return multiple VMs .. core: Fix VmDAO.getForImage to return multiple VMs Since the introduction of the shared disc featu

[Engine-patches] Change in ovirt-engine[master]: core: Fix VmDAO.getForImage to return multiple VMs

2012-03-21 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2933 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmTemplateDAODbFacadeImpl

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup VmTemplateDAODbFacadeImpl .. Patch Set 8: Verified rebase -- To view, visit http://gerrit.ovirt.org/2941 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmsByImageGuidQuery

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetVmsByImageGuidQuery .. Patch Set 9: Verified rebase -- To view, visit http://gerrit.ovirt.org/2934 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: Fix VmDAO.getForImage to return multiple VMs

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs .. Patch Set 9: Verified renamed stored procedure as per mkolesni's review. -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: Remember user's choise - override IP tables flag (...

2012-03-21 Thread achub
Alexey Chub has uploaded a new change for review. Change subject: webadmin: Remember user's choise - override IP tables flag (host dialog) .. webadmin: Remember user's choise - override IP tables flag (host dialog) Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL - Add Host To Vm Create/Update

2012-03-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL - Add Host To Vm Create/Update .. restapi: RSDL - Add Host To Vm Create/Update Change-Id: If49125a055724ba94b83a814ba85717746ee44bf --

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL - Add Host To Vm Create/Update

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: RSDL - Add Host To Vm Create/Update .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2987 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: REST: translate VdcFault in case the error messages are empt...

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: REST: translate VdcFault in case the error messages are empty .. Patch Set 2: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: REST: add monitored property to Network

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: REST: add monitored property to Network .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) ..

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 413 - Unstable!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 413 - Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/413/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/list

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 592 - Fixed!

2012-03-21 Thread Jenkins oVirt Server
ovirt_engine - Build # 592 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/592/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: permission filtering for GetStorageDomainsByVmTemplate...

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId .. Patch Set 1: (1 inline comment) please add tests, at least for the DAOs.

[Engine-patches] Change in ovirt-engine[master]: core: permission filtering for GetVdsCertificateSubjectByVds...

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: permission filtering for GetVdsCertificateSubjectByVdsId .. Patch Set 1: Looks good to me, but someone else must approve No test? :-( -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: core: permission filtering for GetVdsInterfacesByVdsId

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: permission filtering for GetVdsInterfacesByVdsId .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Fix warnings in QuotaHelper

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix warnings in QuotaHelper .. Patch Set 5: Verified rebase -- To view, visit http://gerrit.ovirt.org/2975 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmTemplatesByImageGuidQuery

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetVmTemplatesByImageGuidQuery .. Patch Set 6: Verified rebase -- To view, visit http://gerrit.ovirt.org/2953 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: IMAGE_ID and IMAGE_GROUP_ID in FixturesTool .. Patch Set 6: Verified rebase -- To view, visit http://gerrit.ovirt.org/2949 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup VmTemplateDAODbFacadeImpl

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup VmTemplateDAODbFacadeImpl .. Patch Set 7: Verified rebase -- To view, visit http://gerrit.ovirt.org/2941 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: new GetVmsByImageGuidQuery

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetVmsByImageGuidQuery .. Patch Set 8: Verified rebase -- To view, visit http://gerrit.ovirt.org/2934 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: Engine: Update the standalone.xml configuration

2012-03-21 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: Engine: Update the standalone.xml configuration .. Patch Set 2: No score Also need to change the logs to "engine/engine.log", and "engine/engine-ui.log" instead

[Engine-patches] Change in ovirt-engine[master]: core: VmTamplateDAO.getAllForImage

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: VmTamplateDAO.getAllForImage .. Patch Set 7: Verified fix map initialization, as per mkolesni's review. -- To view, visit http://gerrit.ovirt.org/2950 To

[Engine-patches] Change in ovirt-engine[master]: core: Fix VmDAO.getForImage to return multiple VMs

2012-03-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix VmDAO.getForImage to return multiple VMs .. Patch Set 8: Verified fix map initialization, as per mkolesni's review. -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL - Add Host To Vm Create/Update

2012-03-21 Thread oliel
ol...@redhat.com has uploaded a new change for review. Change subject: restapi: RSDL - Add Host To Vm Create/Update .. restapi: RSDL - Add Host To Vm Create/Update Change-Id: If49125a055724ba94b83a814ba85717746ee44bf --- M back

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL Host Reboot After Installation

2012-03-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL Host Reboot After Installation .. restapi: RSDL Host Reboot After Installation Change-Id: Idbb779116e6cea4f57351b9219db86dfdb26e76f --

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL Host Reboot After Installation

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: RSDL Host Reboot After Installation .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2938 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: REST: add vm_network and bridged propertes

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: REST: add vm_network and bridged propertes .. Patch Set 16: I would prefer that you didn't submit this new api design discussed on engine-devel -- To view,

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL - Fix Iscsi Actions Params

2012-03-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL - Fix Iscsi Actions Params .. restapi: RSDL - Fix Iscsi Actions Params Change-Id: Id282624a7e83446200517cd8407fa3b4948cc723 --- M bac

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL - Fix Iscsi Actions Params

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: RSDL - Fix Iscsi Actions Params .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2929 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-21 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/2936 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL - fix vm-start params

2012-03-21 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL - fix vm-start params .. restapi: RSDL - fix vm-start params Change-Id: If0c868c352c991b310ab5597fd601b4f632ed5dc --- M backend/manag

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL - fix vm-start params

2012-03-21 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: RSDL - fix vm-start params .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2983 To unsubscribe, visit

  1   2   >