Allon Mureinik has posted comments on this change. Change subject: core: permission filtering for GetStorageDomainsByVmTemplateId ......................................................................
Patch Set 1: (1 inline comment) please add tests, at least for the DAOs. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAOWrapperImpl.java Line 101: I'd extract this part that's shared with the overloaded method to a private helper. -- To view, visit http://gerrit.ovirt.org/2966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I136016e5b2a28c5a0ee4c1ba87b0f1c312db7241 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
