Michael Kublin has posted comments on this change.
Change subject: core: VdsUpdateRunTimeInfo - audit log when mtu on host and
cluster differs
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 544:
second time we are going through all interfaces.
I think we can go only one time
Line 627: for (VdsNetworkInterface iface: interfaces) {
the first time we are going through all interfaces
Line 628: if (iface.getNetworkName() != null &&
clusterNetworkByName.containsKey(iface.getNetworkName())) {
why not inside the same if?
Line 630: AuditLogableBase logable = new AuditLogableBase();
use const like private static String NETWORK_NAME = "NetworkName"
--
To view, visit http://gerrit.ovirt.org/2997
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3fc1e571454de686a943e6d9751087cfdfed9f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
