Maor Lipchuk has posted comments on this change.
Change subject: core: Add disk name and description
..
Patch Set 2:
rebase
--
To view, visit http://gerrit.ovirt.org/2598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add basic search for disks
..
Patch Set 3:
Changes at DiskImageConditionFieldAutoCompleter:
1. Removed funny remarks from last patch
2. changes the field
Eli Mesika has posted comments on this change.
Change subject: core: new GetAllAuditLogsByVMTemplateNameQuery
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2
Eli Mesika has posted comments on this change.
Change subject: core: AuditLogDAO: get auditlog by VMTemplate name
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2592
To unsubscrib
Eli Mesika has posted comments on this change.
Change subject: core: Clean up warnings from SearchQuery
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2396
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: core: AuditLogDAO: get audit log by VM name
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules/d
Eli Mesika has posted comments on this change.
Change subject: core: Cleanup ConfigurationValues
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2384
To unsubscribe, visit http://
Eli Mesika has posted comments on this change.
Change subject: core: Cleanup GetConfigurationValueParameters
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2383
To unsubscribe, v
Eli Mesika has posted comments on this change.
Change subject: core: Cleanup GetConfigurationValueQuery
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2382
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Adding quota id when updating image
..
core: Adding quota id when updating image
Re-adding set for quota id when updating image at diskImageDAO
Change-Id:
Idan Mansano has uploaded a new change for review.
Change subject: packaging: enable ovirt installation on lower ports
..
packaging: enable ovirt installation on lower ports
Install ovirt on ports <1024 using apache_mod_ssl
And
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: ImageResourceColumn cleanup
..
webadmin: ImageResourceColumn cleanup
1. gwt-common's ImageResourceColumn now uses StyledImageResourceCell
a
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: ImageResourceColumn cleanup
..
Patch Set 2: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/2583
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Host config local storage CSS fix
..
webadmin: Host config local storage CSS fix
Fixed a typo within UiBinder's declaration,
which was causin
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Host config local storage CSS fix
..
Patch Set 3: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: ApplicationPlaces cleanup
..
webadmin: ApplicationPlaces cleanup
Removed unnecessary get*Place() methods. These methods were originally
meant
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: ApplicationPlaces cleanup
..
Patch Set 3: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/2575
To
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: ApplicationPlaces cleanup
..
Patch Set 3:
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/2575
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Do not return config on SnapshotDao.getAll
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2610
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4:
Returning true or false is inconsequential to the general philosophy of early
return.
You return early, with any
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Sub-tab presenter cleanup
..
userportal: Sub-tab presenter cleanup
1. Removed code duplicity in Virtual Machine sub-tab presenters
by int
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Sub-tab presenter cleanup
..
Patch Set 5: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/2572
Allon Mureinik has posted comments on this change.
Change subject: core: Rename getFomVm -> getAll
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2609
To unsubscribe, v
Vojtech Szocs has submitted this change and it was merged.
Change subject: gwt: Updated .gitignore file
..
gwt: Updated .gitignore file
Removed obsolete entries for SharedGwt module,
which no longer exists.
Change-Id: Id12ad82
Vojtech Szocs has posted comments on this change.
Change subject: gwt: Updated .gitignore file
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2570
To unsubscribe, visit http://ger
Vojtech Szocs has posted comments on this change.
Change subject: userportal: VM Monitor sub-tab
..
Patch Set 6: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/2568
To unsu
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: VM Monitor sub-tab
..
userportal: VM Monitor sub-tab
In original UserPortal (SmartGWT), the application code was
responsible for refreshing
Shireesh Anjal has posted comments on this change.
Change subject: core: adding service strategy for gluster integration
..
Patch Set 9:
In MonitoringStrategy, why should processSoftwareCapabilities return boolean
when process
Shireesh Anjal has posted comments on this change.
Change subject: core: adding service strategy for gluster integration
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Vojtech Szocs has posted comments on this change.
Change subject: userportal: VM Application sub-tab
..
Patch Set 6: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://gerrit.ovirt.org/2467
To
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: VM Application sub-tab
..
userportal: VM Application sub-tab
- Extracted VM Application sub-tab content from WebAdmin into GwtCommon
- Used
Mike Kolesnik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
Patch Set 3: Verified
Fixed after amureini's review
--
To view, visit http://gerrit.ovirt.org/2600
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2600
To un
Mike Kolesnik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
Patch Set 2: (2 inline comments)
File
backend/manager/module
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Do not return config on SnapshotDao.getAll
..
core: Do not return config on SnapshotDao.getAll
When getting all snapshots by VM ID, do not return the conf
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Rename getFomVm -> getAll
..
core: Rename getFomVm -> getAll
This naming convention is preferred, no need to specify the parameters
names in the method it
Yaniv Dary has uploaded a new change for review.
Change subject: etl: added etl engine check
..
etl: added etl engine check
etl now checks if engine backend is available before starting
and fails to start if unreachable. etl als
Daniel Erez has posted comments on this change.
Change subject: userportal: VM Monitor sub-tab
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2568
To unsubscribe, visit http://ger
Daniel Erez has posted comments on this change.
Change subject: userportal: VM Application sub-tab
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2467
To unsubscribe, visit http:/
Vojtech Szocs has posted comments on this change.
Change subject: userportal: VM Application sub-tab
..
Patch Set 5:
Bad news, ImportVmPopupView uses custom CellTable implementation
(IVdcQueryableCellTable), instead of standar
Vojtech Szocs has posted comments on this change.
Change subject: userportal: VM Application sub-tab
..
Patch Set 5:
Right, besides VM Application sub-tab, VmAppListModel is also used in
ImportVmPopupView. I'll try to reuse Vm
Allon Mureinik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
Patch Set 2: (2 inline comments)
We had a miss-communication about the javadoc issues - I meant the entire
block
Gilad Chaplik has posted comments on this change.
Change subject: userportal: VM Application sub-tab
..
Patch Set 5:
What about other places we use app lists? for instance, import VMs subtab (in
storage tab in case the selecte
Gilad Chaplik has posted comments on this change.
Change subject: userportal: VM Application sub-tab
..
Patch Set 5:
What about other places we use app lists? for instance, import VMs subtab (in
storage tab in case the selecte
Michael Kublin has submitted this change and it was merged.
Change subject: core: Fix Run VM on old cluster with inactive disk
..
core: Fix Run VM on old cluster with inactive disk
Need to support unplugged disks on old cluster
Michael Kublin has posted comments on this change.
Change subject: core: Fix Run VM on old cluster with inactive disk
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2556
To unsubscribe, vis
Gilad Chaplik has posted comments on this change.
Change subject: userportal: VM Application sub-tab
..
Patch Set 5:
What about other places we use app lists? for instance, import VMs subtab (in
storage tab in case the selecte
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Sub-tab presenter cleanup
..
--
To view, visit http://gerrit.ovirt.org/2572
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTy
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Sub-tab presenter cleanup
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2572
To unsubscribe, visit http://gerr
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: simple CSS improvements
..
userportal: simple CSS improvements
- added overflow auto for the list items view
- enlarged the vm item a bit (the image
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: VM view -> console buttons
..
userportal: VM view -> console buttons
Implementation of the open console and edit console buttons on the rows
of the
Gilad Chaplik has posted comments on this change.
Change subject: userportal: VM Monitor sub-tab
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2568
To unsubscribe, vis
Mike Kolesnik has posted comments on this change.
Change subject: core: Fix Run VM on old cluster with inactive disk
..
Patch Set 2: Verified
Fixed after mkublin review
--
To view, visit http://gerrit.ovirt.org/2556
To unsubsc
Mike Kolesnik has posted comments on this change.
Change subject: core: Fix Run VM on old cluster with inactive disk
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: ImageResourceColumn cleanup
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2583
To unsubscribe, visit http://gerr
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: ApplicationPlaces cleanup
..
--
To view, visit http://gerrit.ovirt.org/2575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType
Roy Golan has posted comments on this change.
Change subject: core: prevent attaching a non-VM-network on old clusters
..
Patch Set 1: (1 inline comment)
File
backend/manage
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Host config local storage CSS fix
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2576
To unsubscribe, v
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: ApplicationPlaces cleanup
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2575
To unsubscribe, visit http://gerrit
Gilad Chaplik has posted comments on this change.
Change subject: gwt: Updated .gitignore file
..
--
To view, visit http://gerrit.ovirt.org/2570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comme
Gilad Chaplik has posted comments on this change.
Change subject: gwt: Updated .gitignore file
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2570
To unsubscribe, visit http://gerrit.ovirt.
Omer Frenkel has posted comments on this change.
Change subject: core: adding service strategy for gluster integration
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2387
To unsubscribe, v
Omer Frenkel has posted comments on this change.
Change subject: core: Add disk name and description
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2598
To unsubscribe, visit http://gerrit.
Mike Kolesnik has posted comments on this change.
Change subject: core: Restore missing image as ILLEGAL
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, ack (+2) by ofrenkel
--
To view, visit http://gerrit.ovirt.
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Move disk/device deletion to RemoveImage
..
core: Move disk/device deletion to RemoveImage
This command actually deletes the whole disk, so no nee
Mike Kolesnik has posted comments on this change.
Change subject: core: Move disk/device deletion to RemoveImage
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, ack (+2) by ofrenkel
--
To view, visit http://gerri
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: No need to mark snapshot BROKEN
..
core: No need to mark snapshot BROKEN
Since snapshot preview will return deleted images in status ILLEGAL,
then
Mike Kolesnik has posted comments on this change.
Change subject: core: No need to mark snapshot BROKEN
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, ack (+2) by ofrenkel
--
To view, visit http://gerrit.ovirt.o
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Restore missing image as ILLEGAL
..
core: Restore missing image as ILLEGAL
If image is missing, this means it got deleted somehow, so restore it a
Michael Pasternak has posted comments on this change.
Change subject: cli: implement support for multi-argument methods in sdk
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2604
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: implement support for multi-argument methods in sdk
..
cli: implement support for multi-argument methods in sdk
Change-Id: Id4d45135816eccc718e
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Clean up RemoveImageParameters
..
core: Clean up RemoveImageParameters
1. Odered fields to be on top.
2. Moved ctors on top of accessors.
3. Clean
Mike Kolesnik has posted comments on this change.
Change subject: core: Clean up RemoveImageParameters
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, ack (+2) by ofrenkel
--
To view, visit http://gerrit.ovirt.or
Omer Frenkel has posted comments on this change.
Change subject: engine: Add basic search for disks
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/searchba
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: do not sort options for create/action commands
..
cli: do not sort options for create/action commands
Change-Id: I52f36c459f9bbfc5edcc5b6396015
Michael Pasternak has posted comments on this change.
Change subject: cli: do not sort options for create/action commands
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2603
To un
Michael Pasternak has uploaded a new change for review.
Change subject: cli: implement support for multi-argument methods in sdk
..
cli: implement support for multi-argument methods in sdk
Change-Id: Id4d45135816eccc718ec62702e9
Michael Pasternak has uploaded a new change for review.
Change subject: cli: do not sort options for create/action commands
..
cli: do not sort options for create/action commands
Change-Id: I52f36c459f9bbfc5edcc5b639601563d0833b
Allon Mureinik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2600
To un
Allon Mureinik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
--
To view, visit http://gerrit.ovirt.org/2600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Mike Kolesnik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
Patch Set 2:
Fixed after amureini's review
--
To view, visit http://gerrit.ovirt.org/2600
To unsubscribe, visit h
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Added user filtering to SnapshotDao.getForVm
..
core: Added user filtering to SnapshotDao.getForVm
Need to filter this query so that user portal c
Mike Kolesnik has posted comments on this change.
Change subject: core: Added user filtering to SnapshotDao.getForVm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2599
To unsubscribe, visit http://gerrit.ov
ovirt_engine_unit_tests - Build # 290 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/290/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinf
Mike Kolesnik has posted comments on this change.
Change subject: core: Add query to retrieve Snapshots of VM
..
Patch Set 1: (3 inline comments)
File
backend/manager/module
Barak Azulay has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 2: (1 inline comment)
- I prefer the mem info to be delivered in the heartbeat (see my r
Omer Frenkel has posted comments on this change.
Change subject: core: Restore missing image as ILLEGAL
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2563
To unsubscribe, visit http://gerr
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Remote DB support - DO NOT MERGE.
..
Patch Set 10: Fails
(9 inline comments)
Multiple issues inline.
including:
1. Can't change password for rem
Omer Frenkel has posted comments on this change.
Change subject: core: Added user filtering to SnapshotDao.getForVm
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2599
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: core : Fixing a bug of ignoring results at child commands
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2593
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetConfigurationValueQuery
..
Patch Set 12: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review
--
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetConfigurationValueParameters
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/2383
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup ConfigurationValues
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/2384
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: AuthType for configuration values
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/2385
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: User Configuration Values
..
Patch Set 11: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: core: Filtering for GetConfigurationValueQuery
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/2395
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up warnings from SearchQuery
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/2396
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: AuditLogDAO: get audit log by VM name
..
Patch Set 10: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +1 review.
Allon Mureinik has posted comments on this change.
Change subject: core: new GetAllAuditLogsByVMNameQuery
..
Patch Set 10: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +1 review.
--
T
Allon Mureinik has posted comments on this change.
Change subject: core: AuditLogDAO: get auditlog by VMTemplate name
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/2592
To unsubscribe, visit http://gerrit.o
1 - 100 of 175 matches
Mail list logo
