Barak Azulay has posted comments on this change.

Change subject: Add more detailed memory statistics function to guest agent.
......................................................................


Patch Set 2: (1 inline comment)

- I prefer the mem info to be delivered in the heartbeat (see my response in 
thread)
- what about the windows code (differs from linux)
- need to add the cosponsoring code in VDSM (that collects the data)
- need to make sure VDSM code doesn't break in case the new data doesn't exist 
(for backwards compatibility)

....................................................
File ovirt-guest-agent/GuestAgentWin32.py
Line 329: 
Why doesn't the windows guest code return the additional datat added to the 
linux code ?

--
To view, visit http://gerrit.ovirt.org/2272
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93b8717f99f033caf2b5dc2404a55f903bf4b0a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to